Files
calendar/packages/features/credentials/deleteCredential.test.ts
T
devin-ai-integration[bot]GitHubDevin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>morgan@cal.com <morgan@cal.com>Morgan
e4c47640fc refactor: convert UserRepository to use dependency injection pattern (#22360)
* refactor: convert UserRepository to use dependency injection pattern

- Convert all static methods to public instance methods
- Add constructor that takes PrismaClient parameter
- Update all usage sites to use new instantiation pattern: new UserRepository(prisma).method()
- Follow same pattern as PrismaOOORepository for consistency
- Maintain all existing method logic and signatures unchanged
- Update 125+ files across the codebase to adapt to new pattern

Co-Authored-By: morgan@cal.com <morgan@cal.com>

* optimize: reuse UserRepository instances within same function scope

- Create single UserRepository instance per function scope
- Reuse instance for multiple method calls within same function
- Reduces object instantiation overhead and improves performance
- Apply optimization pattern consistently across codebase

Co-Authored-By: morgan@cal.com <morgan@cal.com>

* fix: repository

* fixup! fix: repository

* fixup! fixup! fix: repository

* fixup! fixup! fixup! fix: repository

* fix: update test mocking strategies for UserRepository dependency injection

- Convert static method mocks to instance method mocks in userCreationService.test.ts
- Update vi.spyOn calls to work with constructor injection pattern in getAllCredentials.test.ts
- Fix UserRepository mocking in getRoutedUrl.test.ts to use constructor injection
- Ensure consistent mocking approach across all test files
- Fix 'UserRepository is not a constructor' errors in tests

Co-Authored-By: morgan@cal.com <morgan@cal.com>

* feat: optimize UserRepository instance reuse and add SessionUser type

- Reuse UserRepository instance in OrganizationRepository.createWithNonExistentOwner
- Add comprehensive SessionUser type definition for type safety
- Improve type constraints in enrichUserWithTheProfile and enrichUserWithItsProfile
- Ensure proper return types with profile information

Co-Authored-By: morgan@cal.com <morgan@cal.com>

* fix: make UserRepository mocking strategy more robust for CI environments

- Add defensive checks for vi.mocked() to handle CI environment differences
- Ensure mockImplementation is available before calling it
- Maintain consistent mocking pattern across all test files
- Fix 'Cannot read properties of undefined' error in CI

Co-Authored-By: morgan@cal.com <morgan@cal.com>

* fixup! fix: make UserRepository mocking strategy more robust for CI environments

* refactor: convert direct UserRepository instantiations to two-step pattern

- Change await new UserRepository(prisma).method(...) to const userRepo = new UserRepository(prisma); await userRepo.method(...)
- Optimize instance reuse within same function scopes
- Apply pattern consistently across all modified files in PR
- Fix type errors in organization.ts and sessionMiddleware.ts

Co-Authored-By: morgan@cal.com <morgan@cal.com>

* refactor: complete two-step UserRepository pattern for remaining files

- Apply two-step instantiation pattern to all remaining modified files in PR
- Ensure consistent UserRepository usage across entire codebase
- Maintain instance reuse optimization within function scopes

Co-Authored-By: morgan@cal.com <morgan@cal.com>

* chore: bump platform libs

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: morgan@cal.com <morgan@cal.com>
Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com>
2025-07-10 12:11:14 +00:00

134 lines
4.3 KiB
TypeScript

import {
addEventTypesToDb,
mockNoTranslations,
} from "@calcom/web/test/utils/bookingScenario/bookingScenario";
import { describe, test, expect, beforeEach } from "vitest";
import { AppRepository } from "@calcom/lib/server/repository/app";
import { CredentialRepository } from "@calcom/lib/server/repository/credential";
import { DestinationCalendarRepository } from "@calcom/lib/server/repository/destinationCalendar";
import { EventTypeRepository } from "@calcom/lib/server/repository/eventType";
import { UserRepository } from "@calcom/lib/server/repository/user";
import prisma from "@calcom/prisma";
const testUser = {
email: "test@test.com",
username: "test-user",
organizationId: null,
};
const setupCredential = async (credentialInput) => {
const exampleCredential = {
id: 123,
type: "test-credential",
appId: "test-credential",
userId: null,
teamId: null,
};
return await CredentialRepository.create({ ...exampleCredential, ...credentialInput });
};
describe("deleteCredential", () => {
beforeEach(async () => {
mockNoTranslations();
});
describe("individual credentials", () => {
test("Delete video credential", async () => {
const handleDeleteCredential = (await import("./handleDeleteCredential")).default;
const user = await new UserRepository(prisma).create({
...testUser,
});
await addEventTypesToDb([
{
id: 1,
userId: user.id,
locations: [{ type: "integrations:zoom" }],
},
{
id: 2,
userId: user.id,
locations: [{ type: "integrations:msteams" }],
},
]);
await AppRepository.seedApp("zoomvideo");
await setupCredential({ userId: user.id, type: "zoom_video", appId: "zoom" });
await handleDeleteCredential({ userId: user.id, userMetadata: user.metadata, credentialId: 123 });
const eventTypeQuery = await EventTypeRepository.findAllByUserId({ userId: user.id });
// Ensure that the event type with the deleted app was converted back to daily
const changedEventType = eventTypeQuery.find((eventType) => eventType.id === 1)?.locations;
expect(changedEventType).toBeDefined();
expect(changedEventType![0]).toEqual({ type: "integrations:daily" });
const nonChangedEventType = eventTypeQuery.find((eventType) => eventType.id === 2)?.locations;
expect(nonChangedEventType).toBeDefined();
expect(nonChangedEventType![0]).toEqual({ type: "integrations:msteams" });
});
test("Delete calendar credential", async () => {
const handleDeleteCredential = (await import("./handleDeleteCredential")).default;
const user = await new UserRepository(prisma).create({
...testUser,
});
const eventTypes = await addEventTypesToDb([
{
id: 1,
userId: testUser.id,
},
]);
await AppRepository.seedApp("googlecalendar");
const credential = await setupCredential({
userId: user.id,
type: "google_calendar",
appId: "google-calendar",
});
await DestinationCalendarRepository.create({
id: 1,
integration: "google_calendar",
externalId: "test@google.com",
primaryId: "test@google.com",
userId: user.id,
credentialId: credential.id,
});
await DestinationCalendarRepository.create({
id: 2,
integration: "google_calendar",
externalId: "test@google.com",
primaryId: "test@google.com",
eventTypeId: eventTypes[0].id,
credentialId: credential.id,
});
const userCalendar = await DestinationCalendarRepository.getByUserId(user.id);
expect(userCalendar).toBeDefined();
const eventTypeCalendar = await DestinationCalendarRepository.getByEventTypeId(eventTypes[0].id);
expect(eventTypeCalendar).toBeDefined();
await handleDeleteCredential({ userId: user.id, userMetadata: user.metadata, credentialId: 123 });
const userCalendarAfter = await DestinationCalendarRepository.getByUserId(user.id);
expect(userCalendarAfter).toBeNull();
const eventTypeCalendarAfter = await DestinationCalendarRepository.getByEventTypeId(eventTypes[0].id);
expect(eventTypeCalendarAfter).toBeNull();
});
// TODO: Add test for payment apps
// TODO: Add test for event type apps
});
});