Omar LópezandGitHub f4f4afad39 perf: optimize team admin check queries (#17681) ...

## What does this PR do?

Optimizes team and organization admin checks by:
- Removing unnecessary member data fetching in profile repository
- Simplifying team admin verification query to directly check membership
- Refactoring organization admin check to use the optimized team verification method

## Mandatory Tasks

- [x] I have self-reviewed the code
- [x] I have updated the developer docs in /docs
- [ ] I confirm automated tests are in place

## How should this be tested?

1. Log in as a team admin/owner
2. Verify team admin privileges still work correctly
3. Log in as an organization admin
4. Confirm organization admin permissions are maintained
5. Check that admin-only features remain accessible

Expected behavior:
- Team admins/owners should retain all their existing permissions
- Organization admins should maintain their administrative capabilities
- No degradation in admin functionality while improving query performance

## Checklist

- I haven't read the [contributing guide](https://github.com/calcom/cal.com/blob/main/CONTRIBUTING.md)
- My code doesn't follow the style guidelines of this project
- I haven't commented my code, particularly in hard-to-understand areas
- I haven't checked if my changes generate no new warnings

2024-11-15 19:00:18 -07:00

..

__mocks__

fix: Reschedule URL for an org migrated/moved user's booking. (#15736)

2024-07-31 14:25:46 +02:00

__tests__

fix: Location Change to Organizer Default Conferencing App (#16379)

2024-09-11 21:31:53 +09:00

apps

feat: app install flow followup (#15193)

2024-07-08 19:15:57 +02:00

bookings

feat: Implements maxLeadThreshold (#17643)

2024-11-15 15:54:02 +00:00

browser

chore: add canonical to the document via PageWrapper (#8639)

2023-06-02 18:28:03 +00:00

cva

refactor: Moving from jest to vitest (#9035)

2023-05-24 23:35:44 +00:00

date-fns

feat: add utcOffset in webhook payload (#12709)

2024-01-11 14:35:02 +00:00

domainManager

fix: Organizations Admin improvements (#13656)

2024-02-14 10:34:45 -03:00

event-types

fix: v2 event types booking fields & enable booker atom google-meet location (#17321)

2024-10-25 15:55:29 +03:00

getBookerUrl

fix: Team and User Links (#15342)

2024-06-06 11:40:29 +00:00

hooks

fix: virtualised member list for reassign (#17386)

2024-10-29 17:47:43 +00:00

payment

feat: booking with phone number (#14461)

2024-09-11 17:56:04 -07:00

schedules

refactor: v2 schedules (#15403)

2024-06-11 14:35:53 +00:00

server

perf: optimize team admin check queries (#17681)

2024-11-15 19:00:18 -07:00

sync

chore: Cleanup Close.com (#16929)

2024-11-13 15:14:31 -05:00

test

feat: Implements maxLeadThreshold (#17643)

2024-11-15 15:54:02 +00:00

array.ts

New Booker Component (preparations for booker atom) (#6792)

2023-04-24 16:32:30 +02:00

availability.ts

refactor: v2 schedules (#15403)

2024-06-11 14:35:53 +00:00

bookingSuccessRedirect.ts

fix: split firstname lastname support, phone support & timezone specific startTime in success redirect params (#17593)

2024-11-12 11:16:41 +00:00

buildCalEventFromBooking.ts

fix: Location Change to Organizer Default Conferencing App (#16379)

2024-09-11 21:31:53 +09:00

CalendarService.ts

feat: Add hideCalendarEventDetails option to event types (#16817)

2024-09-26 17:08:25 +00:00

CalEventParser.ts

chore: Fixing ICS file in workflows & ICS calendar descriptions [CAL-4409] (#16731)

2024-10-07 10:50:50 -04:00

checkIfItFallbackImage.ts

fix avatar remove button (#12249)

2023-11-15 15:23:33 +05:30

checkRateLimitAndThrowError.test.ts

fix: use 'success' value for better accuracy (#14624)

2024-04-17 14:01:13 +00:00

checkRateLimitAndThrowError.ts

fix: reviewed-user-sms-lock (#16016)

2024-08-12 08:12:48 +02:00

classNames.ts

Tailwind Merge (#6596)

2023-01-20 15:19:12 +01:00

CloseCom.ts

refactor: Introduce crmManager (#14272)

2024-05-31 13:54:52 +00:00

CloseComeUtils.ts

refactor: Introduce crmManager (#14272)

2024-05-31 13:54:52 +00:00

connectedCalendar.ts

fix: Update credentialId when null for a given selectedCalendar (#13735)

2024-02-22 12:05:46 +00:00

constants.ts

Update constants.ts - fix crashing by adding optional chaining for this value (#17103)

2024-10-15 07:32:27 +00:00

contructEmailFromPhoneNumber.ts

feat: booking with phone number (#14461)

2024-09-11 17:56:04 -07:00

convertToNewDurationType.ts

Fixed wrong calculation of duration type on event type page. (#5557)

2022-11-17 13:38:03 +05:30

createAProfileForAnExistingUser.ts

fix: platform orgs shouldn't have org redirect (#16032)

2024-08-02 20:34:11 +03:00

crypto.ts

refactor: Use template literal instead of '+' operator (#11444)

2023-10-03 11:52:19 -07:00

csvUtils.ts

feat: insights routing forms (#17583)

2024-11-15 14:54:51 -05:00

dailyApiFetcher.ts

feat: automatic no show (#16727)

2024-10-10 10:57:04 -07:00

date-ranges.test.ts

feat: travel schedules to schedule timezone changes (#14512)

2024-04-12 17:57:28 +00:00

date-ranges.ts

feat: travel schedules to schedule timezone changes (#14512)

2024-04-12 17:57:28 +00:00

default-cookies.ts

test: Hotfix/Orgs rewrite causing 404 with 3 or more dots domains (#9803)

2023-06-27 12:01:30 -07:00

defaultAvatarImage.ts

fix: #14769 (#14777)

2024-04-27 18:14:37 +02:00

defaultEvents.ts

feat: Implements maxLeadThreshold (#17643)

2024-11-15 15:54:02 +00:00

deriveAppDictKeyFromType.ts

chore: removed last web3 references (#12540)

2023-11-29 11:57:50 +00:00

emailSchema.ts

fix: email-address with apostrophe not accepted (#15535)

2024-10-15 00:21:26 +00:00

entityPermissionUtils.ts

perf: routing forms loading time (#17518)

2024-11-12 17:32:42 +05:30

env.ts

Feature: Verify login on signup with magic link. (#2122)

2022-04-21 14:32:25 -06:00

errorCodes.ts

fix: better errors for platform (#14987)

2024-05-14 11:56:44 -07:00

errors.ts

fix: Credential Syncing Improvements (#14588)

2024-04-25 12:47:17 -04:00

extract-base-email.ts

chore: Add guest email blacklist (#15255)

2024-05-30 17:13:34 +00:00

fetch-wrapper.ts

New Booker Component (preparations for booker atom) (#6792)

2023-04-24 16:32:30 +02:00

fetchUsername.ts

fix: Correctly prefill username in case of non-org email invite in an org (#12854)

2023-12-19 02:44:48 +00:00

findDurationType.ts

Enforces explicit type imports (#7158)

2023-02-16 15:39:57 -07:00

formatCalendarEvent.ts

chore: enable platform emails (#14471)

2024-04-12 22:39:01 +03:00

formbricks-client.ts

chore: update formbricks-js to newest version (#15146)

2024-07-03 17:27:39 +02:00

formbricks.ts

feat: integrate formbricks for team disband action (#13362)

2024-02-07 04:14:26 -03:00

fromEntriesWithDuplicateKeys.ts

feat: advanced tab platform wrapper (#16941)

2024-10-10 17:09:03 +03:00

generateHashedLink.ts

feat: Multiple Private links per Event Type (#15896)

2024-10-03 00:58:54 +05:30

getAdditionalEmailHeaders.ts

fix: add sendgrid-specific header only for SendGrid smtp server (#11932)

2023-11-16 13:51:30 -03:00

getAvatarUrl.ts

chore: Remove all avatar/logo references (#14532)

2024-04-18 21:54:16 -07:00

getBooking.tsx

perf: bookings query improvement (#10687)

2023-08-24 11:14:10 +02:00

getBrandColours.test.ts

refactor: Moving from jest to vitest (#9035)

2023-05-24 23:35:44 +00:00

getBrandColours.tsx

fix: Use constants.ts for brand colours > db DEFAULT (#13167)

2024-01-11 20:22:35 +00:00

getClientErrorFromUnknown.ts

fix: Remove the right date override on removal (#13988)

2024-03-13 20:30:28 +00:00

getConnectedDestinationCalendars.ts

feat: v1 api connected-calendars endpoint (#14176)

2024-03-26 13:58:54 +00:00

getIP.ts

use cloudflare real IP (#10449)

2023-07-28 15:11:44 +00:00

getLabelValueMapFromResponses.ts

fix: phone number input field is missing from mail (#17035)

2024-10-11 11:17:18 +00:00

getLocaleFromRequest.ts

chore: bump @trpc/* and @tanstack/react-query (#13335)

2024-01-23 16:42:29 -07:00

getMetadataHelpers.ts

feat: admin org list now shows all, dns check added (#10875)

2023-08-23 21:01:12 +00:00

getOrgIdFromMemberOrTeamId.ts

feat: org-wide webhooks (#15144)

2024-06-04 20:16:46 +00:00

getPaymentAppData.ts

refactor: handleNewBooking #3 (#15612)

2024-07-08 18:18:36 +00:00

getSafeRedirectUrl.ts

Make sure returnTo is correct URL (#6189)

2023-01-05 12:55:55 -07:00

getTeamIdFromEventType.ts

fix: Managed Event Type Webhooks (#10300)

2023-07-25 13:05:02 -04:00

getValidRhfFieldName.test.ts

feat: bookingFields identifier supports - and _ characters (#16353)

2024-08-26 12:15:02 +02:00

getValidRhfFieldName.ts

feat: bookingFields identifier supports - and _ characters (#16353)

2024-08-26 12:15:02 +02:00

google.ts

chore: remove wrong logs (#17648)

2024-11-14 18:57:51 +00:00

gtm.ts

feat: gtm push signup event (#14031)

2024-03-08 15:13:29 +00:00

hasEditPermissionForUser.ts

perf: Server-Side Data Fetching in App Router: /availability (#16536)

2024-09-10 19:23:42 -07:00

hasKeyInMetadata.ts

feature/settings-username-update (#2306)

2022-07-06 13:31:07 -06:00

http-error.ts

Stripe to monorepo (#2063)

2022-03-09 15:56:05 -07:00

i18n.ts

Fallback to next app default language (en) when user didn't specify locale. (#16425)

2024-08-30 21:37:10 +05:30

index.ts

feat: Assign colors to events (#15298)

2024-08-14 15:10:40 +02:00

intervalLimit.ts

fix: all booking and duration limits (#10480)

2023-08-09 15:51:38 -07:00

invertLogoOnDark.ts

fix: logo lack of contrast (#12401)

2023-11-17 14:10:58 +00:00

isBookingLimits.ts

feat(lib): add more tests to lib package (#7210)

2023-03-10 22:10:56 +00:00

isDurationLimits.ts

[CAL-988] Limit total appointment time per day/week/month/year (#7166)

2023-03-10 21:00:19 +01:00

isEventTypeColor.ts

feat: Assign colors to events (#15298)

2024-08-14 15:10:40 +02:00

isKeyInObject.ts

Adds basic global feature flags (#7459)

2023-03-24 17:59:04 -07:00

isMac.ts

Adds a fully extensible command(ctrl)+k interface for Cal (#3346)

2022-07-14 06:45:07 +00:00

isOutOfBounds.timezone.test.ts

fix: Future Limit Calculations (#15825)

2024-08-02 18:00:50 +05:30

isOutOfBounds.tsx

fix: Future Limit Calculations (#15825)

2024-08-02 18:00:50 +05:30

isPrismaObj.ts

License server (#2379)

2022-05-26 11:07:14 -06:00

isProblematicTimezone.ts

Fix: Filter Timezones by cities (#7540)

2023-03-06 17:52:20 +00:00

isRecurringEvent.ts

feat(lib): add more tests to lib package (#7210)

2023-03-10 22:10:56 +00:00

isSmsCalEmail.ts

feat: booking with phone number (#14461)

2024-09-11 17:56:04 -07:00

jest.config.json

refactor: v2 event-types (#15457)

2024-06-21 10:49:12 +00:00

jsonUtils.ts

App Store (#1869)

2022-03-23 15:00:30 -07:00

logger.ts

fix: Better defaulting to NEXT_PUBLIC_LOGGER_LEVEL=4 (#16900)

2024-10-01 17:38:02 +00:00

markdownIt.ts

Fixes formatted description in email + sanitize html everywhere (#7928)

2023-03-28 09:40:13 +00:00

markdownToSafeHTML.ts

perf: Booker bundle size optimization - Remove sanitize-html dependency on client (#10801)

2023-08-16 11:03:21 -07:00

markdownToSafeHTMLClient.ts

feat: advanced tab platform wrapper (#16941)

2024-10-10 17:09:03 +03:00

navigateInTopWindow.ts

fix: Broken navigation after booking creation in some cases (#15664)

2024-07-08 13:56:58 +00:00

next-seo.config.ts

chore: Adds deprecated-imports-next-router (#14486)

2024-04-16 11:46:45 +01:00

notEmpty.ts

App Store (#1869)

2022-03-23 15:00:30 -07:00

objectKeys.ts

Enables strict mode in nextjs apps (#2354)

2022-04-04 20:26:14 +00:00

OgImages.tsx

fix: avatars are not showing in preview image (#17592)

2024-11-12 07:57:06 +00:00

package.json

chore: upgrade @vercel/og lib (#17503)

2024-11-13 13:50:21 -07:00

parse-dates.ts

fix: recurring events with calendar connections (#12250)

2023-11-07 12:09:56 -03:00

parse-zone.ts

New Booker Component (preparations for booker atom) (#6792)

2023-04-24 16:32:30 +02:00

perf.ts

perf: lazy load tRPC routes (#8167)

2023-04-25 19:39:47 -03:00

piiFreeData.ts

feat: Stripe paid apps flow (#12103)

2023-11-15 09:29:41 -03:00

price.ts

fix: currency conversion error for paypal (#16917)

2024-10-05 01:11:09 +05:30

random.test.ts

refactor: Moving from jest to vitest (#9035)

2023-05-24 23:35:44 +00:00

random.ts

feat(lib): add more tests to lib package (#7210)

2023-03-10 22:10:56 +00:00

rateLimit.ts

feat: SMS/Whatsapp to attendee for teams (#14648)

2024-04-23 19:48:44 +00:00

recurringStrings.ts

fix: Adding yearly title to preview page (#16441)

2024-09-03 09:34:05 -04:00

redactError.ts

fix: minor typo (#12842)

2023-12-19 11:20:54 -03:00

redirect.ts

refactor: Billing service (#15366)

2024-10-04 13:44:50 -07:00

retellAIFetcher.ts

feat: retell AI webhook url (#14430)

2024-04-05 22:44:57 +05:30

safeStringify.ts

fix: Show error log (#14960)

2024-05-10 08:47:57 +01:00

sanitizeCalendarObject.ts

Caldav/refactor: Mutiple Fixes and General code improvement (#8031)

2023-04-12 14:30:39 -03:00

sdk-event.ts

feat: Add framework to send all events fired for embed to Analytics Apps (#15173)

2024-05-31 16:07:09 +00:00

Sendgrid.ts

chore: update tslog from 3.2.1 to 4.9.2 (#11717)

2023-10-17 19:00:48 +00:00

serverConfig.ts

feat: add resend email transport (#12645)

2023-12-04 15:31:55 -08:00

slots.test.ts

fix: improve defined slot start times (#14107)

2024-03-20 12:04:38 -04:00

slots.ts

feat: ooo-v2 (#13621)

2024-04-09 18:29:39 -07:00

slugify.test.ts

fix: slugify from creating double+ dashes (#14002)

2024-03-07 13:34:18 +00:00

slugify.ts

fix: slugify from creating double+ dashes (#14002)

2024-03-07 13:34:18 +00:00

stripMarkdown.ts

fix: strip markdown from meta description tag in users page (#8769)

2023-05-15 07:44:23 +00:00

telemetry.ts

feat: license creation admin PR (#15024)

2024-06-06 18:34:32 +00:00

testEmails.ts

test: testing workflow triggers (#12823)

2023-12-21 18:57:06 +05:30

testSMS.ts

test: add unit tests for sms sending (#14737)

2024-05-02 10:42:38 -04:00

text.test.ts

refactor: Moving from jest to vitest (#9035)

2023-05-24 23:35:44 +00:00

text.ts

feat(lib): add more tests to lib package (#7210)

2023-03-10 22:10:56 +00:00

timeFormat.ts

feat: dynamic time format rendering in workflows based on user settings (#10229)

2023-07-19 10:30:37 -04:00

timezone.ts

fix:CityNotShownInOption (#17064)

2024-10-24 09:10:27 -04:00

totp.ts

fix: add 2fa and email verification grace period (#10771)

2023-08-17 16:13:04 +02:00

tsconfig.json

perf: improve typescript perf by pre-generating the router types (#15929)

2024-08-05 16:49:19 -07:00

tsconfig.test.json

feat(lib): add more tests to lib package (#7210)

2023-03-10 22:10:56 +00:00

turndownService.ts

chore: plain text plugin for Editor (#17134)

2024-11-11 20:23:12 +05:30

validateBookerLayouts.ts

feat: event settings booker layout toggle (#9082)

2023-06-06 15:31:43 +00:00

validateIntervalLimitOrder.ts

fix: all booking and duration limits (#10480)

2023-08-09 15:51:38 -07:00

validateUsername.ts

fix: Revert -> "Revert "chore: Chore team metadata table + isOrganization migration (#13700)

2024-03-01 15:04:28 +00:00

WebAppURL.ts

chore: Introduce a new class WebAppURL that extends URL (#14982)

2024-07-18 07:27:34 +00:00

webstorage.ts

Add removeItem to webstorage

2023-11-11 11:16:35 +00:00

weekday.test.ts

refactor: Moving from jest to vitest (#9035)

2023-05-24 23:35:44 +00:00

weekday.ts

feat(lib): add more tests to lib package (#7210)

2023-03-10 22:10:56 +00:00

weekstart.test.ts

fix: #15749 Display availability page as per weekstart setting (#15753)

2024-07-16 11:31:02 +02:00

weekstart.ts

fix: #15749 Display availability page as per weekstart setting (#15753)

2024-07-16 11:31:02 +02:00