Files
calendar/packages/lib/server/repository/user.test.ts
T
devin-ai-integration[bot]GitHubDevin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>morgan@cal.com <morgan@cal.com>Morgan
e4c47640fc refactor: convert UserRepository to use dependency injection pattern (#22360)
* refactor: convert UserRepository to use dependency injection pattern

- Convert all static methods to public instance methods
- Add constructor that takes PrismaClient parameter
- Update all usage sites to use new instantiation pattern: new UserRepository(prisma).method()
- Follow same pattern as PrismaOOORepository for consistency
- Maintain all existing method logic and signatures unchanged
- Update 125+ files across the codebase to adapt to new pattern

Co-Authored-By: morgan@cal.com <morgan@cal.com>

* optimize: reuse UserRepository instances within same function scope

- Create single UserRepository instance per function scope
- Reuse instance for multiple method calls within same function
- Reduces object instantiation overhead and improves performance
- Apply optimization pattern consistently across codebase

Co-Authored-By: morgan@cal.com <morgan@cal.com>

* fix: repository

* fixup! fix: repository

* fixup! fixup! fix: repository

* fixup! fixup! fixup! fix: repository

* fix: update test mocking strategies for UserRepository dependency injection

- Convert static method mocks to instance method mocks in userCreationService.test.ts
- Update vi.spyOn calls to work with constructor injection pattern in getAllCredentials.test.ts
- Fix UserRepository mocking in getRoutedUrl.test.ts to use constructor injection
- Ensure consistent mocking approach across all test files
- Fix 'UserRepository is not a constructor' errors in tests

Co-Authored-By: morgan@cal.com <morgan@cal.com>

* feat: optimize UserRepository instance reuse and add SessionUser type

- Reuse UserRepository instance in OrganizationRepository.createWithNonExistentOwner
- Add comprehensive SessionUser type definition for type safety
- Improve type constraints in enrichUserWithTheProfile and enrichUserWithItsProfile
- Ensure proper return types with profile information

Co-Authored-By: morgan@cal.com <morgan@cal.com>

* fix: make UserRepository mocking strategy more robust for CI environments

- Add defensive checks for vi.mocked() to handle CI environment differences
- Ensure mockImplementation is available before calling it
- Maintain consistent mocking pattern across all test files
- Fix 'Cannot read properties of undefined' error in CI

Co-Authored-By: morgan@cal.com <morgan@cal.com>

* fixup! fix: make UserRepository mocking strategy more robust for CI environments

* refactor: convert direct UserRepository instantiations to two-step pattern

- Change await new UserRepository(prisma).method(...) to const userRepo = new UserRepository(prisma); await userRepo.method(...)
- Optimize instance reuse within same function scopes
- Apply pattern consistently across all modified files in PR
- Fix type errors in organization.ts and sessionMiddleware.ts

Co-Authored-By: morgan@cal.com <morgan@cal.com>

* refactor: complete two-step UserRepository pattern for remaining files

- Apply two-step instantiation pattern to all remaining modified files in PR
- Ensure consistent UserRepository usage across entire codebase
- Maintain instance reuse optimization within function scopes

Co-Authored-By: morgan@cal.com <morgan@cal.com>

* chore: bump platform libs

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: morgan@cal.com <morgan@cal.com>
Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com>
2025-07-10 12:11:14 +00:00

111 lines
2.6 KiB
TypeScript

// eslint-disable-next-line @typescript-eslint/no-unused-vars
import prismock from "../../../../tests/libs/__mocks__/prisma";
import { describe, test, vi, expect, beforeEach } from "vitest";
import { CreationSource } from "@calcom/prisma/enums";
import { UserRepository } from "./user";
vi.mock("@calcom/lib/server/i18n", () => {
return {
getTranslation: (key: string) => {
return () => key;
},
};
});
describe("UserRepository", () => {
beforeEach(() => {
prismock;
});
describe("create", () => {
test("Should create a user without a password", async () => {
const user = await new UserRepository(prismock).create({
username: "test",
email: "test@example.com",
organizationId: null,
creationSource: CreationSource.WEBAPP,
locked: false,
});
expect(user).toEqual(
expect.objectContaining({
username: "test",
email: "test@example.com",
organizationId: null,
creationSource: CreationSource.WEBAPP,
locked: false,
})
);
const password = await prismock.userPassword.findUnique({
where: {
userId: user.id,
},
});
expect(password).toBeNull();
});
test("If locked param is passed, user should be locked", async () => {
const user = await new UserRepository(prismock).create({
username: "test",
email: "test@example.com",
organizationId: null,
creationSource: CreationSource.WEBAPP,
locked: true,
});
const userQuery = await prismock.user.findUnique({
where: {
email: "test@example.com",
},
select: {
locked: true,
},
});
expect(userQuery).toEqual(
expect.objectContaining({
locked: true,
})
);
});
test("If organizationId is passed, user should be associated with the organization", async () => {
const organizationId = 123;
const username = "test";
const user = await new UserRepository(prismock).create({
username,
email: "test@example.com",
organizationId,
creationSource: CreationSource.WEBAPP,
locked: true,
});
expect(user).toEqual(
expect.objectContaining({
organizationId,
})
);
const profile = await prismock.profile.findFirst({
where: {
organizationId,
username,
},
});
expect(profile).toEqual(
expect.objectContaining({
organizationId,
username,
})
);
});
});
});