* feat: add signup watchlist review feature flag and handler logic - Add 'signup-watchlist-review' global feature flag - Add SIGNUP to WatchlistSource enum in Prisma schema - When flag enabled, lock new signups and add email to watchlist - Show 'account under review' message on signup page - Add i18n strings for review UI - Create seed migration for the feature flag Co-Authored-By: alex@cal.com <me@alexvanandel.com> * test: add isAccountUnderReview tests to fetchSignup test suite Co-Authored-By: alex@cal.com <me@alexvanandel.com> * fix: address Cubic AI review feedback (confidence >= 9/10) - Remove 'import process from node:process' in signup-view.tsx (P0 bug in 'use client' component) - Move watchlist review check before checkoutSessionId early return in calcomSignupHandler (P1 premium bypass) - Revert selfHostedHandler to original state (out of scope per user request) - Add test mocks for FeaturesRepository and GlobalWatchlistRepository Co-Authored-By: alex@cal.com <me@alexvanandel.com> * fix: remove node:process import from useFlags.ts (client-side file) Co-Authored-By: alex@cal.com <me@alexvanandel.com> * fix: remove !token condition from watchlist review check Token is present in normal email-verified signups, so the !token condition was incorrectly skipping watchlist review for verified users. Co-Authored-By: alex@cal.com <me@alexvanandel.com> * Apply suggestion from @cubic-dev-ai[bot] Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> * refactor: move user lock to UserRepository.lockByEmail Co-Authored-By: alex@cal.com <me@alexvanandel.com> * refactor: use cached getFeatureRepository() instead of deprecated FeaturesRepository Co-Authored-By: alex@cal.com <me@alexvanandel.com> * refactor: remove user locking, keep only watchlist addition on signup review Co-Authored-By: alex@cal.com <me@alexvanandel.com> * feat: lock user on signup review, remove watchlist entry on unlock Co-Authored-By: alex@cal.com <me@alexvanandel.com> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
132 lines
5.4 KiB
TypeScript
132 lines
5.4 KiB
TypeScript
import type { MockResponse } from "@calcom/features/auth/signup/handlers/__tests__/mocks/next.mocks";
|
|
import {
|
|
prismaMock,
|
|
resetPrismaMock,
|
|
} from "@calcom/features/auth/signup/handlers/__tests__/mocks/prisma.mocks";
|
|
import type { SignupBody } from "@calcom/features/auth/signup/handlers/__tests__/mocks/signup.factories";
|
|
import {
|
|
createMockFoundToken,
|
|
createMockTeam,
|
|
} from "@calcom/features/auth/signup/handlers/__tests__/mocks/signup.factories";
|
|
import type { Mock } from "vitest";
|
|
import { vi } from "vitest";
|
|
|
|
const mockFindTokenByToken: Mock = vi.fn();
|
|
const mockValidateAndGetCorrectedUsernameForTeam: Mock = vi.fn();
|
|
|
|
type UsernameStatus = {
|
|
statusCode: 200 | 402 | 418;
|
|
requestedUserName: string;
|
|
json: { available: boolean; premium: boolean };
|
|
};
|
|
|
|
type InnerHandler = (body: Record<string, string>, status: UsernameStatus) => Promise<MockResponse>;
|
|
|
|
var mockCapturedHandler: InnerHandler | null;
|
|
|
|
vi.mock("next/server", async () => {
|
|
const { createNextServerMock } = await import(
|
|
"@calcom/features/auth/signup/handlers/__tests__/mocks/next.mocks"
|
|
);
|
|
return createNextServerMock();
|
|
});
|
|
vi.mock("next/headers", async () => {
|
|
const { createNextHeadersMock } = await import(
|
|
"@calcom/features/auth/signup/handlers/__tests__/mocks/next.mocks"
|
|
);
|
|
return createNextHeadersMock();
|
|
});
|
|
vi.mock("@calcom/prisma", async () => {
|
|
const { createPrismaMock } = await import(
|
|
"@calcom/features/auth/signup/handlers/__tests__/mocks/prisma.mocks"
|
|
);
|
|
return createPrismaMock();
|
|
});
|
|
vi.mock("@calcom/prisma/client", async () => {
|
|
const { createPrismaMock } = await import(
|
|
"@calcom/features/auth/signup/handlers/__tests__/mocks/prisma.mocks"
|
|
);
|
|
return createPrismaMock();
|
|
});
|
|
vi.mock("@calcom/lib/logger", () => ({
|
|
default: { getSubLogger: () => ({ warn: vi.fn(), error: vi.fn(), debug: vi.fn(), info: vi.fn() }) },
|
|
}));
|
|
vi.mock("@calcom/lib/auth/hashPassword", () => ({ hashPassword: vi.fn().mockResolvedValue("hashed") }));
|
|
vi.mock("@calcom/lib/constants", () => ({ WEBAPP_URL: "http://localhost:3000" }));
|
|
vi.mock("@calcom/lib/tracking", () => ({ getTrackingFromCookies: vi.fn().mockReturnValue({}) }));
|
|
vi.mock("@calcom/app-store/stripepayment/lib/utils", () => ({ getPremiumMonthlyPlanPriceId: vi.fn() }));
|
|
vi.mock("@calcom/features/auth/lib/getLocaleFromRequest", () => ({
|
|
getLocaleFromRequest: vi.fn().mockResolvedValue("en"),
|
|
}));
|
|
vi.mock("@calcom/features/auth/lib/verifyEmail", () => ({ sendEmailVerification: vi.fn() }));
|
|
vi.mock("@calcom/features/auth/signup/utils/createOrUpdateMemberships", () => ({
|
|
createOrUpdateMemberships: vi.fn(),
|
|
}));
|
|
vi.mock("@calcom/features/auth/signup/utils/prefillAvatar", () => ({ prefillAvatar: vi.fn() }));
|
|
vi.mock("@calcom/features/auth/signup/utils/validateUsername", () => ({
|
|
validateAndGetCorrectedUsernameAndEmail: vi.fn().mockResolvedValue({ isValid: true, username: "testuser" }),
|
|
}));
|
|
vi.mock("@calcom/features/ee/billing/di/containers/Billing", () => ({
|
|
getBillingProviderService: vi.fn().mockReturnValue({
|
|
createCustomer: vi.fn().mockResolvedValue({ stripeCustomerId: "cus_123" }),
|
|
}),
|
|
}));
|
|
vi.mock("@calcom/features/watchlist/lib/telemetry", () => ({ sentrySpan: {} }));
|
|
vi.mock("@calcom/features/watchlist/operations/check-if-email-in-watchlist.controller", () => ({
|
|
checkIfEmailIsBlockedInWatchlistController: vi.fn().mockResolvedValue(false),
|
|
}));
|
|
vi.mock("@calcom/features/di/containers/FeatureRepository", () => ({
|
|
getFeatureRepository: vi.fn().mockReturnValue({
|
|
checkIfFeatureIsEnabledGlobally: vi.fn().mockResolvedValue(false),
|
|
}),
|
|
}));
|
|
vi.mock("@calcom/features/watchlist/lib/repository/GlobalWatchlistRepository", () => {
|
|
return {
|
|
GlobalWatchlistRepository: class {
|
|
findBlockedEmail = vi.fn().mockResolvedValue(null);
|
|
createEntry = vi.fn().mockResolvedValue({});
|
|
},
|
|
};
|
|
});
|
|
vi.mock("@calcom/features/watchlist/lib/utils/normalization", () => ({
|
|
normalizeEmail: vi.fn((e: string) => e.toLowerCase()),
|
|
}));
|
|
vi.mock("@calcom/web/lib/buildLegacyCtx", () => ({ buildLegacyRequest: vi.fn() }));
|
|
vi.mock("@calcom/features/auth/signup/utils/organization", () => ({ joinAnyChildTeamOnOrgInvite: vi.fn() }));
|
|
vi.mock("@calcom/features/auth/signup/utils/token", () => ({
|
|
findTokenByToken: (...args: unknown[]) => mockFindTokenByToken(...args),
|
|
throwIfTokenExpired: vi.fn(),
|
|
validateAndGetCorrectedUsernameForTeam: (...args: unknown[]) =>
|
|
mockValidateAndGetCorrectedUsernameForTeam(...args),
|
|
}));
|
|
|
|
// Capture inner handler from usernameHandler wrapper
|
|
vi.mock("@calcom/lib/server/username", () => ({
|
|
usernameHandler: (handler: InnerHandler) => {
|
|
mockCapturedHandler = handler;
|
|
return handler;
|
|
},
|
|
}));
|
|
|
|
// Import after mocks
|
|
import "./calcomSignupHandler";
|
|
import { runP2002TestSuite } from "@calcom/features/auth/signup/handlers/__tests__/p2002.test-suite";
|
|
|
|
function callHandler(body: SignupBody): Promise<MockResponse> {
|
|
if (!mockCapturedHandler) throw new Error("Handler not captured");
|
|
return mockCapturedHandler(body as unknown as Record<string, string>, {
|
|
statusCode: 200,
|
|
requestedUserName: body.username || "testuser",
|
|
json: { available: true, premium: false },
|
|
});
|
|
}
|
|
|
|
runP2002TestSuite("calcomHandler", callHandler, () => {
|
|
vi.clearAllMocks();
|
|
resetPrismaMock();
|
|
mockFindTokenByToken.mockResolvedValue(createMockFoundToken());
|
|
mockValidateAndGetCorrectedUsernameForTeam.mockResolvedValue("testuser");
|
|
prismaMock.team.findUnique.mockResolvedValue(createMockTeam() as never);
|
|
prismaMock.verificationToken.delete.mockResolvedValue({} as never);
|
|
});
|