* fix: harden seed script org settings upsert and P2002 error handling Co-Authored-By: romitgabani1 <romitgabani1.work@gmail.com> * fix: remove PII from P2002 log and recover existing user instead of returning null - Replace username interpolation in log message with generic text (Cubic violation #2, confidence 9/10) - On P2002, fetch the existing user from DB and return it with membership data instead of returning null, which was dropping users from org setup on retries (Cubic violation #3, confidence 9/10) Co-Authored-By: bot_apk <apk@cognition.ai> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: bot_apk <apk@cognition.ai> Co-authored-by: Alex van Andel <me@alexvanandel.com>
93 lines
2.8 KiB
TypeScript
93 lines
2.8 KiB
TypeScript
import prisma from "@calcom/prisma";
|
|
import type { Request, Response } from "express";
|
|
import type { NextApiRequest, NextApiResponse } from "next";
|
|
import { createMocks } from "node-mocks-http";
|
|
import { describe, expect, it } from "vitest";
|
|
import { isAdminGuard } from "../../../lib/utils/isAdmin";
|
|
import { ScopeOfAdmin } from "../../../lib/utils/scopeOfAdmin";
|
|
|
|
type CustomNextApiRequest = NextApiRequest & Request;
|
|
type CustomNextApiResponse = NextApiResponse & Response;
|
|
|
|
describe("isAdmin guard", () => {
|
|
it("Returns false when user does not exist in the system", async () => {
|
|
const { req } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
|
method: "POST",
|
|
body: {},
|
|
});
|
|
|
|
req.userId = 0;
|
|
req.user = undefined;
|
|
|
|
const { isAdmin, scope } = await isAdminGuard(req);
|
|
|
|
expect(isAdmin).toBe(false);
|
|
expect(scope).toBe(null);
|
|
});
|
|
|
|
it("Returns false when org user is a member", async () => {
|
|
const { req } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
|
method: "POST",
|
|
body: {},
|
|
});
|
|
|
|
const memberUser = await prisma.user.findFirstOrThrow({ where: { email: "member2-acme@example.com" } });
|
|
|
|
req.userId = memberUser.id;
|
|
req.user = memberUser;
|
|
|
|
const { isAdmin, scope } = await isAdminGuard(req);
|
|
|
|
expect(isAdmin).toBe(false);
|
|
expect(scope).toBe(null);
|
|
});
|
|
|
|
it("Returns system-wide admin when user is marked as such", async () => {
|
|
const { req } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
|
method: "POST",
|
|
body: {},
|
|
});
|
|
|
|
const adminUser = await prisma.user.findFirstOrThrow({ where: { email: "admin@example.com" } });
|
|
|
|
req.userId = adminUser.id;
|
|
req.user = adminUser;
|
|
|
|
const { isAdmin, scope } = await isAdminGuard(req);
|
|
|
|
expect(isAdmin).toBe(true);
|
|
expect(scope).toBe(ScopeOfAdmin.SystemWide);
|
|
});
|
|
|
|
it("Returns org-wide admin when user is set as such & admin API access is granted", async () => {
|
|
const { req } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
|
method: "POST",
|
|
body: {},
|
|
});
|
|
|
|
const adminUser = await prisma.user.findFirstOrThrow({ where: { email: "owner1-acme@example.com" } });
|
|
|
|
req.userId = adminUser.id;
|
|
req.user = adminUser;
|
|
|
|
const { isAdmin, scope } = await isAdminGuard(req);
|
|
expect(isAdmin).toBe(true);
|
|
expect(scope).toBe(ScopeOfAdmin.OrgOwnerOrAdmin);
|
|
});
|
|
|
|
it("Returns no admin when user is set as org admin but admin API access is revoked", async () => {
|
|
const { req } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
|
|
method: "POST",
|
|
body: {},
|
|
});
|
|
|
|
const adminUser = await prisma.user.findFirstOrThrow({ where: { email: "owner1-dunder@example.com" } });
|
|
|
|
req.userId = adminUser.id;
|
|
req.user = adminUser;
|
|
|
|
const { isAdmin } = await isAdminGuard(req);
|
|
expect(isAdmin).toBe(false);
|
|
});
|
|
});
|