Files
calendar/apps/api/v1/test/lib/bookings/_get.test.ts
T
Benny JooGitHubDevin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
f5d345b133 refactor: remove @calcom/web imports from @calcom/features and add @calcom/testing package (#26480)
* fix: remove @calcom/web imports from packages/features to eliminate circular dependency

- Migrate UserTableUser and MemberPermissions types to packages/features/users/types/user-table.ts
- Migrate useGeo hook to packages/features/geo/GeoContext.tsx
- Migrate buildLegacyRequest to packages/lib/buildLegacyCtx.ts
- Migrate Calendar component to packages/features/calendars/weeklyview/components/
- Move test utilities (bookingScenario, fixtures) to packages/features/test/
- Update all imports in packages/features to use new locations
- Add re-exports in apps/web for backward compatibility

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: delete original implementation files and fix type issues

- Delete original calendar component files in apps/web (keep only re-export stubs)
- Migrate OutOfOfficeInSlots to packages/features/bookings/components
- Convert apps/web OutOfOfficeInSlots to re-export stub
- Fix className vs class issue in Calendar.tsx
- Fix @calcom/trpc import violation in user-table.ts by using structural type

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: add missing isGroup and contains fields to UserTableUser attributes type

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: update customRole type to match actual Prisma Role model

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix build

* fix

* fix

* cleanup weeklyview

* fix

* refactor to mv MemberPermissions to types package

* add types dependency to features

* fix

* fix

* fix

* fix

* fix

* fix

* rename

* rename

* migrate

* migrate

* migrate

* fix

* fix

* fix

* refactor: move test utilities from packages/features/test to tests/libs

- Move bookingScenario utilities to tests/libs/bookingScenario
- Move fixtures to tests/libs/fixtures
- Update all imports in packages/features test files to use new location
- Update all imports in apps/web test files to use new location
- Eliminates duplication of test utilities between packages/features and apps/web

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: correct relative import paths for tests/libs in test files

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* refactor: replace test utility implementations with re-exports to tests/libs

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: fix test import paths and move signup handler tests to apps/web

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: move buildLegacyCtx to packages/lib and restore handlers to packages/features

- Move buildLegacyCtx from apps/web/lib to packages/lib to break circular dependency
- Update apps/web/lib/buildLegacyCtx.ts to re-export from @calcom/lib
- Restore signup handlers and tests to packages/features/auth/signup/handlers
- Update handler imports to use @calcom/lib/buildLegacyCtx instead of @calcom/web/lib/buildLegacyCtx

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: update recurring-event.test.ts imports to use tests/libs path

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* refactor: delete test re-export files and update imports to use tests/libs directly

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: update remaining test imports to use tests/libs directly

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: update handleRecurringEventBooking calls to match function signature (1 arg)

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* remove

* migrate tests

* migrate tests

* refactor: update test mock imports by removing  and using async  for mock creators.

* fix type errors

* fix: add type assertion for MockUser in p2002.test-suite.ts

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: restore locale import in compareReminderBodyToTemplate.test.ts using relative path

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* feat: create @calcom/testing package and migrate tests from /tests directory

- Created new @calcom/testing package in /packages/testing
- Moved all files from /tests to /packages/testing
- Updated all imports across the codebase to use @calcom/testing alias
- Removed /tests directory at root level

This allows other packages like @calcom/features and @calcom/web to import
testing utilities using the @calcom/testing alias instead of relative paths.

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix

* fix

* fix: add missing useBookings export to @calcom/atoms package

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: add missing useCalendarsBusyTimes and useConnectedCalendars exports to @calcom/atoms

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* chore: add @calcom/testing as explicit devDependency to packages that use it

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* refactor: move setupVitest.ts into @calcom/testing package

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix

* chore: add biome rules to restrict @calcom/testing imports

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix

* rename libs to lib

* rename libs to lib

* add rule

* add rule

* refactor: remove @calcom/features imports from @calcom/testing

- Move mockPaymentSuccessWebhookFromStripe to fresh-booking.test.ts
- Replace ProfileRepository.generateProfileUid() with uuidv4()
- Clone Tracking type into @calcom/testing/src/lib/types.ts
- Update imports in expects.ts and getMockRequestDataForBooking.ts
- Move source files into src/ folder
- Move CalendarManager mock to @calcom/features

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: add explicit exports for nested paths in @calcom/testing

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* improve

* improve

* fix

* fix

* fix type checks

* fix type checks

* fix type checks

* fix tests

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2026-01-08 16:59:11 +09:00

364 lines
9.5 KiB
TypeScript

import prismaMock from "@calcom/testing/lib/__mocks__/prismaMock";
import type { Request, Response } from "express";
import type { NextApiRequest, NextApiResponse } from "next";
import { createMocks } from "node-mocks-http";
import { describe, expect, test, vi, afterEach, beforeEach } from "vitest";
import { ZodError } from "zod";
import { buildBooking } from "@calcom/lib/test/builder";
import {
getAccessibleUsers,
retrieveOrgScopedAccessibleUsers,
} from "~/lib/utils/retrieveScopedAccessibleUsers";
import { handler } from "../../../pages/api/bookings/_get";
vi.mock("~/lib/utils/retrieveScopedAccessibleUsers", () => ({
getAccessibleUsers: vi.fn(),
retrieveOrgScopedAccessibleUsers: vi.fn(),
}));
type CustomNextApiRequest = NextApiRequest & Request;
type CustomNextApiResponse = NextApiResponse & Response;
const userId = 1;
beforeEach(() => {
prismaMock.user.findUnique.mockResolvedValue({
id: userId,
email: "test@example.com",
name: "Test User",
} as any);
(getAccessibleUsers as any).mockResolvedValue([userId]);
(retrieveOrgScopedAccessibleUsers as any).mockResolvedValue([userId]);
prismaMock.membership.findMany.mockResolvedValue([
{
// @ts-expect-error Will be fixed by Prisma 6.7.0 upgrade mock changes - which uses vitest-mock-extended
team: {
id: 1,
isOrganization: true,
},
},
]);
prismaMock.user.findMany.mockResolvedValue([
{
id: userId,
email: "test@example.com",
},
] as any);
});
afterEach(() => {
vi.resetAllMocks();
});
describe("GET /api/bookings", () => {
describe("Query parameter validation", () => {
test("should validate status parameter correctly", async () => {
const { req } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
method: "GET",
query: {
status: "invalid_status",
},
pagination: {
take: 10,
skip: 0,
},
});
req.userId = userId;
await expect(handler(req)).rejects.toThrow(ZodError);
});
test("should accept valid status parameter", async () => {
prismaMock.booking.findMany.mockResolvedValue([]);
prismaMock.booking.count.mockResolvedValue(0);
const { req } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
method: "GET",
query: {
status: "upcoming",
},
pagination: {
take: 10,
skip: 0,
},
});
req.userId = userId;
const result = await handler(req);
expect(result.bookings).toEqual([]);
});
test("should validate dateFrom parameter format", async () => {
const { req } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
method: "GET",
query: {
dateFrom: "invalid-date",
},
pagination: {
take: 10,
skip: 0,
},
});
req.userId = userId;
await expect(handler(req)).rejects.toThrow();
});
test("should validate dateTo parameter format", async () => {
const { req } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
method: "GET",
query: {
dateTo: "invalid-date",
},
pagination: {
take: 10,
skip: 0,
},
});
req.userId = userId;
await expect(handler(req)).rejects.toThrow();
});
test("should validate sortBy parameter", async () => {
const { req } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
method: "GET",
query: {
sortBy: "invalid_field",
},
pagination: {
take: 10,
skip: 0,
},
});
req.userId = userId;
await expect(handler(req)).rejects.toThrow();
});
test("should validate order parameter", async () => {
const { req } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
method: "GET",
query: {
order: "invalid_order",
},
pagination: {
take: 10,
skip: 0,
},
});
req.userId = userId;
await expect(handler(req)).rejects.toThrow();
});
});
describe("Permission logic", () => {
test("should only return user's own bookings for regular user", async () => {
const mockBookings = [buildBooking({ id: 1, userId: userId }), buildBooking({ id: 2, userId: userId })];
prismaMock.booking.findMany.mockResolvedValue(mockBookings);
prismaMock.booking.count.mockResolvedValue(2);
const { req } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
method: "GET",
pagination: {
take: 10,
skip: 0,
},
});
req.userId = userId;
const result = await handler(req);
expect(result.bookings).toHaveLength(2);
expect(result.bookings.every((b) => b.userId === userId)).toBe(true);
});
test("should allow system-wide admin to access all bookings", async () => {
const adminUserId = 999;
const mockBookings = [
buildBooking({ id: 1, userId: 1 }),
buildBooking({ id: 2, userId: 2 }),
buildBooking({ id: 3, userId: 3 }),
];
prismaMock.booking.findMany.mockResolvedValue(mockBookings);
prismaMock.booking.count.mockResolvedValue(3);
const { req } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
method: "GET",
pagination: {
take: 10,
skip: 0,
},
});
req.userId = adminUserId;
req.isSystemWideAdmin = true;
const result = await handler(req);
expect(result.bookings).toHaveLength(3);
});
test("should allow org admin to access org bookings", async () => {
const orgAdminUserId = 999;
const mockBookings = [buildBooking({ id: 1, userId: 1 }), buildBooking({ id: 2, userId: 2 })];
prismaMock.booking.findMany.mockResolvedValue(mockBookings);
prismaMock.booking.count.mockResolvedValue(2);
(retrieveOrgScopedAccessibleUsers as any).mockResolvedValue([1, 2]);
const { req } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
method: "GET",
pagination: {
take: 10,
skip: 0,
},
});
req.userId = orgAdminUserId;
req.isOrganizationOwnerOrAdmin = true;
const result = await handler(req);
expect(result.bookings).toHaveLength(2);
});
});
describe("Filtering edge cases", () => {
test("should handle empty attendeeEmail array", async () => {
prismaMock.booking.findMany.mockResolvedValue([]);
prismaMock.booking.count.mockResolvedValue(0);
const { req } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
method: "GET",
query: {
attendeeEmail: [],
},
pagination: {
take: 10,
skip: 0,
},
});
req.userId = userId;
const result = await handler(req);
expect(result.bookings).toEqual([]);
});
test("should handle single attendeeEmail string", async () => {
prismaMock.booking.findMany.mockResolvedValue([]);
prismaMock.booking.count.mockResolvedValue(0);
const { req } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
method: "GET",
query: {
attendeeEmail: "test@example.com",
},
pagination: {
take: 10,
skip: 0,
},
});
req.userId = userId;
const result = await handler(req);
expect(result.bookings).toEqual([]);
});
test("should handle pagination edge cases", async () => {
prismaMock.booking.findMany.mockResolvedValue([]);
prismaMock.booking.count.mockResolvedValue(0);
const { req } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
method: "GET",
pagination: {
take: 0,
skip: 0,
},
});
req.userId = userId;
const result = await handler(req);
expect(result.bookings).toEqual([]);
});
test("should handle large skip values", async () => {
prismaMock.booking.findMany.mockResolvedValue([]);
prismaMock.booking.count.mockResolvedValue(5);
const { req } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
method: "GET",
pagination: {
take: 10,
skip: 1000,
},
});
req.userId = userId;
const result = await handler(req);
expect(result.bookings).toEqual([]);
});
});
describe("Expand parameter functionality", () => {
test("should handle invalid expand parameter", async () => {
prismaMock.booking.findMany.mockResolvedValue([]);
prismaMock.booking.count.mockResolvedValue(0);
const { req } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
method: "GET",
query: {
expand: "invalid_field",
},
pagination: {
take: 10,
skip: 0,
},
});
req.userId = userId;
await expect(handler(req)).rejects.toThrow();
});
test("should handle valid expand parameter", async () => {
prismaMock.booking.findMany.mockResolvedValue([]);
prismaMock.booking.count.mockResolvedValue(0);
const { req } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({
method: "GET",
query: {
expand: "team",
},
pagination: {
take: 10,
skip: 0,
},
});
req.userId = userId;
const result = await handler(req);
expect(result.bookings).toEqual([]);
});
});
});