4e5d4f67d5
* fix: resolve flaky org-admin integration tests - Fixed isAdminGuard Prisma query to use explicit 'is' filter for organizationSettings - Fixed async describe with top-level awaits in _get.integration-test.ts - Added global setup in setupVitest.ts to prevent race conditions - Removed duplicate setup logic from individual test files Root cause: Tests were running in parallel with independent beforeAll setups, causing race conditions where organizationSettings weren't created before tests executed. The async describe with top-level awaits made this worse by executing queries before beforeAll hooks ran. Co-Authored-By: anik@cal.com <adhabal2002@gmail.com> * fix: move org-admin setup to integration-only setup file The global setup in setupVitest.ts was running for ALL test workspaces (including unit tests), causing ECONNREFUSED errors because unit tests don't have database access. Changes: - Created setupVitest.integration.ts with org-admin seeding logic - Removed database seeding from setupVitest.ts - Updated vitest.workspace.ts to use integration-only setup file - Added DATABASE_URL guard to prevent errors when DB is unavailable This fixes the unit test failures while preserving the fix for flaky integration tests. Co-Authored-By: anik@cal.com <adhabal2002@gmail.com> * fix: use globalSetup instead of setupFiles for org-admin seeding The previous fix using setupFiles didn't work because setupFiles run AFTER test modules are evaluated. This meant any top-level Prisma queries in test files would execute before the org-admin seeding. Changes: - Moved org-admin seeding to tests/integration/global-setup.ts - Updated vitest.workspace.ts to use globalSetup for IntegrationTests - globalSetup runs BEFORE any test modules are loaded, ensuring org settings exist before tests execute - Added teardown function to properly disconnect Prisma after tests This ensures org-admin state is seeded once before all integration tests run, eliminating the race condition and ensuring tests have the correct database state. Co-Authored-By: anik@cal.com <adhabal2002@gmail.com> * debug: add logging to globalSetup to diagnose why tests are failing Added console.log statements throughout the globalSetup to verify: - Whether the globalSetup is running at all - Whether DATABASE_URL is available - Whether the org teams are found in the database - Whether the upserts are executing successfully This will help diagnose why the integration tests are still failing with org-admin not being detected. Co-Authored-By: anik@cal.com <adhabal2002@gmail.com> * fix: use absolute path for globalSetup in vitest.workspace.ts Changed from relative path 'tests/integration/global-setup.ts' to absolute path using new URL().pathname to ensure Vitest can properly locate and load the globalSetup file. This should fix the issue where the globalSetup wasn't being executed at all (no logs appearing in CI). Co-Authored-By: anik@cal.com <adhabal2002@gmail.com> * fix: add serial execution to IntegrationTests workspace Added sequence.concurrent: false to IntegrationTests workspace to eliminate inter-file race conditions while stabilizing org-admin seeding. This ensures tests run one at a time, preventing parallel execution issues that could cause flaky test failures. This is a temporary stabilizer that can be reverted once the globalSetup seeding is confirmed working. Co-Authored-By: anik@cal.com <adhabal2002@gmail.com> * refactor: use TeamRepository in globalSetup to follow architectural rule Refactored globalSetup to use TeamRepository instead of direct Prisma access, following the 'No prisma outside of repositories' architectural rule. Changes: - Created TeamRepository class with methods for finding organizations and upserting organization settings - Updated globalSetup to use TeamRepository.withGlobalPrisma() - Removed direct Prisma imports from globalSetup This ensures proper separation of concerns and follows the repository pattern established in the codebase. Co-Authored-By: anik@cal.com <adhabal2002@gmail.com> * fix: use relative path import for TeamRepository in globalSetup Changed from package-scoped import '@calcom/lib/server/repository/team' to relative path import '../../packages/lib/server/repository/team' to fix module resolution issue. Added try/catch with logging around the import to surface any remaining resolution issues in CI logs. This should allow the globalSetup to execute properly and seed org-admin state before tests run. Co-Authored-By: anik@cal.com <adhabal2002@gmail.com> * debug: add membership logging to globalSetup to diagnose test failures Co-Authored-By: anik@cal.com <adhabal2002@gmail.com> * fix: ensure owner1-acme membership exists in globalSetup Root cause: CI database snapshot doesn't include the owner1-acme OWNER membership that exists in the current seed file, because cache-db action's cache key doesn't include scripts/seed.ts. Solution: Add ensureMembership method to TeamRepository and call it in globalSetup to ensure the owner1-acme user has an accepted OWNER membership in the Acme org before tests run. This fixes the 5 failing org-admin integration tests that depend on this membership. Co-Authored-By: anik@cal.com <adhabal2002@gmail.com> * fix: ensure all 10 member{0-9}-acme users exist in globalSetup Add ensureUser method to TeamRepository to create users if they don't exist. Update ensureMembership to accept MEMBER role in addition to OWNER and ADMIN. Ensure all 10 member{0-9}-acme users are created with MEMBER role and accepted: true in the Acme org. This should fix the remaining 4 failing tests that expect multiple org members to exist. Co-Authored-By: anik@cal.com <adhabal2002@gmail.com> * fix: use upsert instead of create in ensureUser to avoid unique constraint violations The ensureUser method was using create which could fail if a user with that email already exists. Switch to upsert to make the operation idempotent and avoid P2002 unique constraint errors. Co-Authored-By: anik@cal.com <adhabal2002@gmail.com> * refactor: clean up debug code and move test repository to proper location - Remove all console.log debug statements from global-setup.ts - Remove serial execution from IntegrationTests workspace (restore parallel execution) - Move TeamRepository to tests/lib/test-team-repository.ts and rename to TestTeamRepository - Keep all actual fixes: isAdmin Prisma query fix, ensureUser/ensureMembership methods, globalSetup seeding Co-Authored-By: anik@cal.com <adhabal2002@gmail.com> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>