613e9f0788
* fix: invalidate old password reset tokens when new one is requested Security fix: Previously, old password reset tokens remained valid even after requesting a new one, creating a potential account takeover vulnerability. This change ensures that when a user requests a new password reset link, all previous valid tokens for that email are immediately invalidated. Changes: - Expire all existing valid tokens before creating new one - Add E2E test to verify old tokens are invalidated - Prevent potential account takeover scenario Co-Authored-By: anik@cal.com <adhabal2002@gmail.com> * Clean up code by removing blank line Removed unnecessary blank line in forgot-password.e2e.ts. * test: fix strict mode violation in password reset test Use getByRole to specifically target the heading element instead of text locator which was matching both the heading and button. Co-Authored-By: anik@cal.com <adhabal2002@gmail.com> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
65 lines
1.8 KiB
TypeScript
65 lines
1.8 KiB
TypeScript
import dayjs from "@calcom/dayjs";
|
|
import { getTranslation } from "@calcom/lib/server/i18n";
|
|
import prisma from "@calcom/prisma";
|
|
import type { User } from "@calcom/prisma/client";
|
|
|
|
export const PASSWORD_RESET_EXPIRY_HOURS = 6;
|
|
|
|
const RECENT_MAX_ATTEMPTS = 3;
|
|
const RECENT_PERIOD_IN_MINUTES = 5;
|
|
|
|
const createPasswordReset = async (email: string): Promise<string> => {
|
|
const expiry = dayjs().add(PASSWORD_RESET_EXPIRY_HOURS, "hours").toDate();
|
|
|
|
await prisma.resetPasswordRequest.updateMany({
|
|
where: {
|
|
email,
|
|
expires: {
|
|
gt: new Date(),
|
|
},
|
|
},
|
|
data: {
|
|
expires: new Date(),
|
|
},
|
|
});
|
|
|
|
const createdResetPasswordRequest = await prisma.resetPasswordRequest.create({
|
|
data: {
|
|
email,
|
|
expires: expiry,
|
|
},
|
|
});
|
|
|
|
return `${process.env.NEXT_PUBLIC_WEBAPP_URL}/auth/forgot-password/${createdResetPasswordRequest.id}`;
|
|
};
|
|
|
|
const guardAgainstTooManyPasswordResets = async (email: string) => {
|
|
const recentPasswordRequestsCount = await prisma.resetPasswordRequest.count({
|
|
where: {
|
|
email,
|
|
createdAt: {
|
|
gt: dayjs().subtract(RECENT_PERIOD_IN_MINUTES, "minutes").toDate(),
|
|
},
|
|
},
|
|
});
|
|
if (recentPasswordRequestsCount >= RECENT_MAX_ATTEMPTS) {
|
|
throw new Error("Too many password reset attempts. Please try again later.");
|
|
}
|
|
};
|
|
const passwordResetRequest = async (user: Pick<User, "email" | "name" | "locale">) => {
|
|
const { email } = user;
|
|
const t = await getTranslation(user.locale ?? "en", "common");
|
|
await guardAgainstTooManyPasswordResets(email);
|
|
const resetLink = await createPasswordReset(email);
|
|
const { sendPasswordResetEmail } = await import("@calcom/emails");
|
|
|
|
// send email in user language
|
|
await sendPasswordResetEmail({
|
|
language: t,
|
|
user,
|
|
resetLink,
|
|
});
|
|
};
|
|
|
|
export { passwordResetRequest };
|