Files
calendar/packages/features/ee/dsync/lib/handleUserEvents.test.ts
T
Volnei MunhozGitHubDevin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
bbf9274d37 chore: upgrade Vitest to 4.0.16 and Vite to 6.4.1 (#26351)
* chore: upgrade Vitest to 4.0.16 and Vite to 6.4.1

- Update vitest from 2.1.9 to 4.0.16
- Update @vitest/ui from 2.1.9 to 4.0.16
- Update vitest-fetch-mock from 0.3.0 to 0.4.5
- Update vitest-mock-extended from 2.0.2 to 3.1.0
- Update vite from 4.5.14/5.4.21 to 6.4.1 across all packages
- Update @vitejs/plugin-react to 5.1.2
- Update @vitejs/plugin-react-swc to 4.2.2
- Update @vitejs/plugin-basic-ssl to 2.1.0
- Update vite-plugin-dts to 4.5.4
- Rename vitest.config.ts to vitest.config.mts for ESM compatibility
- Add globals: true to vitest config

Co-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>

* fix: address Vitest 4.0 and Vite 6 breaking changes

- Convert arrow function mockImplementation patterns to regular functions
  (Vitest 4.0 breaking change: arrow functions can't be constructor mocks)
- Fix CSS imports with ?inline suffix for Vite 6 compatibility
- Add biome override to disable useArrowFunction rule for test files
- Fix syntax errors in test files introduced by regex replacements

Co-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>

* fix: fix remaining Vitest 4.0 constructor mock patterns

Co-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>

* fix: fix more Vitest 4.0 constructor mock patterns and exclude API v2 spec files

Co-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>

* fix: convert more arrow function mocks to regular functions for Vitest 4.0

Co-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>

* fix: convert more arrow function mocks to regular functions for Vitest 4.0

- Fix CrmService.integration.test.ts jsforce.Connection mock
- Fix RetellSDKClient.test.ts Retell mock
- Fix RetellAIService.test.ts CreditService mocks
- Fix GoogleCalendarSubscriptionAdapter.test.ts CalendarAuth mock

Co-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>

* fix: convert Google Calendar and OAuthManager arrow function mocks for Vitest 4.0

- Fix googleapis.ts Calendar, OAuth2Client, and JWT mocks
- Fix utils.ts JWT mock
- Fix OAuthManager.ts defaultMockOAuthManager mock

Co-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>

* fix: add React plugin, jsdom environment, and fix more constructor mocks for Vitest 4.0

Co-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>

* fix: convert HostRepository PrismaClient mock to regular function for Vitest 4.0

Co-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>

* fix: add useOrgBranding mock to React component tests for Vitest 4.0

Co-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>

* fix: update TestFunction type for Vitest 4.0 compatibility

Co-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>

* fix: convert listBookingReports constructor mocks to regular functions for Vitest 4.0

Co-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>

* fix: convert UserRepository constructor mock to regular function for Vitest 4.0

Co-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>

* fix: convert OrganizationPaymentService constructor mock to regular function for Vitest 4.0

Co-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>

* fix: convert more constructor mocks to regular functions for Vitest 4.0

Co-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>

* fix: add apps/web path aliases to vitest config

Co-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>

* fix: fix test issues for Vitest 4.0 compatibility

- Fix Response constructor 204 status code issue in testUtils.ts
- Fix FeaturesRepository mock persistence in handleNotificationWhenNoSlots.test.ts
- Add @vitest-environment node directive to formSubmissionUtils.test.ts
- Fix document.querySelector mock in embed.test.ts

Co-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>

* fix: clear EventManager spy between tests for Vitest 4.0 compatibility

Co-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>

* fix: update TeamRepository mock pattern for Vitest 4.0 compatibility

Co-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>

* fix: convert RoutingFormResponseRepository mock to regular function for Vitest 4.0

Co-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>

* fix: convert more constructor mocks to regular functions for Vitest 4.0

Co-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>

* fix: fix mock reset and spy clear issues for Vitest 4.0

Co-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>

* fix: fix remaining test failures for Vitest 4.0 upgrade

- Fix booking-validations.test.ts: convert UserRepository mock to regular function
- Fix route.test.ts: update 500 error test to mock ImageResponse instead of fetch
- Fix users-public-view.test.tsx: add missing mocks for getOrgFullOrigin and useRouterQuery
- Add @calcom/web path alias to vitest config

Co-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>

* fix: add vitest-mocks for generated files that don't exist in CI

- Add svg-hashes.json mock for route.test.ts
- Add tailwind.generated.css mock for embed.test.ts
- Update vitest config to use mock files

Co-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>

* fix: update vitest config aliases for CI compatibility

- Use array format for aliases to ensure proper ordering
- Add @calcom/platform-constants alias to resolve from source
- Add @calcom/embed-react alias to resolve from source
- Ensure svg-hashes.json mock alias is matched before @calcom/web

Co-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>

* fix: add @calcom/embed-snippet alias for CI compatibility

Co-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>

* Fix wrong test

* fix: migrate from CLI flags to VITEST_MODE env var for Vitest 4.0

Vitest 4.0 no longer allows custom CLI flags like --packaged-embed-tests-only.
This change migrates to using VITEST_MODE environment variable instead:
- VITEST_MODE=packaged-embed for packaged embed tests
- VITEST_MODE=integration for integration tests
- VITEST_MODE=timezone for timezone-dependent tests

Updated vitest.config.mts to handle mode-based include/exclude patterns.
Updated CI workflows and package scripts to use the new env var approach.

Co-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>

* fix: return default include pattern instead of undefined in vitest config

The getTestInclude() function was returning undefined for the default case,
but Vitest 4.0 expects an array. This caused 'resolved.include is not iterable'
error in CI.

Co-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>

* fix: always set INTEGRATION_TEST_MODE for jsdom environment

The getBookingFields.ts file checks for INTEGRATION_TEST_MODE to allow
server-side imports in the jsdom environment. Without this, tests fail
with 'getBookingFields must not be imported on the client side' error.

Co-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>

* fix: support legacy CLI flags for backwards compatibility with main workflow

The CI runs workflows from main branch, which uses the old CLI flag approach
(yarn test -- --integrationTestsOnly). This commit adds backwards compatibility
by checking both VITEST_MODE env var and process.argv for the legacy flags.

Co-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2026-01-01 18:16:10 -03:00

431 lines
12 KiB
TypeScript

import prismock from "../../../../../tests/libs/__mocks__/prisma";
import type { DirectorySyncEvent } from "@boxyhq/saml-jackson";
import { describe, expect, it, vi, beforeEach } from "vitest";
import { IdentityProvider, MembershipRole } from "@calcom/prisma/enums";
import handleUserEvents from "./handleUserEvents";
vi.mock("@calcom/lib/logger", () => ({
default: {
getSubLogger: () => ({
debug: vi.fn(),
error: vi.fn(),
warn: vi.fn(),
}),
},
}));
vi.mock("@calcom/lib/server/i18n", () => ({
getTranslation: vi.fn().mockResolvedValue((key: string) => key),
}));
vi.mock("@calcom/trpc/server/routers/viewer/teams/inviteMember/utils", () => ({
getTeamOrThrow: vi.fn(),
sendExistingUserTeamInviteEmails: vi.fn(),
sendSignupToOrganizationEmail: vi.fn(),
}));
vi.mock("./assignValueToUser", () => ({
assignValueToUserInOrgBulk: vi.fn(),
}));
vi.mock("./users/createUsersAndConnectToOrg", () => ({
default: vi.fn(),
}));
vi.mock("./users/inviteExistingUserToOrg", () => ({
default: vi.fn().mockResolvedValue({
id: 1,
username: "testuser",
email: "test@example.com",
}),
}));
vi.mock("./removeUserFromOrg", () => ({
default: vi.fn(),
}));
vi.mock("@calcom/features/users/repositories/UserRepository", () => ({
UserRepository: vi.fn().mockImplementation(function() { return {
isAMemberOfOrganization: vi.fn().mockResolvedValue(false),
}; }),
}));
async function createMockOrganization({ id, name, slug }: { id: number; name: string; slug: string }) {
return prismock.team.create({
data: {
id,
name,
slug,
isOrganization: true,
},
});
}
async function createMockUser({ email, organizationId }: { email: string; organizationId: number | null }) {
return prismock.user.create({
data: {
email,
username: email.split("@")[0],
organizationId,
completedOnboarding: true,
identityProvider: IdentityProvider.CAL,
locale: "en",
},
});
}
async function createMockMembership({
userId,
teamId,
role = MembershipRole.MEMBER,
}: {
userId: number;
teamId: number;
role?: MembershipRole;
}) {
return prismock.membership.create({
data: {
userId,
teamId,
role,
accepted: true,
disableImpersonation: false,
},
});
}
describe("handleUserEvents", () => {
const directoryId = "test-directory-id";
const organizationId = 1001;
const organizationName = "Test Organization";
const organizationSlug = "test-org";
beforeEach(async () => {
vi.clearAllMocks();
await createMockOrganization({
id: organizationId,
name: organizationName,
slug: organizationSlug,
});
const { getTeamOrThrow } = await import("@calcom/trpc/server/routers/viewer/teams/inviteMember/utils");
vi.mocked(getTeamOrThrow).mockResolvedValue({
id: organizationId,
name: organizationName,
slug: organizationSlug,
isOrganization: true,
parent: null,
parentId: null,
metadata: null,
} as Awaited<ReturnType<typeof getTeamOrThrow>>);
});
describe("Cross-tenant hijack prevention", () => {
it("should throw an error when user belongs to a different organization", async () => {
const userEmail = "user@example.com";
const differentOrgId = 2002;
await createMockOrganization({
id: differentOrgId,
name: "Different Organization",
slug: "different-org",
});
await createMockUser({
email: userEmail,
organizationId: 9999,
});
const event: DirectorySyncEvent = {
event: "user.created",
tenant: "test-tenant",
directory_id: directoryId,
data: {
id: "user-123",
email: userEmail,
first_name: "Test",
last_name: "User",
active: true,
raw: {
schemas: [],
},
},
};
await expect(handleUserEvents(event, organizationId)).rejects.toThrow(
"User belongs to another organization."
);
});
it("should succeed when user belongs to the correct organization", async () => {
const userEmail = "user@example.com";
const user = await createMockUser({
email: userEmail,
organizationId: organizationId,
});
await createMockMembership({
userId: user.id,
teamId: organizationId,
});
const event: DirectorySyncEvent = {
event: "user.created",
tenant: "test-tenant",
directory_id: directoryId,
data: {
id: "user-123",
email: userEmail,
first_name: "Test",
last_name: "User",
active: true,
raw: {
schemas: [],
},
},
};
const { UserRepository } = await import("@calcom/features/users/repositories/UserRepository");
vi.mocked(UserRepository).mockImplementation(function () {
return {
isAMemberOfOrganization: vi.fn().mockResolvedValue(true),
} as unknown as InstanceType<typeof UserRepository>;
});
await expect(handleUserEvents(event, organizationId)).resolves.not.toThrow();
});
it("should pass when user has no organizationId (allow existing user to be added to an org)", async () => {
const userEmail = "legacy@example.com";
await createMockUser({
email: userEmail,
organizationId: null,
});
const event: DirectorySyncEvent = {
event: "user.created",
tenant: "test-tenant",
directory_id: directoryId,
data: {
id: "user-123",
email: userEmail,
first_name: "Legacy",
last_name: "User",
active: true,
raw: {
schemas: [],
},
},
};
await expect(handleUserEvents(event, organizationId)).resolves.toBeUndefined();
});
it("should succeed when user does not exist yet (new user creation)", async () => {
const userEmail = "newuser@example.com";
const event: DirectorySyncEvent = {
event: "user.created",
tenant: "test-tenant",
directory_id: directoryId,
data: {
id: "user-123",
email: userEmail,
first_name: "New",
last_name: "User",
active: true,
raw: {
schemas: [],
},
},
};
const createUsersAndConnectToOrg = (await import("./users/createUsersAndConnectToOrg")).default;
vi.mocked(createUsersAndConnectToOrg).mockResolvedValue(undefined);
await expect(handleUserEvents(event, organizationId)).resolves.not.toThrow();
expect(createUsersAndConnectToOrg).toHaveBeenCalledWith({
createUsersAndConnectToOrgProps: {
emailsToCreate: [userEmail],
identityProvider: IdentityProvider.CAL,
identityProviderId: null,
},
org: expect.objectContaining({
id: organizationId,
name: organizationName,
}),
});
});
});
describe("User activation and deactivation", () => {
it("should invite existing user when active is true and user is not a member", async () => {
const userEmail = "user@example.com";
await createMockUser({
email: userEmail,
organizationId: organizationId,
});
const event: DirectorySyncEvent = {
event: "user.updated",
tenant: "test-tenant",
directory_id: directoryId,
data: {
id: "user-123",
email: userEmail,
first_name: "Test",
last_name: "User",
active: true,
raw: {
schemas: [],
},
},
};
const { UserRepository } = await import("@calcom/features/users/repositories/UserRepository");
vi.mocked(UserRepository).mockImplementation(function () {
return {
isAMemberOfOrganization: vi.fn().mockResolvedValue(false),
} as unknown as InstanceType<typeof UserRepository>;
});
const inviteExistingUserToOrg = (await import("./users/inviteExistingUserToOrg")).default;
const sendExistingUserTeamInviteEmails = (
await import("@calcom/trpc/server/routers/viewer/teams/inviteMember/utils")
).sendExistingUserTeamInviteEmails;
await handleUserEvents(event, organizationId);
expect(inviteExistingUserToOrg).toHaveBeenCalled();
expect(sendExistingUserTeamInviteEmails).toHaveBeenCalled();
});
it("should remove user from organization when active is false", async () => {
const userEmail = "user@example.com";
const user = await createMockUser({
email: userEmail,
organizationId: organizationId,
});
const event: DirectorySyncEvent = {
event: "user.updated",
tenant: "test-tenant",
directory_id: directoryId,
data: {
id: "user-123",
email: userEmail,
first_name: "Test",
last_name: "User",
active: false,
raw: {
schemas: [],
},
},
};
const removeUserFromOrg = (await import("./removeUserFromOrg")).default;
await handleUserEvents(event, organizationId);
expect(removeUserFromOrg).toHaveBeenCalledWith({
userId: user.id,
orgId: organizationId,
});
});
it("should sync custom attributes when user is already a member and active", async () => {
const userEmail = "user@example.com";
const user = await createMockUser({
email: userEmail,
organizationId: organizationId,
});
await createMockMembership({
userId: user.id,
teamId: organizationId,
});
const event: DirectorySyncEvent = {
event: "user.updated",
tenant: "test-tenant",
directory_id: directoryId,
data: {
id: "user-123",
email: userEmail,
first_name: "Test",
last_name: "User",
active: true,
raw: {
schemas: ["custom:enterprise"],
"custom:enterprise": {
department: "Engineering",
},
},
},
};
const { UserRepository } = await import("@calcom/features/users/repositories/UserRepository");
vi.mocked(UserRepository).mockImplementation(function () {
return {
isAMemberOfOrganization: vi.fn().mockResolvedValue(true),
} as unknown as InstanceType<typeof UserRepository>;
});
const { assignValueToUserInOrgBulk } = await import("./assignValueToUser");
await handleUserEvents(event, organizationId);
expect(assignValueToUserInOrgBulk).toHaveBeenCalledWith({
orgId: organizationId,
userId: user.id,
attributeLabelToValueMap: {
department: "Engineering",
},
updater: {
dsyncId: directoryId,
},
});
});
});
describe("Error handling", () => {
it("should throw an error when organization is not found", async () => {
const userEmail = "user@example.com";
const nonExistentOrgId = 9999;
const event: DirectorySyncEvent = {
event: "user.created",
tenant: "test-tenant",
directory_id: directoryId,
data: {
id: "user-123",
email: userEmail,
first_name: "Test",
last_name: "User",
active: true,
raw: {
schemas: [],
},
},
};
const { getTeamOrThrow } = await import("@calcom/trpc/server/routers/viewer/teams/inviteMember/utils");
vi.mocked(getTeamOrThrow).mockResolvedValue(
null as unknown as Awaited<ReturnType<typeof getTeamOrThrow>>
);
await expect(handleUserEvents(event, nonExistentOrgId)).rejects.toThrow("Org not found");
});
});
});