Files
calendar/packages/lib/isOutOfBounds.tsx
T
c28eb90928 chore: Upgrade prisma to 6.7.0 (#21264)
* chore: Upgrade prisma to 6.7.0

* Build fixes

* type fixes

Signed-off-by: Omar López <zomars@me.com>

* Update schema.prisma

* Patching

* Revert "Update schema.prisma"

This reverts commit 47d8618bf89ef4d007b30084df766f17281e21a1.

* Revert "Patching"

This reverts commit a1d2e3040e71690a44d4324db95d73b4d68c6adb.

* Revert schema changes

Signed-off-by: Omar López <zomars@me.com>

* WIP

Signed-off-by: Omar López <zomars@me.com>

* Update getPublicEvent.ts

* Update imports

Signed-off-by: Omar López <zomars@me.com>

* Update gitignore

Signed-off-by: Omar López <zomars@me.com>

* update remaining imports

Signed-off-by: Omar López <zomars@me.com>

* Delete .cursor/config.json

* Discard changes to packages/features/eventtypes/lib/getPublicEvent.ts

* Update _get.ts

* Update user.ts

* Update .gitignore

* update

* Update WorkflowStepContainer.tsx

* Update next-auth-custom-adapter.ts

* Update getPublicEvent.ts

* Update workflow.ts

* Update next-auth-custom-adapter.ts

* Update next-auth-options.ts

* Update bookingScenario.ts

* fix missing imports

* upgrades prismock

Signed-off-by: Omar López <zomars@me.com>

* patches prismock

Signed-off-by: Omar López <zomars@me.com>

* Update reschedule.test.ts

* Update prisma.ts

* patch prismock

Signed-off-by: Omar López <zomars@me.com>

* fix enums imports

Signed-off-by: Omar López <zomars@me.com>

* Revert "Update prisma.ts"

This reverts commit 64edcf8db54171ff4456c209d563b5d431d99619.

* Revert "patch prismock"

This reverts commit e95819113dc9d88e7130947aa120cd42710977c8.

* fix patch

* Fix test that overrun the boundary, it shouldn't test too much

* Move prisma import to changeSMSLockState

* Bring back broken test without illegal imports

* Merge with main and fix filter hosts by same round robin host

* Fixed buildDryRunBooking fn tests

* Fix and move ooo create or update handler test

* Fix packages/features/eventtypes/lib/isCurrentlyAvailable.test.ts

* Fix packages/trpc/server/routers/viewer/organizations/listMembers.handler.test.ts

* Mock @calcom/prisma

* Fix: verify-email.test.ts

* fix: Moved WebhookService test and fixed default import mock

* Fix: Added missing prisma mock, handleNewBooking uses that of course

* We're not testing createContext here

* fix: Prisma mock fix for listMembers.test.ts

* More fixes to broken testcases

* Forgot to remove borked test

* Prevent the need to mock a lot of dependencies by moving out buildBaseWhereCondition to its own file

* Temporarily skip getCalendarEvents, needs a rewrite

* Fix: turns out you can access protected in testcases

* fix further mocks

* Added packages/features/insights/server/buildBaseWhereCondition.ts, types

* Always great to have a mock and then not use it

* And one less again.

* fix: confirm.handler.test, didn't mock prisma

* fix: Address minor nit by @eunjae & fix ImpersonationProvider test

* Updated isPrismaAvailableCheck that doesn't crash on import

* fix: Get Prisma directly from the client, it usually involves the Validator and does not need 'local' inclusion

* Add zod-prisma-types without the generator enabled (commented out)

* Uncomment and see what happens

* Change method of import as imports did not work in Input Schemas

* Remove custom 'zod' booking model, it does not belong with Prisma

* Fix all other global Model imports

* Rewrite most schema includes AND remove barrel file

* Add bookingCreateBodySchema to features/bookings

* Flurry of type fixes for compatibility with new zod gen

* Refactor out the custom prisma type createEventTypeInput

* Work around nullable eventTypeLocations

* HandlePayment type fix

* More fixes, final fix remaining is CompleteEventType

* Should fix a bunch more booking related type errors

* Missed one

* Some props missing from BookingCreateBodySchema

* Fix location type in handleChildrenEventTypes

* Little bit hacky imo but it works

* Final type error \o/

* Forgot to include Prisma

* Do not include zod-utils in booker/types

* Oops, was already including Booker/types

* Fix membership type, also disallow updating createdAt/updatedAt, make part of patch/post

* Fix api v1 type errors

* Fix EventTypeDescription typings

* Remove getParserWithGeneric, use userBodySchema with UserSchema

* use centralized timeZoneSchema

* Implement feedback by @zomars

* Couple of WIP pushes

* Fix tests

* Type fixes in `handleChildrenEventTypes` test

* Try and parse metadata before use

* Change zod-prisma-types configuration for optimal performance

* Fix prisma validator error in `prisma/selects/credential`

* Disable seperate relations model, hits a bug

* Import absolute - this makes rollup work in @platform/libraries

* Attempt at removing resolutions override

* Refactor using `Prisma.validator` to `satisfies`

* Build atoms using @calcom/prisma/client

* Build atoms using @calcom/prisma/client

* fixes

* Update eventTypeSelect.ts

* Adjust `eventTypeMetaDataSchemaWithUntypedApps` from `unknown` to `record(any)`

* `EventTypeDescription` rely on `descriptionAsSafeHTML` instead of `description`

* Add `seatsPerTimeSlot` to event type public select

* Fix typing in `users-public-view` getServerSide props

* Add missing `schedulingType` to prop

* chore: bump platform libraries

* Function return type is illegal, not sure how this passed eslint (#21567)

* Merged with main

* Update updateTokenObject.ts

* Update handleResponse.ts

* Update index.ts

* Update handleChildrenEventTypes.ts

* Update booking-idempotency-key.ts

* Update WebhookService.test.ts

* Update events.test.ts

* Update queued-response.test.ts

* Update events.test.ts

* Update getRoutedUrl.test.ts

* fix: type checks

Signed-off-by: Omar López <zomars@me.com>

* fixes

Signed-off-by: Omar López <zomars@me.com>

* chore: bump platform libraries

* Update yarn.lock

* more fixes

Signed-off-by: Omar López <zomars@me.com>

* fixes

Signed-off-by: Omar López <zomars@me.com>

* biuld fixes

* chore: bump platform libraries

* Update conferencing.repository.ts

* Update conferencing.repository.ts

* Update getCalendarsEvents.test.ts

* Update vite.config.js

* chore: bump platform libraries

* Update users.ts

* Discard changes to docs/api-reference/v2/openapi.json

* Update vite.config.ts

* updated platform libraries

* Update get.handler.test.ts

* Update get.handler.test.ts

* Update schema.prisma

* Discard changes to docs/api-reference/v2/openapi.json

* Update next-auth-custom-adapter.ts

* Update team.ts

* Flurry of type fixes

* Fix majority of insight related type errors

* Type fixes for unlink of account

* Make user nullable again

* Fixed a bunch of unit tests and one type error

* Attempted mock fix

* Attempted fix for Attribute type

* Ensure default import becomes prisma, but not direct usage

* Import default as prisma in prisma.module

* Add attributeOption to attribute type

* Fix calcom/prisma mock

* Refactor Prisma client imports to @calcom/prisma/client

Updated all imports from '@prisma/client' to '@calcom/prisma/client' across tests and repository files for consistency and to use the correct Prisma client package. This change improves maintainability and ensures the correct client is referenced throughout the codebase.

* Undo removal of max-warnings=0 to get main to merge

* Remove unit tests for e2e fixtures, provide new prisma mock

* Mock @calcom/prisma in event manager

* Mock @calcom/prisma in event manager

* Add correct format even with --no-verify

* Mock prisma in CalendarManager

* Add mock for permission-check.service

* Better injection in PrismaApiKeyRepository imports

* More mock fixes :)

* Fix listMembers.handler.test

* Fix User import

* Appropriately adjust all types to be imported as types, there were a lot of types imported as normal deps

* Why was this a thing?

* Strictly speaking; Not using prismock anymore

* Ditched patch file for prismock

* Fix output.service.ts platform type imports, need concrete for plainToClass

* Better typing and tests for unlinkConnectedAccount.handler

* Small type fix

* Disable calendar cache tests as they are dependent on prismock

* chore: bump platform lib

* getRoutedUrl test remove of unused import

* Extract select to external const on getEventTypesFromDB

* Direct select of userSelect from selects/user

* fix type error from merging 23653

* Fixed integration tests by removing hardcoded values that were possible due to mocking, but as its now directly hitting the db no longer

* fix: vite config atoms prisma client type location

* revert: example app prisma client

* revert: example app prisma client

* bump platform libs

* fix: use class instead of type for DI of PlatformBookingsService

* update platform libs

* remove unused variable

* chore: generate prisma client for api v2

* fix: api v2 e2e

* fix: atoms e2e

* fix: atoms e2e

* fix: atoms e2e

* fix: api v2 e2e

* fix: tsconfig apiv2 enums

* publish libraries

* Simplify check for existence teamId

---------

Signed-off-by: Omar López <zomars@me.com>
Co-authored-by: Alex van Andel <me@alexvanandel.com>
Co-authored-by: Joe Au-Yeung <j.auyeung419@gmail.com>
Co-authored-by: supalarry <laurisskraucis@gmail.com>
Co-authored-by: cal.com <morgan@cal.com>
Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com>
Co-authored-by: Benny Joo <sldisek783@gmail.com>
2025-09-11 15:27:50 +01:00

364 lines
12 KiB
TypeScript

import dayjs from "@calcom/dayjs";
import type { EventType } from "@calcom/prisma/client";
import { PeriodType } from "@calcom/prisma/enums";
import { ROLLING_WINDOW_PERIOD_MAX_DAYS_TO_CHECK } from "./constants";
import logger from "./logger";
import { safeStringify } from "./safeStringify";
export class BookingDateInPastError extends Error {
constructor(message = "Attempting to book a meeting in the past.") {
super(message);
}
}
function guardAgainstBookingInThePast(date: Date) {
if (date >= new Date()) {
// Date is in the future.
return;
}
throw new BookingDateInPastError();
}
/**
* Dates passed to this function are timezone neutral.
*/
export function calculatePeriodLimits({
periodType,
periodDays,
periodCountCalendarDays,
periodStartDate,
periodEndDate,
/**
* These dates will be considered in the same utfcOffset as provided
*/
allDatesWithBookabilityStatusInBookerTz,
eventUtcOffset,
bookerUtcOffset,
/**
* This is temporary till we find a way to provide allDatesWithBookabilityStatus in handleNewBooking without re-computing availability.
* It is okay for handleNewBooking to pass it as true as the frontend won't allow selecting a timeslot that is out of bounds of ROLLING_WINDOW
* But for the booking that happen through API, we absolutely need to check the ROLLING_WINDOW limits.
*/
_skipRollingWindowCheck,
}: Pick<
EventType,
"periodType" | "periodDays" | "periodCountCalendarDays" | "periodStartDate" | "periodEndDate"
> & {
allDatesWithBookabilityStatusInBookerTz: Record<string, { isBookable: boolean }> | null;
eventUtcOffset: number;
bookerUtcOffset: number;
_skipRollingWindowCheck?: boolean;
}): PeriodLimits {
const currentTime = dayjs();
const currentTimeInEventTz = currentTime.utcOffset(eventUtcOffset);
const currentTimeInBookerTz = currentTime.utcOffset(bookerUtcOffset);
periodDays = periodDays || 0;
const log = logger.getSubLogger({ prefix: ["calculatePeriodLimits"] });
log.debug(
safeStringify({
periodType,
periodDays,
periodCountCalendarDays,
periodStartDate: periodStartDate,
periodEndDate: periodEndDate,
currentTime: currentTimeInEventTz.format(),
})
);
switch (periodType) {
case PeriodType.ROLLING: {
// We use booker's timezone to calculate the end of the rolling period(for both ROLLING and ROLLING_WINDOW). This is because we want earliest possible timeslot to be available to be booked which could be on an earlier day(compared to event timezone) as per booker's timezone.
// So, if 2 day rolling period is set and 2024-07-24T8:30:00 slot is available in event timezone, the corresponding slot in GMT-11 would be 2024-07-24T21:30:00. So, 24th should be bookable for that timeslot, which could only be made available if we consider things in booker timezone.
const rollingEndDay = periodCountCalendarDays
? currentTimeInBookerTz.add(periodDays, "days")
: currentTimeInBookerTz.businessDaysAdd(periodDays);
// The future limit talks in terms of days so we take the end of the day here to consider the entire day
return {
endOfRollingPeriodEndDayInBookerTz: rollingEndDay.endOf("day"),
startOfRangeStartDayInEventTz: null,
endOfRangeEndDayInEventTz: null,
};
}
case PeriodType.ROLLING_WINDOW: {
if (_skipRollingWindowCheck) {
return {
endOfRollingPeriodEndDayInBookerTz: null,
startOfRangeStartDayInEventTz: null,
endOfRangeEndDayInEventTz: null,
};
}
if (!allDatesWithBookabilityStatusInBookerTz) {
throw new Error("`allDatesWithBookabilityStatus` is required");
}
const endOfRollingPeriodEndDayInBookerTz = getRollingWindowEndDate({
startDateInBookerTz: currentTimeInBookerTz,
daysNeeded: periodDays,
allDatesWithBookabilityStatusInBookerTz,
countNonBusinessDays: periodCountCalendarDays,
});
return {
endOfRollingPeriodEndDayInBookerTz,
startOfRangeStartDayInEventTz: null,
endOfRangeEndDayInEventTz: null,
};
}
case PeriodType.RANGE: {
// We take the start of the day for the start of the range and endOf the day for end of range, so that entire days are covered
// We use organizer's timezone here(in contrast with ROLLING/ROLLING_WINDOW where number of days is available and not the specific date objects).
// This is because in case of range the start and end date objects are determined by the organizer, so we should consider the range in organizer/event's timezone.
const startOfRangeStartDayInEventTz = dayjs(periodStartDate).utcOffset(eventUtcOffset).startOf("day");
const endOfRangeEndDayInEventTz = dayjs(periodEndDate).utcOffset(eventUtcOffset).endOf("day");
return {
endOfRollingPeriodEndDayInBookerTz: null,
startOfRangeStartDayInEventTz,
endOfRangeEndDayInEventTz,
};
}
}
return {
endOfRollingPeriodEndDayInBookerTz: null,
startOfRangeStartDayInEventTz: null,
endOfRangeEndDayInEventTz: null,
};
}
export function getRollingWindowEndDate({
startDateInBookerTz,
daysNeeded,
allDatesWithBookabilityStatusInBookerTz,
countNonBusinessDays,
}: {
/**
* It should be provided in the same utcOffset as the dates in `allDatesWithBookabilityStatus`
* This is because we do a lookup by day in `allDatesWithBookabilityStatus`
*/
startDateInBookerTz: dayjs.Dayjs;
daysNeeded: number;
allDatesWithBookabilityStatusInBookerTz: Record<string, { isBookable: boolean }>;
countNonBusinessDays: boolean | null;
}) {
const log = logger.getSubLogger({ prefix: ["getRollingWindowEndDate"] });
log.debug("called:", safeStringify({ startDay: startDateInBookerTz.format(), daysNeeded }));
let counter = 1;
let rollingEndDay;
const startOfStartDayInEventTz = startDateInBookerTz.startOf("day");
// It helps to break out of the loop if we don't find enough bookable days.
const maxDaysToCheck = ROLLING_WINDOW_PERIOD_MAX_DAYS_TO_CHECK;
let bookableDaysCount = 0;
let startOfIterationDay = startOfStartDayInEventTz;
// Add periodDays to currentDate, skipping non-bookable days.
while (bookableDaysCount < daysNeeded) {
// What if we don't find any bookable days. We should break out of the loop after a certain number of days.
if (counter > maxDaysToCheck) {
break;
}
const onlyDateOfIterationDay = startOfIterationDay.format("YYYY-MM-DD");
const isBookable = !!allDatesWithBookabilityStatusInBookerTz[onlyDateOfIterationDay]?.isBookable;
if (isBookable) {
bookableDaysCount++;
rollingEndDay = startOfIterationDay;
}
log.silly(
`Loop Iteration: ${counter}`,
safeStringify({
iterationDayBeginning: startOfIterationDay.format(),
isBookable,
bookableDaysCount,
rollingEndDay: rollingEndDay?.format(),
allDatesWithBookabilityStatusInBookerTz,
})
);
startOfIterationDay = countNonBusinessDays
? startOfIterationDay.add(1, "days")
: startOfIterationDay.businessDaysAdd(1);
counter++;
}
/**
* We can't just return null(if rollingEndDay couldn't be obtained) and allow days farther than ROLLING_WINDOW_PERIOD_MAX_DAYS_TO_CHECK to be booked as that would mean there is no future limit
* The future limit talks in terms of days so we take the end of the day here to consider the entire day
*/
const endOfLastDayOfWindowInBookerTz = (rollingEndDay ?? startOfIterationDay).endOf("day");
log.debug("Returning rollingEndDay", endOfLastDayOfWindowInBookerTz.format());
return endOfLastDayOfWindowInBookerTz;
}
/**
* To be used when we work on Timeslots(and not Dates) to check boundaries
* It ensures that the time isn't in the past and also checks if the time is within the minimum booking notice.
* Note: It throws error that needs to be caught by caller.
*/
export function isTimeOutOfBounds({
time,
minimumBookingNotice,
}: {
time: dayjs.ConfigType;
minimumBookingNotice?: number;
}) {
const date = dayjs(time);
guardAgainstBookingInThePast(date.toDate());
if (minimumBookingNotice) {
const minimumBookingStartDate = dayjs().add(minimumBookingNotice, "minutes");
if (date.isBefore(minimumBookingStartDate)) {
return true;
}
}
return false;
}
/**
* Wrapper over isTimeOutOfBounds to return a status object.
* Note: It doesn't throw any error and can be safely used
*/
export function getPastTimeAndMinimumBookingNoticeBoundsStatus({
time,
minimumBookingNotice,
}: {
time: dayjs.ConfigType;
minimumBookingNotice?: number;
}): {
isOutOfBounds: boolean;
reason: "minBookNoticeViolation" | "slotInPast" | null;
} {
try {
const isOutOfBounds = isTimeOutOfBounds({ time, minimumBookingNotice });
return {
isOutOfBounds,
reason: isOutOfBounds ? "minBookNoticeViolation" : null,
};
} catch (error) {
if (error instanceof BookingDateInPastError) {
return {
isOutOfBounds: true,
reason: "slotInPast",
};
}
throw error;
}
}
type PeriodLimits = {
endOfRollingPeriodEndDayInBookerTz: dayjs.Dayjs | null;
startOfRangeStartDayInEventTz: dayjs.Dayjs | null;
endOfRangeEndDayInEventTz: dayjs.Dayjs | null;
};
export function isTimeViolatingFutureLimit({
time,
periodLimits,
}: {
time: string | Date | number;
periodLimits: PeriodLimits;
}) {
const log = logger.getSubLogger({ prefix: ["isTimeViolatingFutureLimit"] });
const dateObj = new Date(time);
if (periodLimits.endOfRollingPeriodEndDayInBookerTz) {
const isAfterRollingEndDay =
dateObj.valueOf() > periodLimits.endOfRollingPeriodEndDayInBookerTz.valueOf();
if (isAfterRollingEndDay)
log.warn(
"Booking is out of bounds due to rolling period end day.",
safeStringify({
formattedDate: dateObj.toISOString(),
isAfterRollingEndDay,
endOfRollingPeriodEndDayTs: periodLimits.endOfRollingPeriodEndDayInBookerTz.valueOf(),
})
);
return isAfterRollingEndDay;
}
if (periodLimits.startOfRangeStartDayInEventTz && periodLimits.endOfRangeEndDayInEventTz) {
const isBeforeRangeStart = dateObj.valueOf() < periodLimits.startOfRangeStartDayInEventTz.valueOf();
const isAfterRangeEnd = dateObj.valueOf() > periodLimits.endOfRangeEndDayInEventTz.valueOf();
if (isBeforeRangeStart || isAfterRangeEnd)
log.warn(
"Booking is out of bounds due to range start and end.",
safeStringify({
formattedDate: dateObj.toISOString(),
isBeforeRangeStart,
isAfterRangeEnd,
startOfRangeStartDayInEventTz: periodLimits.startOfRangeStartDayInEventTz.toDate().toISOString(),
endOfRangeEndDayInEventTz: periodLimits.endOfRangeEndDayInEventTz.toDate().toISOString(),
})
);
return isBeforeRangeStart || isAfterRangeEnd;
}
return false;
}
export default function isOutOfBounds(
time: NonNullable<dayjs.ConfigType>,
{
periodType,
periodDays,
periodCountCalendarDays,
periodStartDate,
periodEndDate,
eventUtcOffset,
bookerUtcOffset,
}: Pick<
EventType,
"periodType" | "periodDays" | "periodCountCalendarDays" | "periodStartDate" | "periodEndDate"
> & {
eventUtcOffset: number;
bookerUtcOffset: number;
},
minimumBookingNotice?: number
) {
const log = logger.getSubLogger({ prefix: ["isOutOfBounds"] });
const isOutOfBoundsByTime = isTimeOutOfBounds({ time, minimumBookingNotice });
const periodLimits = calculatePeriodLimits({
periodType,
periodDays,
periodCountCalendarDays,
periodStartDate,
periodEndDate,
allDatesWithBookabilityStatusInBookerTz: null, // Temporary workaround
_skipRollingWindowCheck: true,
eventUtcOffset,
bookerUtcOffset,
});
const isOutOfBoundsByPeriod = isTimeViolatingFutureLimit({
time: dayjs.isDayjs(time) ? time.toDate() : time,
periodLimits,
});
if (isOutOfBoundsByTime) {
log.warn(
"Booking is out of bounds due to minimum booking notice.",
safeStringify({ minimumBookingNotice })
);
return true;
}
if (isOutOfBoundsByPeriod) {
log.warn("Booking is out of bounds due to period restrictions", safeStringify({ periodLimits }));
return true;
}
return false;
}