Files
calendar/packages/features/bookings/lib/getAllCredentialsForUsersOnEvent/getAllCredentials.test.ts
T
devin-ai-integration[bot]GitHubDevin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>morgan@cal.com <morgan@cal.com>Morgan
e4c47640fc refactor: convert UserRepository to use dependency injection pattern (#22360)
* refactor: convert UserRepository to use dependency injection pattern

- Convert all static methods to public instance methods
- Add constructor that takes PrismaClient parameter
- Update all usage sites to use new instantiation pattern: new UserRepository(prisma).method()
- Follow same pattern as PrismaOOORepository for consistency
- Maintain all existing method logic and signatures unchanged
- Update 125+ files across the codebase to adapt to new pattern

Co-Authored-By: morgan@cal.com <morgan@cal.com>

* optimize: reuse UserRepository instances within same function scope

- Create single UserRepository instance per function scope
- Reuse instance for multiple method calls within same function
- Reduces object instantiation overhead and improves performance
- Apply optimization pattern consistently across codebase

Co-Authored-By: morgan@cal.com <morgan@cal.com>

* fix: repository

* fixup! fix: repository

* fixup! fixup! fix: repository

* fixup! fixup! fixup! fix: repository

* fix: update test mocking strategies for UserRepository dependency injection

- Convert static method mocks to instance method mocks in userCreationService.test.ts
- Update vi.spyOn calls to work with constructor injection pattern in getAllCredentials.test.ts
- Fix UserRepository mocking in getRoutedUrl.test.ts to use constructor injection
- Ensure consistent mocking approach across all test files
- Fix 'UserRepository is not a constructor' errors in tests

Co-Authored-By: morgan@cal.com <morgan@cal.com>

* feat: optimize UserRepository instance reuse and add SessionUser type

- Reuse UserRepository instance in OrganizationRepository.createWithNonExistentOwner
- Add comprehensive SessionUser type definition for type safety
- Improve type constraints in enrichUserWithTheProfile and enrichUserWithItsProfile
- Ensure proper return types with profile information

Co-Authored-By: morgan@cal.com <morgan@cal.com>

* fix: make UserRepository mocking strategy more robust for CI environments

- Add defensive checks for vi.mocked() to handle CI environment differences
- Ensure mockImplementation is available before calling it
- Maintain consistent mocking pattern across all test files
- Fix 'Cannot read properties of undefined' error in CI

Co-Authored-By: morgan@cal.com <morgan@cal.com>

* fixup! fix: make UserRepository mocking strategy more robust for CI environments

* refactor: convert direct UserRepository instantiations to two-step pattern

- Change await new UserRepository(prisma).method(...) to const userRepo = new UserRepository(prisma); await userRepo.method(...)
- Optimize instance reuse within same function scopes
- Apply pattern consistently across all modified files in PR
- Fix type errors in organization.ts and sessionMiddleware.ts

Co-Authored-By: morgan@cal.com <morgan@cal.com>

* refactor: complete two-step UserRepository pattern for remaining files

- Apply two-step instantiation pattern to all remaining modified files in PR
- Ensure consistent UserRepository usage across entire codebase
- Maintain instance reuse optimization within function scopes

Co-Authored-By: morgan@cal.com <morgan@cal.com>

* chore: bump platform libs

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: morgan@cal.com <morgan@cal.com>
Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com>
2025-07-10 12:11:14 +00:00

772 lines
21 KiB
TypeScript

import {
createCredentials,
addTeamsToDb,
addEventTypesToDb,
addUsersToDb,
} from "@calcom/web/test/utils/bookingScenario/bookingScenario";
import { describe, test, expect, vi } from "vitest";
import { UserRepository } from "@calcom/lib/server/repository/user";
vi.mock("@calcom/lib/server/repository/user", () => {
return {
UserRepository: vi.fn().mockImplementation(() => ({
enrichUserWithItsProfile: vi.fn(),
})),
};
});
describe("getAllCredentialsIncludeServiceAccountKey", () => {
test("Get an individual's credentials", async () => {
const mockEnrichUserWithItsProfile = vi.fn().mockReturnValue({
profile: null,
});
const mockUserRepository = vi.mocked(UserRepository);
if (mockUserRepository && typeof mockUserRepository.mockImplementation === "function") {
mockUserRepository.mockImplementation(
() =>
({
enrichUserWithItsProfile: mockEnrichUserWithItsProfile,
} as any)
);
}
const getAllCredentialsIncludeServiceAccountKey = (await import("./getAllCredentials"))
.getAllCredentialsIncludeServiceAccountKey;
const userCredential = {
id: 1,
type: "user-credential",
userId: 1,
teamId: null,
key: {},
appId: "user-credential",
invalid: false,
};
await createCredentials([
userCredential,
{ type: "other-user-credential", userId: 2, key: {} },
{ type: "team-credential", teamId: 1, key: {} },
]);
const credentials = await getAllCredentialsIncludeServiceAccountKey(
{
id: 1,
username: "test",
credentials: [{ ...userCredential, user: { email: "test@test.com" } }],
},
{
userId: 1,
team: null,
parentId: null,
metadata: {},
}
);
expect(credentials).toHaveLength(1);
expect(credentials).toContainEqual(expect.objectContaining({ type: "user-credential" }));
});
describe("Handle CRM credentials", () => {
describe("If CRM is enabled on the event type", () => {
describe("With _crm credentials", () => {
test("For users", async () => {
const mockEnrichUserWithItsProfile = vi.fn().mockReturnValue({
profile: null,
});
const mockUserRepository = vi.mocked(UserRepository);
if (mockUserRepository && typeof mockUserRepository.mockImplementation === "function") {
mockUserRepository.mockImplementation(
() =>
({
enrichUserWithItsProfile: mockEnrichUserWithItsProfile,
} as any)
);
}
const getAllCredentialsIncludeServiceAccountKey = (await import("./getAllCredentials"))
.getAllCredentialsIncludeServiceAccountKey;
const crmCredential = {
id: 1,
type: "salesforce_crm",
userId: 1,
teamId: null,
key: {},
appId: "salesforce",
invalid: false,
};
const otherCredential = {
id: 2,
type: "other_credential",
userId: 1,
teamId: null,
key: {},
appId: "other",
invalid: false,
};
await createCredentials([
crmCredential,
{
type: "salesforce_crm",
userId: 2,
key: {},
},
{
type: "salesforce_crm",
teamId: 1,
key: {},
},
]);
const credentials = await getAllCredentialsIncludeServiceAccountKey(
{
id: 1,
username: "test",
credentials: [
{ ...crmCredential, user: { email: "test@test.com" } },
{
...otherCredential,
user: { email: "test@test.com" },
},
],
},
{
userId: 1,
team: null,
parentId: null,
metadata: {
apps: {
salesforce: {
enabled: true,
credentialId: 1,
appCategories: ["crm"],
},
},
},
}
);
expect(credentials).toHaveLength(2);
expect(credentials).toContainEqual(expect.objectContaining({ userId: 1, type: "salesforce_crm" }));
});
test("For teams", async () => {
const mockEnrichUserWithItsProfile = vi.fn().mockReturnValue({
profile: null,
});
const mockUserRepository = vi.mocked(UserRepository);
if (mockUserRepository && typeof mockUserRepository.mockImplementation === "function") {
mockUserRepository.mockImplementation(
() =>
({
enrichUserWithItsProfile: mockEnrichUserWithItsProfile,
} as any)
);
}
const getAllCredentialsIncludeServiceAccountKey = (await import("./getAllCredentials"))
.getAllCredentialsIncludeServiceAccountKey;
const crmCredential = {
id: 1,
type: "salesforce_crm",
userId: 1,
teamId: null,
key: {},
appId: "salesforce",
invalid: false,
};
await createCredentials([
crmCredential,
{
type: "salesforce_crm",
userId: 2,
key: {},
},
{
id: 3,
type: "salesforce_crm",
teamId: 1,
key: {},
},
{
type: "other_credential",
teamId: 1,
key: {},
},
]);
const credentials = await getAllCredentialsIncludeServiceAccountKey(
{
id: 1,
username: "test",
credentials: [{ ...crmCredential, user: { email: "test@test.com" } }],
},
{
userId: null,
team: {
id: 1,
parentId: null,
},
parentId: null,
metadata: {
apps: {
salesforce: {
enabled: true,
credentialId: 3,
appCategories: ["crm"],
},
},
},
}
);
expect(credentials).toHaveLength(2);
expect(credentials).toContainEqual(expect.objectContaining({ teamId: 1, type: "salesforce_crm" }));
});
test("For child of managed event type", async () => {
const mockEnrichUserWithItsProfile = vi.fn().mockReturnValue({
profile: null,
});
const mockUserRepository = vi.mocked(UserRepository);
if (mockUserRepository && typeof mockUserRepository.mockImplementation === "function") {
mockUserRepository.mockImplementation(
() =>
({
enrichUserWithItsProfile: mockEnrichUserWithItsProfile,
} as any)
);
}
const getAllCredentialsIncludeServiceAccountKey = (await import("./getAllCredentials"))
.getAllCredentialsIncludeServiceAccountKey;
const teamId = 1;
const crmCredential = {
id: 1,
type: "salesforce_crm",
userId: 1,
teamId: null,
key: {},
appId: "salesforce",
invalid: false,
};
await createCredentials([
crmCredential,
{
type: "salesforce_crm",
userId: 2,
key: {},
},
{
id: 3,
type: "salesforce_crm",
teamId,
key: {},
},
{
type: "other_credential",
teamId,
key: {},
},
]);
await addTeamsToDb([
{
id: teamId,
name: "Test team",
slug: "test-team",
},
]);
const testEventType = await addEventTypesToDb([
{
id: 3,
title: "Test event type",
slug: "test-event-type",
length: 15,
team: {
connect: {
id: teamId,
},
},
},
]);
console.log(testEventType);
const credentials = await getAllCredentialsIncludeServiceAccountKey(
{
id: 1,
username: "test",
credentials: [{ ...crmCredential, user: { email: "test@test.com" } }],
},
{
userId: null,
team: {
id: 2,
parentId: 1,
},
parentId: 3,
metadata: {
apps: {
salesforce: {
enabled: true,
credentialId: 3,
appCategories: ["crm"],
},
},
},
}
);
expect(credentials).toHaveLength(2);
expect(credentials).toContainEqual(expect.objectContaining({ teamId, type: "salesforce_crm" }));
});
test("For an org user", async () => {
const getAllCredentialsIncludeServiceAccountKey = (await import("./getAllCredentials"))
.getAllCredentialsIncludeServiceAccountKey;
const orgId = 3;
const mockEnrichUserWithItsProfile = vi.fn().mockReturnValue({
profile: { organizationId: orgId },
});
const mockUserRepository = vi.mocked(UserRepository);
if (mockUserRepository && typeof mockUserRepository.mockImplementation === "function") {
mockUserRepository.mockImplementation(
() =>
({
enrichUserWithItsProfile: mockEnrichUserWithItsProfile,
} as any)
);
}
const crmCredential = {
id: 1,
type: "salesforce_crm",
userId: 1,
teamId: null,
key: {},
appId: "salesforce",
invalid: false,
};
const otherCredential = {
id: 2,
type: "other_credential",
userId: 1,
teamId: null,
key: {},
appId: "other",
invalid: false,
};
await createCredentials([
crmCredential,
{
type: "salesforce_crm",
userId: 2,
key: {},
},
{
id: 3,
type: "salesforce_crm",
teamId: orgId,
key: {},
},
{
type: "other_credential",
teamId: orgId,
key: {},
},
]);
await addTeamsToDb([
{
id: orgId,
name: "Test team",
slug: "test-team",
},
]);
await addUsersToDb([
{
id: 1,
email: "test@test.com",
username: "test",
schedules: [],
profiles: {
create: [{ organizationId: orgId, uid: "MOCK_UID", username: "test" }],
},
},
]);
const credentials = await getAllCredentialsIncludeServiceAccountKey(
{
id: 1,
username: "test",
credentials: [
{ ...crmCredential, user: { email: "test@test.com" } },
{
...otherCredential,
user: { email: "test@test.com" },
},
],
},
{
userId: 1,
team: null,
parentId: null,
metadata: {
apps: {
salesforce: {
enabled: true,
credentialId: 3,
appCategories: ["crm"],
},
},
},
}
);
expect(credentials).toHaveLength(3);
expect(credentials).toContainEqual(
expect.objectContaining({ teamId: orgId, type: "salesforce_crm" })
);
});
});
describe("Default with _other_calendar credentials", () => {
test("For users", async () => {
const getAllCredentialsIncludeServiceAccountKey = (await import("./getAllCredentials"))
.getAllCredentialsIncludeServiceAccountKey;
const crmCredential = {
id: 1,
type: "salesforce_other_calendar",
userId: 1,
teamId: null,
key: {},
appId: "salesforce",
invalid: false,
};
const otherCredential = {
id: 2,
type: "other_credential",
userId: 1,
teamId: null,
key: {},
appId: "other",
invalid: false,
};
await createCredentials([
crmCredential,
{
type: "salesforce_crm",
userId: 2,
key: {},
},
{
type: "salesforce_crm",
teamId: 1,
key: {},
},
]);
const credentials = await getAllCredentialsIncludeServiceAccountKey(
{
id: 1,
username: "test",
credentials: [
{ ...crmCredential, user: { email: "test@test.com" } },
{
...otherCredential,
user: { email: "test@test.com" },
},
],
},
{
userId: 1,
team: null,
parentId: null,
metadata: {
apps: {},
},
}
);
expect(credentials).toHaveLength(2);
expect(credentials).toContainEqual(
expect.objectContaining({ userId: 1, type: "salesforce_other_calendar" })
);
});
test("For teams", async () => {
const getAllCredentialsIncludeServiceAccountKey = (await import("./getAllCredentials"))
.getAllCredentialsIncludeServiceAccountKey;
const crmCredential = {
id: 1,
type: "salesforce_crm",
userId: 1,
teamId: null,
key: {},
appId: "salesforce",
invalid: false,
};
await createCredentials([
crmCredential,
{
type: "salesforce_crm",
userId: 2,
key: {},
},
{
id: 3,
type: "salesforce_other_calendar",
teamId: 1,
key: {},
},
{
type: "other_credential",
teamId: 1,
key: {},
},
]);
const credentials = await getAllCredentialsIncludeServiceAccountKey(
{
id: 1,
username: "test",
credentials: [{ ...crmCredential, user: { email: "test@test.com" } }],
},
{
userId: null,
team: {
id: 1,
parentId: null,
},
parentId: null,
metadata: {
apps: {},
},
}
);
expect(credentials).toHaveLength(2);
expect(credentials).toContainEqual(
expect.objectContaining({ teamId: 1, type: "salesforce_other_calendar" })
);
});
test("For child of managed event type", async () => {
const getAllCredentialsIncludeServiceAccountKey = (await import("./getAllCredentials"))
.getAllCredentialsIncludeServiceAccountKey;
const teamId = 1;
const crmCredential = {
id: 1,
type: "salesforce_crm",
userId: 1,
teamId: null,
key: {},
appId: "salesforce",
invalid: false,
};
await createCredentials([
crmCredential,
{
type: "salesforce_crm",
userId: 2,
key: {},
},
{
id: 3,
type: "salesforce_other_calendar",
teamId,
key: {},
},
{
type: "other_credential",
teamId,
key: {},
},
]);
await addTeamsToDb([
{
id: teamId,
name: "Test team",
slug: "test-team",
},
]);
const testEventType = await addEventTypesToDb([
{
id: 3,
title: "Test event type",
slug: "test-event-type",
length: 15,
team: {
connect: {
id: teamId,
},
},
},
]);
console.log(testEventType);
const credentials = await getAllCredentialsIncludeServiceAccountKey(
{
id: 1,
username: "test",
credentials: [{ ...crmCredential, user: { email: "test@test.com" } }],
},
{
userId: null,
team: {
id: 2,
parentId: 1,
},
parentId: 3,
metadata: {
apps: {},
},
}
);
expect(credentials).toHaveLength(2);
expect(credentials).toContainEqual(
expect.objectContaining({ teamId, type: "salesforce_other_calendar" })
);
});
test("For an org user", async () => {
const getAllCredentialsIncludeServiceAccountKey = (await import("./getAllCredentials"))
.getAllCredentialsIncludeServiceAccountKey;
const orgId = 3;
const mockEnrichUserWithItsProfile = vi.fn().mockReturnValue({
profile: { organizationId: orgId },
});
const mockUserRepository = vi.mocked(UserRepository);
if (mockUserRepository && typeof mockUserRepository.mockImplementation === "function") {
mockUserRepository.mockImplementation(
() =>
({
enrichUserWithItsProfile: mockEnrichUserWithItsProfile,
} as any)
);
}
const crmCredential = {
id: 1,
type: "salesforce_crm",
userId: 1,
teamId: null,
key: {},
appId: "salesforce",
invalid: false,
};
const otherCredential = {
id: 2,
type: "other_credential",
userId: 1,
teamId: null,
key: {},
appId: "other",
invalid: false,
};
await createCredentials([
crmCredential,
{
type: "salesforce_crm",
userId: 2,
key: {},
},
{
id: 3,
type: "salesforce_other_calendar",
teamId: orgId,
key: {},
},
{
type: "other_credential",
teamId: orgId,
key: {},
},
]);
await addTeamsToDb([
{
id: orgId,
name: "Test team",
slug: "test-team",
},
]);
await addUsersToDb([
{
id: 1,
email: "test@test.com",
username: "test",
schedules: [],
profiles: {
create: [{ organizationId: orgId, uid: "MOCK_UID", username: "test" }],
},
},
]);
const credentials = await getAllCredentialsIncludeServiceAccountKey(
{
id: 1,
username: "test",
credentials: [
{ ...crmCredential, user: { email: "test@test.com" } },
{
...otherCredential,
user: { email: "test@test.com" },
},
],
},
{
userId: 1,
team: null,
parentId: null,
metadata: {
apps: {},
},
}
);
expect(credentials).toHaveLength(3);
expect(credentials).toContainEqual(
expect.objectContaining({ teamId: orgId, type: "salesforce_other_calendar" })
);
});
});
});
});
});