Files
calendar/apps/web/test/lib/getSchedule/selectedSlots.test.ts
T
Keith WilliamsGitHubDevin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>Joe Au-YeungJoe Au-YeungAlex van Andel
6e09489685 perf: implement quick app store loading optimizations (#22450)
* perf: implement quick app store loading optimizations

- Add conditional app store imports in videoClient and handlePayment
- Implement lazy calendar manager pattern in CalendarManager
- Enhance createCachedImport with better concurrency handling
- Create calendar-only registry for common calendar operations
- Add performance instrumentation for debugging

These optimizations reduce initial app store loading time by avoiding
module-level imports and creating smaller, focused registries for
calendar operations.

Co-Authored-By: keith@cal.com <keithwillcode@gmail.com>

* fix: revert getCalendar to use appStore for proper test mocking

- Reverted getCalendar.ts to use main appStore instead of calendarStore
- This ensures test mocking system works properly with existing appStoreMock
- Fixes unit test failures where Google Calendar references were getting null values
- All collective scheduling tests now pass

Co-Authored-By: keith@cal.com <keithwillcode@gmail.com>

* perf: implement CalendarServiceMap for optimized calendar loading

- Add CalendarServiceMap generation following CrmServiceMap pattern
- Update getCalendar.ts to use generated calendar service map
- Remove manual calendar-registry.ts in favor of auto-generated approach
- Reduces calendar initialization from loading 48+ apps to ~10 calendar apps

Co-Authored-By: keith@cal.com <keithwillcode@gmail.com>

* fix: update test mocks for CalendarServiceMap compatibility

- Add missing SelectedCalendar fields (createdAt, updatedAt, lastErrorAt, watchAttempts, etc.)
- Fix CredentialPayload type errors by adding user.email and delegationCredentialId
- Mock CalendarServiceMap to use vi.importActual for real calendar services
- Ensure calendar service tests work with new lazy loading approach

Co-Authored-By: keith@cal.com <keithwillcode@gmail.com>

* fix: resolve CalendarServiceMap test compatibility issues

- Update getCalendarsEvents.test.ts mocks to work with CalendarServiceMap dynamic imports
- Add missing SelectedCalendar fields (createdAt, updatedAt, lastErrorAt, watchAttempts, etc.)
- Fix CredentialPayload type errors by adding user.email and delegationCredentialId
- Use type assertion in getCalendar.ts to resolve credential type conflicts
- Ensure calendar service tests work with new lazy loading approach

Co-Authored-By: keith@cal.com <keithwillcode@gmail.com>

* fix: update test mocking for CalendarServiceMap compatibility

- Add comprehensive vi.mock for calendar.services.generated in delegation-credential tests
- Mock GoogleCalendarService and Office365CalendarService with proper return values
- Update all test files to use await with mockCalendarToHaveNoBusySlots
- Ensure calendar events return expected meetingId, meetingPassword, meetingUrl values
- Fix async/await compatibility issues in booking scenario test utilities

Co-Authored-By: keith@cal.com <keithwillcode@gmail.com>

* fix: resolve TypeScript errors in CalendarServiceMap mocking

- Extract CalendarServiceMap promise to variable to fix 'always true' condition
- Ensure vi.mocked is called on Promise type for proper mockResolvedValue access
- Add await keywords to calendar mock calls in test files
- Maintain existing functionality while making code type-safe

Co-Authored-By: keith@cal.com <keithwillcode@gmail.com>

* Remove Exchange 2013 and 2016

* Mock Exchange in all tests

* Fix tests

* Remove exchange 2013 and 2016 from app store index

* Fix merge error

* Await when getting calendar service

* Fix selectedSlot test

* Add missing variable

* Update openapi.json

* Updated CalendarService imports

* try again

* WIP migrate calendar apps to ES6

* Revert "WIP migrate calendar apps to ES6"

This reverts commit 15bf2c83305e82050779d0bca3380fa9573db1e0.

* Revert changes back to e23991024a5a455c14aa05f100a5b56288db343a

This reverts all calendar service changes that were causing circular dependency issues during builds and E2E tests.

* Remove circular dependency for location constants

* Update yarn.lock with removed package

* Add empty map when running E2E

* Type fies

* Fix merge conflict

* Remove logging statements

* Throw error and reset state if failing to load app

* Revert "Remove Exchange 2013 and 2016"

This reverts commit fedaf6346bd9e4c63337276d5a6f9e8c3943056c.

* Re-introduce exchange{2013,2016}

Revert the removal in app-store/index.ts also.

* Trying to fix tests

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Joe Au-Yeung <j.auyeung419@gmail.com>
Co-authored-by: Joe Au-Yeung <65426560+joeauyeung@users.noreply.github.com>
Co-authored-by: Alex van Andel <me@alexvanandel.com>
2025-08-26 14:35:35 +01:00

405 lines
13 KiB
TypeScript

import {
getGoogleCalendarCredential,
createBookingScenario,
Timezones,
TestData,
mockCalendarToHaveNoBusySlots,
type ScenarioData,
} from "../../utils/bookingScenario/bookingScenario";
import type { IncomingMessage } from "http";
import { describe, test, beforeEach, vi } from "vitest";
import type { z } from "zod";
import { getAvailableSlotsService } from "@calcom/lib/di/containers/AvailableSlots";
import { prisma } from "@calcom/prisma";
import type { getScheduleSchema, GetScheduleOptions } from "@calcom/trpc/server/routers/viewer/slots/types";
import { expect } from "./expects";
import { setupAndTeardown } from "./setupAndTeardown";
type ScheduleScenario = {
eventTypes: ScenarioData["eventTypes"];
users: ScenarioData["users"];
apps: ScenarioData["apps"];
selectedSlots?: ScenarioData["selectedSlots"];
};
const getTestScheduleInput = ({
yesterdayDateString,
plus5DateString,
}: {
yesterdayDateString: string;
plus5DateString: string;
}): z.infer<typeof getScheduleSchema> => ({
eventTypeId: 1,
eventTypeSlug: "",
startTime: `${yesterdayDateString}T18:30:00.000Z`,
endTime: `${plus5DateString}T18:29:59.999Z`,
timeZone: Timezones["+5:30"],
isTeamEvent: false,
orgSlug: null,
});
const getBaseScenarioData = (): ScheduleScenario => ({
eventTypes: [
{
id: 1,
slotInterval: 45,
length: 45,
users: [{ id: 101 }],
},
],
users: [
{
...TestData.users.example,
id: 101,
schedules: [TestData.schedules.IstWorkHours],
credentials: [getGoogleCalendarCredential()],
selectedCalendars: [TestData.selectedCalendars.google],
},
],
apps: [TestData.apps["google-calendar"]],
});
describe("getSchedule", () => {
const availableSlotsService = getAvailableSlotsService();
setupAndTeardown();
describe("Reserved Slots", () => {
beforeEach(async () => {
// Clear any existing selected slots before each test
await prisma.selectedSlots.deleteMany({});
});
test("should block slot from being available when reserved by another user", async () => {
// In IST timezone, it is 2024-05-31T07:00:00
vi.setSystemTime("2024-05-31T01:30:00Z");
const yesterdayDateString = "2024-05-30";
const plus2DateString = "2024-06-02";
const plus5DateString = "2024-06-05";
const scenarioData: ScheduleScenario = {
...getBaseScenarioData(),
selectedSlots: [
{
eventTypeId: 1,
userId: 101,
slotUtcStartDate: new Date(`${plus2DateString}T04:00:00.000Z`),
slotUtcEndDate: new Date(`${plus2DateString}T04:45:00.000Z`),
uid: "other-user-uid",
releaseAt: new Date(Date.now() + 1000 * 60 * 60), // 1 hour from now
},
],
};
await createBookingScenario(scenarioData);
await mockCalendarToHaveNoBusySlots("googlecalendar");
const schedule = await availableSlotsService.getAvailableSlots({
input: getTestScheduleInput({ yesterdayDateString, plus5DateString }),
});
// The 4:00 slot should not be available as it's reserved by another user
expect(schedule).not.toHaveTimeSlots([`04:00:00.000Z`], {
dateString: plus2DateString,
});
});
test("should keep all slots available when slot is reserved by the same user", async () => {
// In IST timezone, it is 2024-05-31T07:00:00
vi.setSystemTime("2024-05-31T01:30:00Z");
const yesterdayDateString = "2024-05-30";
const plus2DateString = "2024-06-02";
const plus5DateString = "2024-06-05";
const bookerClientUid = "same-user-uid";
const scenarioData: ScheduleScenario = {
...getBaseScenarioData(),
selectedSlots: [
{
eventTypeId: 1,
userId: 101,
slotUtcStartDate: new Date(`${plus2DateString}T04:00:00.000Z`),
slotUtcEndDate: new Date(`${plus2DateString}T04:45:00.000Z`),
uid: bookerClientUid,
releaseAt: new Date(Date.now() + 1000 * 60 * 60), // 1 hour from now
},
],
};
await createBookingScenario(scenarioData);
await mockCalendarToHaveNoBusySlots("googlecalendar");
const schedule = await availableSlotsService.getAvailableSlots({
input: getTestScheduleInput({ yesterdayDateString, plus5DateString }),
ctx: {
req: {
cookies: {
uid: bookerClientUid,
},
} as IncomingMessage & { cookies: { uid: string } },
},
} satisfies GetScheduleOptions);
// All slots should be available as they're reserved by the same user
expect(schedule).toHaveTimeSlots(
[
"04:00:00.000Z",
"04:45:00.000Z",
"05:30:00.000Z",
"06:15:00.000Z",
"07:00:00.000Z",
"07:45:00.000Z",
"08:30:00.000Z",
"09:15:00.000Z",
"10:00:00.000Z",
"10:45:00.000Z",
"11:30:00.000Z",
],
{
dateString: plus2DateString,
}
);
});
test("should make all slots available when reservation is expired", async () => {
// In IST timezone, it is 2024-05-31T07:00:00
vi.setSystemTime("2024-05-31T01:30:00Z");
const yesterdayDateString = "2024-05-30";
const plus2DateString = "2024-06-02";
const plus5DateString = "2024-06-05";
const scenarioData: ScheduleScenario = {
...getBaseScenarioData(),
selectedSlots: [
{
eventTypeId: 1,
userId: 101,
slotUtcStartDate: new Date(`${plus2DateString}T04:00:00.000Z`),
slotUtcEndDate: new Date(`${plus2DateString}T04:45:00.000Z`),
uid: "expired-slot-uid",
releaseAt: new Date(Date.now() - 1000 * 60 * 60), // 1 hour ago (expired)
},
],
};
await createBookingScenario(scenarioData);
await mockCalendarToHaveNoBusySlots("googlecalendar");
const schedule = await availableSlotsService.getAvailableSlots({
input: getTestScheduleInput({ yesterdayDateString, plus5DateString }),
});
// All slots should be available as the reservation is expired
expect(schedule).toHaveTimeSlots(
[
"04:00:00.000Z",
"04:45:00.000Z",
"05:30:00.000Z",
"06:15:00.000Z",
"07:00:00.000Z",
"07:45:00.000Z",
"08:30:00.000Z",
"09:15:00.000Z",
"10:00:00.000Z",
"10:45:00.000Z",
"11:30:00.000Z",
],
{
dateString: plus2DateString,
}
);
});
test("should show correct attendee count as per reserved slots", async () => {
// In IST timezone, it is 2024-05-31T07:00:00
vi.setSystemTime("2024-05-31T01:30:00Z");
const yesterdayDateString = "2024-05-30";
const plus2DateString = "2024-06-02";
const plus5DateString = "2024-06-05";
const scenarioData: ScheduleScenario = {
...getBaseScenarioData(),
eventTypes: [
{
...getBaseScenarioData().eventTypes[0],
seatsPerTimeSlot: 5, // Total seats available
},
],
selectedSlots: [
{
eventTypeId: 1,
userId: 101,
slotUtcStartDate: new Date(`${plus2DateString}T04:00:00.000Z`),
slotUtcEndDate: new Date(`${plus2DateString}T04:45:00.000Z`),
uid: "other-user-uid",
releaseAt: new Date(Date.now() + 1000 * 60 * 60), // 1 hour from now
isSeat: true,
},
],
};
await createBookingScenario(scenarioData);
await mockCalendarToHaveNoBusySlots("googlecalendar");
const schedule = await availableSlotsService.getAvailableSlots({
input: getTestScheduleInput({ yesterdayDateString, plus5DateString }),
});
// The 4:00 slot should show 1 seat taken
const slot = schedule.slots[plus2DateString].find(
(slot) => slot.time === `${plus2DateString}T04:00:00.000Z`
);
expect(slot).toBeDefined();
expect(slot?.attendees).toBe(1);
});
test("should block slots even when reservation is for a different event type", async () => {
// In IST timezone, it is 2024-05-31T07:00:00
vi.setSystemTime("2024-05-31T01:30:00Z");
const yesterdayDateString = "2024-05-30";
const plus2DateString = "2024-06-02";
const plus5DateString = "2024-06-05";
const differentEventTypeId = 2;
const scenarioData: ScheduleScenario = {
...getBaseScenarioData(),
eventTypes: [
{
id: 1,
slotInterval: 45,
length: 45,
users: [{ id: 101 }],
},
{
id: differentEventTypeId,
slotInterval: 45,
length: 45,
users: [{ id: 101 }],
},
],
selectedSlots: [
{
eventTypeId: differentEventTypeId, // Different event type
userId: 101,
slotUtcStartDate: new Date(`${plus2DateString}T04:00:00.000Z`),
slotUtcEndDate: new Date(`${plus2DateString}T04:45:00.000Z`),
uid: "other-user-uid",
releaseAt: new Date(Date.now() + 1000 * 60 * 60), // 1 hour from now
},
],
};
await createBookingScenario(scenarioData);
await mockCalendarToHaveNoBusySlots("googlecalendar");
const schedule = await availableSlotsService.getAvailableSlots({
input: getTestScheduleInput({ yesterdayDateString, plus5DateString }),
});
// The 4:00 slot should still be unavailable even when the reservation is for a different event type
expect(schedule).toHaveTimeSlots(
[
// "04:00:00.000Z",
"04:45:00.000Z",
"05:30:00.000Z",
"06:15:00.000Z",
"07:00:00.000Z",
"07:45:00.000Z",
"08:30:00.000Z",
"09:15:00.000Z",
"10:00:00.000Z",
"10:45:00.000Z",
"11:30:00.000Z",
],
{
dateString: plus2DateString,
}
);
});
test("should clean up only expired slots", async () => {
// In IST timezone, it is 2024-05-31T07:00:00
vi.setSystemTime("2024-05-31T01:30:00Z");
const yesterdayDateString = "2024-05-30";
const plus2DateString = "2024-06-02";
const plus5DateString = "2024-06-05";
const bookerClientUid = "same-user-uid";
const expiredTime = new Date(Date.now() - 1000 * 60 * 60); // 1 hour ago (expired)
const notExpiredTime = new Date(Date.now() + 1000 * 60 * 60); // 1 hour from now (not expired)
const scenarioData: ScheduleScenario = {
...getBaseScenarioData(),
selectedSlots: [
// Will be deleted
{
eventTypeId: 1,
userId: 101,
slotUtcStartDate: new Date(`${plus2DateString}T04:00:00.000Z`),
slotUtcEndDate: new Date(`${plus2DateString}T04:45:00.000Z`),
uid: bookerClientUid,
releaseAt: expiredTime,
},
// Will be not deleted
{
eventTypeId: 1,
userId: 101,
slotUtcStartDate: new Date(`${plus2DateString}T05:00:00.000Z`),
slotUtcEndDate: new Date(`${plus2DateString}T05:45:00.000Z`),
uid: bookerClientUid,
releaseAt: notExpiredTime,
},
// Will be not deleted
{
eventTypeId: 1,
userId: 101,
slotUtcStartDate: new Date(`${plus2DateString}T06:00:00.000Z`),
slotUtcEndDate: new Date(`${plus2DateString}T06:45:00.000Z`),
uid: "another-user-uid",
releaseAt: notExpiredTime,
},
// Will be deleted
{
eventTypeId: 1,
userId: 101,
slotUtcStartDate: new Date(`${plus2DateString}T07:00:00.000Z`),
slotUtcEndDate: new Date(`${plus2DateString}T07:45:00.000Z`),
uid: "another-user-uid",
releaseAt: expiredTime,
},
],
};
await createBookingScenario(scenarioData);
await availableSlotsService.getAvailableSlots({
input: getTestScheduleInput({ yesterdayDateString, plus5DateString }),
ctx: {
req: {
cookies: {
uid: bookerClientUid,
},
} as IncomingMessage & { cookies: { uid: string } },
},
} satisfies GetScheduleOptions);
// Verify that both slots are cleaned up from DB for this event type
const remainingSlots = await prisma.selectedSlots.findMany({
where: {
userId: 101,
eventTypeId: 1,
},
});
// There are two unexpired slots
expect(remainingSlots).toHaveLength(2);
});
});
});