Files
calendar/packages/features/form-builder/testUtils.ts
T
Bailey PumfleetGitHubDevin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>amit@cal.com <samit91848@gmail.com>Alex van Andel
5bab2af500 chore: some minor QA fixes (#22727)
* Various fixes

* Remove tooltip

* another string change

* Fix width of custom event name modal to prevent overflow

* Booking questions fixes

* minor string fix

* checkbox alignment

* padding in reassign dialog

* fix: update FormBuilder tests for checkbox UI changes

- Updated test utilities to work with CheckboxField instead of BooleanToggleGroupField
- Fixed badge expectations to check for 'optional' instead of 'required'
- Updated dialog interaction methods to use checkbox.checked instead of button text
- All 13 FormBuilder tests now pass successfully

Fixes failing tests in PR #22727 caused by UI changes from toggle buttons to checkboxes for required field selection.

Co-Authored-By: amit@cal.com <samit91848@gmail.com>

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: amit@cal.com <samit91848@gmail.com>
Co-authored-by: Alex van Andel <me@alexvanandel.com>
2025-08-25 18:11:18 +09:00

283 lines
10 KiB
TypeScript

import { fireEvent, waitFor, screen, within } from "@testing-library/react";
import { vi } from "vitest";
import { getBookingFieldsWithSystemFields } from "@calcom/features/bookings/lib/getBookingFields";
import type { FormBuilder } from "./FormBuilder";
export interface FieldProps {
fieldType: string;
identifier: string;
label: string;
}
type FormBuilderProps = React.ComponentProps<typeof FormBuilder>;
export const mockProps: FormBuilderProps = {
formProp: "fields",
title: "FormBuilder Title",
description: "FormBuilder Description",
addFieldLabel: "Add Field",
disabled: false,
LockedIcon: false,
dataStore: { options: {} },
};
export const getLocationBookingField = () => {
const bookingFields = getBookingFieldsWithSystemFields({
bookingFields: [],
disableGuests: false,
disableBookingTitle: false,
customInputs: [],
metadata: {},
workflows: [],
});
const locationBookingField = bookingFields.find((field) => field.name === "location");
if (!locationBookingField) {
throw new Error("location booking field not found");
}
return locationBookingField;
};
export const setMockMatchMedia = () => {
Object.defineProperty(window, "matchMedia", {
value: vi.fn().mockImplementation((query) => ({
matches: false,
media: query,
onchange: null,
addEventListener: vi.fn(),
removeEventListener: vi.fn(),
dispatchEvent: vi.fn(),
})),
});
};
export const setMockIntersectionObserver = () => {
Object.defineProperty(window, "IntersectionObserver", {
value: vi.fn().mockImplementation(() => ({
observe: vi.fn(),
unobserve: vi.fn(),
disconnect: vi.fn(),
takeRecords: vi.fn(() => []),
})),
});
};
type TestingLibraryElement = ReturnType<typeof within>;
const getFieldDomElementInTheList = ({ identifier }: { identifier: string }) => {
return screen.getByTestId(`field-${identifier}`);
};
const queryFieldDomElementInTheList = ({ identifier }: { identifier: string }) => {
return screen.queryByTestId(`field-${identifier}`);
};
const getFieldInTheList = ({ identifier }: { identifier: string }) => {
const domElement = getFieldDomElementInTheList({ identifier });
return within(domElement);
};
const getEditDialogForm = () => {
const formBuilder = document.getElementById("form-builder");
if (!formBuilder) {
throw new Error("Form Builder not found");
}
return within(formBuilder);
};
export const pageObject = {
openAddFieldDialog: () => {
fireEvent.click(screen.getByTestId("add-field"));
return getEditDialogForm();
},
openEditFieldDialog: ({ identifier }: { identifier: string }) => {
fireEvent.click(getFieldInTheList({ identifier }).getByTestId("edit-field-action"));
return getEditDialogForm();
},
dialog: {
isFieldShowingAsRequired: ({ dialog }: { dialog: TestingLibraryElement }) => {
const checkbox = dialog.getByTestId("field-required") as HTMLInputElement;
return checkbox.checked;
},
makeFieldOptional: ({ dialog }: { dialog: TestingLibraryElement }) => {
const checkbox = dialog.getByTestId("field-required") as HTMLInputElement;
if (checkbox.checked) {
fireEvent.click(checkbox);
}
},
makeFieldRequired: ({ dialog }: { dialog: TestingLibraryElement }) => {
const checkbox = dialog.getByTestId("field-required") as HTMLInputElement;
if (!checkbox.checked) {
fireEvent.click(checkbox);
}
},
queryIdentifierInput: ({ dialog }: { dialog: TestingLibraryElement }) => {
return dialog.getByLabelText("identifier");
},
saveField: ({ dialog }: { dialog: ReturnType<typeof within> }) => {
fireEvent.click(dialog.getByTestId("field-add-save"));
},
openFieldTypeDropdown: ({ dialog }: { dialog: TestingLibraryElement }) => {
fireEvent.keyDown(dialog.getByTestId("test-field-type"), { key: "ArrowDown", code: "ArrowDown" });
},
fieldTypeDropdown: {
queryOptionForFieldType: ({
dialog,
fieldType,
}: {
dialog: TestingLibraryElement;
fieldType: string;
}) => {
const fieldTypeEl = within(dialog.getByTestId("test-field-type"));
return fieldTypeEl.queryByTestId(`select-option-${fieldType}`);
},
queryAllOptions: ({ dialog }: { dialog: TestingLibraryElement }) => {
const fieldTypeElementWithOptions = within(dialog.getByTestId("test-field-type").parentElement);
return fieldTypeElementWithOptions.queryAllByTestId(/^select-option-/);
},
},
selectFieldType: ({ dialog, fieldType }: { dialog: TestingLibraryElement; fieldType: string }) => {
pageObject.dialog.openFieldTypeDropdown({ dialog });
fireEvent.click(dialog.getByTestId(`select-option-${fieldType}`));
},
fillInFieldIdentifier: ({
dialog,
identifier,
}: {
dialog: TestingLibraryElement;
identifier: string;
}) => {
fireEvent.change(dialog.getAllByRole("textbox")[0], { target: { value: identifier } });
},
fillInFieldLabel: ({
dialog,
label,
fieldType,
}: {
dialog: TestingLibraryElement;
label: string;
fieldType: string;
}) => {
if (fieldType !== "boolean") {
fireEvent.change(dialog.getAllByRole("textbox")[1], { target: { value: label } });
}
},
close: ({ dialog }: { dialog: TestingLibraryElement }) => {
fireEvent.click(dialog.getByTestId("dialog-rejection"));
},
},
queryDeleteButton: ({ identifier }: { identifier: string }) => {
const field = getFieldInTheList({ identifier });
return field.queryByTestId("delete-field-action");
},
getDeleteButton: ({ identifier }: { identifier: string }) => {
const field = getFieldInTheList({ identifier });
return field.queryByTestId("delete-field-action");
},
deleteField: ({ identifier }: { identifier: string }) => {
const field = getFieldInTheList({ identifier });
fireEvent.click(field.getByTestId("delete-field-action"));
},
queryToggleButton: ({ identifier }: { identifier: string }) => {
const field = getFieldInTheList({ identifier });
return field.queryByTestId("toggle-field");
},
getToggleButton: ({ identifier }: { identifier: string }) => {
const field = getFieldInTheList({ identifier });
return field.getByTestId("toggle-field");
},
toggleField: ({ identifier }: { identifier: string }) => {
const field = getFieldInTheList({ identifier });
fireEvent.click(field.getByTestId("toggle-field"));
},
};
export const verifier = {
verifyFieldAddition: async (props: FieldProps) => {
const dialog = pageObject.openAddFieldDialog();
pageObject.dialog.selectFieldType({ dialog, fieldType: props.fieldType });
pageObject.dialog.fillInFieldIdentifier({ dialog, identifier: props.identifier });
pageObject.dialog.fillInFieldLabel({ dialog, label: props.label, fieldType: props.fieldType });
pageObject.dialog.saveField({ dialog: getEditDialogForm() });
await waitFor(() => {
expect(getFieldDomElementInTheList({ identifier: props.identifier })).toBeInTheDocument();
});
},
verifyIdentifierChange: async (props: { newIdentifier: string; existingIdentifier: string }) => {
const dialog = pageObject.openEditFieldDialog({ identifier: props.existingIdentifier });
pageObject.dialog.fillInFieldIdentifier({ dialog, identifier: props.newIdentifier });
pageObject.dialog.saveField({ dialog });
await waitFor(() => {
expect(getFieldDomElementInTheList({ identifier: props.newIdentifier })).toBeInTheDocument();
expect(queryFieldDomElementInTheList({ identifier: props.existingIdentifier })).not.toBeInTheDocument();
});
},
verifyFieldDeletion: async ({ identifier }: { identifier: string }) => {
pageObject.deleteField({ identifier });
await waitFor(() => {
expect(queryFieldDomElementInTheList({ identifier })).not.toBeInTheDocument();
});
},
verifyFieldToggle: async ({ identifier }: { identifier: string }) => {
pageObject.toggleField({ identifier });
await waitFor(() => {
expect(screen.queryByText(/hidden/i)).toBeInTheDocument();
});
},
verifyThatFieldCanBeMarkedOptional: async ({ identifier }: { identifier: string }) => {
expectScenario.toHaveRequiredBadge({ identifier });
const editDialogForm = pageObject.openEditFieldDialog({ identifier });
pageObject.dialog.makeFieldOptional({ dialog: editDialogForm });
pageObject.dialog.saveField({ dialog: editDialogForm });
await waitFor(() => {
expect(screen.getByTestId("optional")).toBeInTheDocument();
});
},
};
export const expectScenario = {
toHaveFieldTypeDropdownDisabled: ({ dialog }: { dialog: TestingLibraryElement }) => {
pageObject.dialog.openFieldTypeDropdown({ dialog });
const allOptions = pageObject.dialog.fieldTypeDropdown.queryAllOptions({ dialog });
if (allOptions.length > 0) {
throw new Error(`Field type dropdown should be disabled`);
}
},
toHaveIdentifierChangeDisabled: ({ dialog }: { dialog: TestingLibraryElement }) => {
const identifierInput = pageObject.dialog.queryIdentifierInput({ dialog });
expect(identifierInput.disabled).toBe(true);
},
toHaveRequirablityToggleDisabled: ({ dialog }: { dialog: TestingLibraryElement }) => {
const checkbox = dialog.getByTestId("field-required") as HTMLInputElement;
expect(checkbox.disabled).toBe(true);
},
toHaveLabelChangeAllowed: ({ dialog }: { dialog: TestingLibraryElement }) => {
const labelInput = dialog.getByLabelText("label");
expect(labelInput.disabled).toBe(false);
},
toNotHaveDeleteButton: ({ identifier }: { identifier: string }) => {
expect(pageObject.queryDeleteButton({ identifier })).toBeNull();
},
toNotHaveToggleButton: ({ identifier }: { identifier: string }) => {
expect(pageObject.queryToggleButton({ identifier })).toBeNull();
},
toHaveSourceBadge: ({ identifier, sourceLabel }: { identifier: string; sourceLabel: string }) => {
const field = getFieldInTheList({ identifier });
expect(field.getByText(sourceLabel)).not.toBeNull();
},
toNotHaveOptionalBadge: ({ identifier }: { identifier: string }) => {
const field = getFieldInTheList({ identifier });
expect(field.queryByTestId("optional")).toBeNull();
},
toHaveRequiredBadge: ({ identifier }: { identifier: string }) => {
const field = getFieldInTheList({ identifier });
expect(field.getByText("required")).not.toBeNull();
},
};