* fix: gracefully handle calendar failures when bypassBusyCalendarTimes is enabled - When _bypassCalendarBusyTimes parameter is true and third-party calendar fetching fails - System now falls back to internal bookings only instead of throwing error - Maintains existing error behavior when bypass is disabled Co-Authored-By: morgan@cal.com <morgan@cal.com> * feat: add _silentCalendarFailures parameter to handle calendar failures gracefully - Add silentlyHandleCalendarFailures parameter to getBusyTimes service - Add _silentCalendarFailures parameter to getUserAvailability schema - Add _silentCalendarFailures parameter to tRPC slots endpoint - Add _silentCalendarFailures parameter to API v2 slots/available endpoint - Parameter attempts calendar calls first, falls back silently on failure - Different from bypassCalendarBusyTimes which skips calendar calls entirely Co-Authored-By: morgan@cal.com <morgan@cal.com> * refactor: remove bypassBusyCalendarTimes logic from error handling - Keep only silentlyHandleCalendarFailures logic in getBusyTimes error handling - Remove redundant bypassBusyCalendarTimes condition from calendar failure handling - Maintain existing bypassBusyCalendarTimes logic that skips calendar calls entirely Co-Authored-By: morgan@cal.com <morgan@cal.com> * feat: add silentlyHandleCalendarFailures prop to Booker atom - Pass silentlyHandleCalendarFailures prop from BookerPlatformWrapper to useAvailableSlots - Forward prop as _silentCalendarFailures parameter to API v2 slots/available endpoint - Complete the parameter flow from Booker atom to underlying service layer - Enables silent handling of calendar provider failures in Booker component Co-Authored-By: morgan@cal.com <morgan@cal.com> * chore: fix type and bump library * chore: bump library --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: morgan@cal.com <morgan@cal.com> Co-authored-by: Somay Chauhan <somaychauhan98@gmail.com> Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com>
403 lines
14 KiB
TypeScript
403 lines
14 KiB
TypeScript
import type { Booking, EventType } from "@prisma/client";
|
|
import type { Prisma } from "@prisma/client";
|
|
|
|
import dayjs from "@calcom/dayjs";
|
|
import { getBusyCalendarTimes } from "@calcom/lib/CalendarManager";
|
|
import { subtract } from "@calcom/lib/date-ranges";
|
|
import { stringToDayjs } from "@calcom/lib/dayjs";
|
|
import { intervalLimitKeyToUnit } from "@calcom/lib/intervalLimits/intervalLimit";
|
|
import type { IntervalLimit } from "@calcom/lib/intervalLimits/intervalLimitSchema";
|
|
import logger from "@calcom/lib/logger";
|
|
import { getPiiFreeBooking } from "@calcom/lib/piiFreeData";
|
|
import { withReporting } from "@calcom/lib/sentryWrapper";
|
|
import { performance } from "@calcom/lib/server/perfObserver";
|
|
import type { BookingRepository } from "@calcom/lib/server/repository/booking";
|
|
import prisma from "@calcom/prisma";
|
|
import type { SelectedCalendar } from "@calcom/prisma/client";
|
|
import { BookingStatus } from "@calcom/prisma/enums";
|
|
import type { EventBusyDetails } from "@calcom/types/Calendar";
|
|
import type { CredentialForCalendarService } from "@calcom/types/Credential";
|
|
|
|
import { getDefinedBufferTimes } from "../features/eventtypes/lib/getDefinedBufferTimes";
|
|
|
|
export interface IBusyTimesService {
|
|
bookingRepo: BookingRepository;
|
|
}
|
|
|
|
export class BusyTimesService {
|
|
constructor(public readonly dependencies: IBusyTimesService) {}
|
|
|
|
async _getBusyTimes(params: {
|
|
credentials: CredentialForCalendarService[];
|
|
userId: number;
|
|
userEmail: string;
|
|
username: string;
|
|
eventTypeId?: number;
|
|
startTime: string;
|
|
beforeEventBuffer?: number;
|
|
afterEventBuffer?: number;
|
|
endTime: string;
|
|
selectedCalendars: SelectedCalendar[];
|
|
seatedEvent?: boolean;
|
|
rescheduleUid?: string | null;
|
|
duration?: number | null;
|
|
currentBookings?:
|
|
| (Pick<Booking, "id" | "uid" | "userId" | "startTime" | "endTime" | "title"> & {
|
|
eventType: Pick<
|
|
EventType,
|
|
"id" | "beforeEventBuffer" | "afterEventBuffer" | "seatsPerTimeSlot"
|
|
> | null;
|
|
_count?: {
|
|
seatsReferences: number;
|
|
};
|
|
})[]
|
|
| null;
|
|
bypassBusyCalendarTimes: boolean;
|
|
silentlyHandleCalendarFailures?: boolean;
|
|
shouldServeCache?: boolean;
|
|
}) {
|
|
const {
|
|
credentials,
|
|
userId,
|
|
userEmail,
|
|
username,
|
|
eventTypeId,
|
|
startTime,
|
|
endTime,
|
|
beforeEventBuffer,
|
|
afterEventBuffer,
|
|
selectedCalendars,
|
|
seatedEvent,
|
|
rescheduleUid,
|
|
duration,
|
|
bypassBusyCalendarTimes = false,
|
|
silentlyHandleCalendarFailures = false,
|
|
shouldServeCache,
|
|
} = params;
|
|
|
|
logger.silly(
|
|
`Checking Busy time from Cal Bookings in range ${startTime} to ${endTime} for input ${JSON.stringify({
|
|
userId,
|
|
eventTypeId,
|
|
status: BookingStatus.ACCEPTED,
|
|
})}`
|
|
);
|
|
|
|
/**
|
|
* A user is considered busy within a given time period if there
|
|
* is a booking they own OR attend.
|
|
*
|
|
* Performs a query for all bookings where:
|
|
* - The given booking is owned by this user, or..
|
|
* - The current user has a different booking at this time he/she attends
|
|
*
|
|
* See further discussion within this GH issue:
|
|
* https://github.com/calcom/cal.com/issues/6374
|
|
*
|
|
* NOTE: Changes here will likely require changes to some mocking
|
|
* logic within getSchedule.test.ts:addBookings
|
|
*/
|
|
performance.mark("prismaBookingGetStart");
|
|
|
|
const startTimeDate =
|
|
rescheduleUid && duration
|
|
? dayjs(startTime).subtract(duration, "minute").toDate()
|
|
: new Date(startTime);
|
|
const endTimeDate =
|
|
rescheduleUid && duration ? dayjs(endTime).add(duration, "minute").toDate() : new Date(endTime);
|
|
|
|
// to also get bookings that are outside of start and end time, but the buffer falls within the start and end time
|
|
const definedBufferTimes = getDefinedBufferTimes();
|
|
const maxBuffer = definedBufferTimes[definedBufferTimes.length - 1];
|
|
const startTimeAdjustedWithMaxBuffer = dayjs(startTimeDate).subtract(maxBuffer, "minute").toDate();
|
|
const endTimeAdjustedWithMaxBuffer = dayjs(endTimeDate).add(maxBuffer, "minute").toDate();
|
|
|
|
// INFO: Refactored to allow this method to take in a list of current bookings for the user.
|
|
// Will keep support for retrieving a user's bookings if the caller does not already supply them.
|
|
// This function is called from multiple places but we aren't refactoring all of them at this moment
|
|
// to avoid potential side effects.
|
|
let bookings = params.currentBookings;
|
|
|
|
if (!bookings) {
|
|
const bookingRepo = this.dependencies.bookingRepo;
|
|
bookings = await bookingRepo.findAllExistingBookingsForEventTypeBetween({
|
|
userIdAndEmailMap: new Map([[userId, userEmail]]),
|
|
eventTypeId,
|
|
startDate: startTimeAdjustedWithMaxBuffer,
|
|
endDate: endTimeAdjustedWithMaxBuffer,
|
|
seatedEvent,
|
|
});
|
|
}
|
|
|
|
const bookingSeatCountMap: { [x: string]: number } = {};
|
|
const busyTimes = bookings.reduce((aggregate: EventBusyDetails[], booking) => {
|
|
const { id, startTime, endTime, eventType, title, ...rest } = booking;
|
|
|
|
const minutesToBlockBeforeEvent = (eventType?.beforeEventBuffer || 0) + (afterEventBuffer || 0);
|
|
const minutesToBlockAfterEvent = (eventType?.afterEventBuffer || 0) + (beforeEventBuffer || 0);
|
|
|
|
if (rest._count?.seatsReferences) {
|
|
const bookedAt = `${dayjs(startTime).utc().format()}<>${dayjs(endTime).utc().format()}`;
|
|
bookingSeatCountMap[bookedAt] = bookingSeatCountMap[bookedAt] || 0;
|
|
bookingSeatCountMap[bookedAt]++;
|
|
// Seat references on the current event are non-blocking until the event is fully booked.
|
|
if (
|
|
// there are still seats available.
|
|
bookingSeatCountMap[bookedAt] < (eventType?.seatsPerTimeSlot || 1) &&
|
|
// and this is the seated event, other event types should be blocked.
|
|
eventTypeId === eventType?.id
|
|
) {
|
|
// then we ONLY add the before/after buffer times as busy times.
|
|
if (minutesToBlockBeforeEvent) {
|
|
aggregate.push({
|
|
start: dayjs(startTime).subtract(minutesToBlockBeforeEvent, "minute").toDate(),
|
|
end: dayjs(startTime).toDate(), // The event starts after the buffer
|
|
});
|
|
}
|
|
if (minutesToBlockAfterEvent) {
|
|
aggregate.push({
|
|
start: dayjs(endTime).toDate(), // The event ends before the buffer
|
|
end: dayjs(endTime).add(minutesToBlockAfterEvent, "minute").toDate(),
|
|
});
|
|
}
|
|
return aggregate;
|
|
}
|
|
// if it does get blocked at this point; we remove the bookingSeatCountMap entry
|
|
// doing this allows using the map later to remove the ranges from calendar busy times.
|
|
delete bookingSeatCountMap[bookedAt];
|
|
}
|
|
// rescheduling the same booking to the same time should be possible. Why?
|
|
if (rest.uid === rescheduleUid) {
|
|
return aggregate;
|
|
}
|
|
aggregate.push({
|
|
start: dayjs(startTime).subtract(minutesToBlockBeforeEvent, "minute").toDate(),
|
|
end: dayjs(endTime).add(minutesToBlockAfterEvent, "minute").toDate(),
|
|
title,
|
|
source: `eventType-${eventType?.id}-booking-${id}`,
|
|
});
|
|
return aggregate;
|
|
}, []);
|
|
|
|
logger.debug(
|
|
`Busy Time from Cal Bookings ${JSON.stringify({
|
|
busyTimes,
|
|
bookings: bookings?.map((booking) => getPiiFreeBooking(booking)),
|
|
numCredentials: credentials?.length,
|
|
})}`
|
|
);
|
|
performance.mark("prismaBookingGetEnd");
|
|
performance.measure(`prisma booking get took $1'`, "prismaBookingGetStart", "prismaBookingGetEnd");
|
|
if (credentials?.length > 0 && !bypassBusyCalendarTimes) {
|
|
const startConnectedCalendarsGet = performance.now();
|
|
|
|
const calendarBusyTimesQuery = await getBusyCalendarTimes(
|
|
credentials,
|
|
startTime,
|
|
endTime,
|
|
selectedCalendars,
|
|
shouldServeCache
|
|
);
|
|
|
|
if (!calendarBusyTimesQuery.success) {
|
|
if (silentlyHandleCalendarFailures) {
|
|
logger.warn(
|
|
`Calendar busy times fetch failed but handling silently due to silentlyHandleCalendarFailures flag for user ${username}`,
|
|
{
|
|
selectedCalendarIds: selectedCalendars.map((calendar) => calendar.id),
|
|
}
|
|
);
|
|
} else {
|
|
throw new Error(
|
|
`Failed to fetch busy calendar times for selected calendars ${selectedCalendars.map(
|
|
(calendar) => calendar.id
|
|
)}`
|
|
);
|
|
}
|
|
} else {
|
|
const calendarBusyTimes = calendarBusyTimesQuery.data;
|
|
const endConnectedCalendarsGet = performance.now();
|
|
logger.debug(
|
|
`Connected Calendars get took ${
|
|
endConnectedCalendarsGet - startConnectedCalendarsGet
|
|
} ms for user ${username}`,
|
|
JSON.stringify({
|
|
eventTypeId,
|
|
startTimeDate,
|
|
endTimeDate,
|
|
calendarBusyTimes,
|
|
})
|
|
);
|
|
|
|
const openSeatsDateRanges = Object.keys(bookingSeatCountMap).map((key) => {
|
|
const [start, end] = key.split("<>");
|
|
return {
|
|
start: dayjs(start),
|
|
end: dayjs(end),
|
|
};
|
|
});
|
|
|
|
if (rescheduleUid) {
|
|
const originalRescheduleBooking = bookings.find((booking) => booking.uid === rescheduleUid);
|
|
if (originalRescheduleBooking) {
|
|
openSeatsDateRanges.push({
|
|
start: dayjs(originalRescheduleBooking.startTime),
|
|
end: dayjs(originalRescheduleBooking.endTime),
|
|
});
|
|
}
|
|
}
|
|
|
|
const result = subtract(
|
|
calendarBusyTimes.map((value) => ({
|
|
...value,
|
|
end: dayjs(value.end),
|
|
start: dayjs(value.start),
|
|
})),
|
|
openSeatsDateRanges
|
|
);
|
|
|
|
busyTimes.push(
|
|
...result.map((busyTime) => ({
|
|
...busyTime,
|
|
start: busyTime.start.subtract(afterEventBuffer || 0, "minute").toDate(),
|
|
end: busyTime.end.add(beforeEventBuffer || 0, "minute").toDate(),
|
|
}))
|
|
);
|
|
}
|
|
|
|
/*
|
|
// TODO: Disabled until we can filter Zoom events by date. Also this is adding too much latency.
|
|
const videoBusyTimes = (await getBusyVideoTimes(credentials)).filter(notEmpty);
|
|
console.log("videoBusyTimes", videoBusyTimes);
|
|
busyTimes.push(...videoBusyTimes);
|
|
*/
|
|
} else {
|
|
logger.warn(`No credentials found for user ${userId}`, {
|
|
selectedCalendarIds: selectedCalendars.map((calendar) => calendar.id),
|
|
});
|
|
}
|
|
logger.debug(
|
|
"getBusyTimes:",
|
|
JSON.stringify({
|
|
allBusyTimes: busyTimes,
|
|
})
|
|
);
|
|
return busyTimes;
|
|
}
|
|
|
|
getBusyTimes = withReporting(this._getBusyTimes.bind(this), "getBusyTimes");
|
|
|
|
getStartEndDateforLimitCheck(
|
|
startDate: string,
|
|
endDate: string,
|
|
bookingLimits?: IntervalLimit | null,
|
|
durationLimits?: IntervalLimit | null
|
|
) {
|
|
const startTimeAsDayJs = stringToDayjs(startDate);
|
|
const endTimeAsDayJs = stringToDayjs(endDate);
|
|
|
|
let limitDateFrom = stringToDayjs(startDate);
|
|
let limitDateTo = stringToDayjs(endDate);
|
|
|
|
// expand date ranges by absolute minimum required to apply limits
|
|
// (yearly limits are handled separately for performance)
|
|
for (const key of ["PER_MONTH", "PER_WEEK", "PER_DAY"] as Exclude<keyof IntervalLimit, "PER_YEAR">[]) {
|
|
if (bookingLimits?.[key] || durationLimits?.[key]) {
|
|
const unit = intervalLimitKeyToUnit(key);
|
|
limitDateFrom = dayjs.min(limitDateFrom, startTimeAsDayJs.startOf(unit));
|
|
limitDateTo = dayjs.max(limitDateTo, endTimeAsDayJs.endOf(unit));
|
|
}
|
|
}
|
|
|
|
return { limitDateFrom, limitDateTo };
|
|
}
|
|
|
|
async getBusyTimesForLimitChecks(params: {
|
|
userIds: number[];
|
|
eventTypeId: number;
|
|
startDate: string;
|
|
endDate: string;
|
|
rescheduleUid?: string | null;
|
|
bookingLimits?: IntervalLimit | null;
|
|
durationLimits?: IntervalLimit | null;
|
|
}) {
|
|
const { userIds, eventTypeId, startDate, endDate, rescheduleUid, bookingLimits, durationLimits } = params;
|
|
|
|
performance.mark("getBusyTimesForLimitChecksStart");
|
|
|
|
let busyTimes: EventBusyDetails[] = [];
|
|
|
|
if (!bookingLimits && !durationLimits) {
|
|
return busyTimes;
|
|
}
|
|
|
|
const { limitDateFrom, limitDateTo } = this.getStartEndDateforLimitCheck(
|
|
startDate,
|
|
endDate,
|
|
bookingLimits,
|
|
durationLimits
|
|
);
|
|
|
|
logger.silly(
|
|
`Fetch limit checks bookings in range ${limitDateFrom} to ${limitDateTo} for input ${JSON.stringify({
|
|
eventTypeId,
|
|
status: BookingStatus.ACCEPTED,
|
|
})}`
|
|
);
|
|
|
|
const where: Prisma.BookingWhereInput = {
|
|
userId: {
|
|
in: userIds,
|
|
},
|
|
eventTypeId,
|
|
status: BookingStatus.ACCEPTED,
|
|
// FIXME: bookings that overlap on one side will never be counted
|
|
startTime: {
|
|
gte: limitDateFrom.toDate(),
|
|
},
|
|
endTime: {
|
|
lte: limitDateTo.toDate(),
|
|
},
|
|
};
|
|
|
|
if (rescheduleUid) {
|
|
where.NOT = {
|
|
uid: rescheduleUid,
|
|
};
|
|
}
|
|
|
|
const bookings = await prisma.booking.findMany({
|
|
where,
|
|
select: {
|
|
id: true,
|
|
startTime: true,
|
|
endTime: true,
|
|
eventType: {
|
|
select: {
|
|
id: true,
|
|
},
|
|
},
|
|
title: true,
|
|
userId: true,
|
|
},
|
|
});
|
|
|
|
busyTimes = bookings.map(({ id, startTime, endTime, eventType, title, userId }) => ({
|
|
start: dayjs(startTime).toDate(),
|
|
end: dayjs(endTime).toDate(),
|
|
title,
|
|
source: `eventType-${eventType?.id}-booking-${id}`,
|
|
userId,
|
|
}));
|
|
|
|
logger.silly(`Fetch limit checks bookings for eventId: ${eventTypeId} ${JSON.stringify(busyTimes)}`);
|
|
performance.mark("getBusyTimesForLimitChecksEnd");
|
|
performance.measure(
|
|
`prisma booking get for limits took $1'`,
|
|
"getBusyTimesForLimitChecksStart",
|
|
"getBusyTimesForLimitChecksEnd"
|
|
);
|
|
return busyTimes;
|
|
}
|
|
}
|