Files
calendar/companion/hooks/useActiveBookingFilter.tsx
T
Dhairyashil ShindeandGitHub 2a84d46fe9 feat(companion): add Biome for linting and formatting (#26214)
* feat(companion): add ESLint with Prettier integration

- Add ESLint with eslint-config-expo/flat for SDK 55
- Integrate Prettier via eslint-plugin-prettier
- Configure environment-specific settings for Node.js config files and browser extension
- Add lint script to package.json
- Fix Prettier formatting issues in AvailabilityTab.tsx and types/index.ts

* fix(companion): use bun lockfile instead of npm

- Remove package-lock.json that was accidentally committed
- Update bun.lock with ESLint dependencies

* fix(companion): fix all ESLint errors (16 total)

- Fix unescaped entities in JSX (react/no-unescaped-entities):
  - app/(tabs)/(event-types)/index.tsx: escape quotes in delete confirmation
  - components/LoginScreen.tsx: escape apostrophe in "Don't have an account"
  - components/NetworkStatusBanner.tsx: escape apostrophes in offline message
  - components/booking-modals/BookingModals.tsx: escape apostrophe in rejection message
  - components/event-type-detail/tabs/AdvancedTab.tsx: escape quotes and apostrophes
  - components/screens/AvailabilityListScreen.tsx: escape quotes in delete confirmation

- Fix react-hooks/rules-of-hooks in RescheduleScreen.tsx:
  - Move useMemo calls before conditional early return to ensure hooks
    are called in the same order on every render

* fix(companion): fix all ESLint warnings (68 total)

- Fix import/no-named-as-default warnings by using named imports
- Fix @typescript-eslint/no-unused-vars warnings by removing unused imports/variables
- Fix react-hooks/exhaustive-deps warnings with eslint-disable comments
- Convert unused error variables in catch blocks to bare catch
- Remove unused imports (useRouter, Alert, useSafeAreaInsets, etc.)
- All ESLint checks now pass with 0 errors and 0 warnings

* feat(companion): add pre-commit lint check with --max-warnings=0

- Add companion lint check to root lint-staged.config.mjs
- Runs 'bun run lint -- --fix --max-warnings=0' for companion files
- Follows same pattern as apps/packages lint check
- Supports SKIP_WARNINGS=1 env var to bypass warning check if needed
- Commit will fail if any ESLint errors or warnings are present

* fix(companion): restore state variables and imports removed during ESLint fixes

- Restore locationAddress, locationLink, locationPhone state variables in event-type-detail.tsx (still used in fetchEventTypeData)
- Restore Alert import in BookingListScreen.tsx (still used for report booking)
- Add eslint-disable comments for the restored state variables since they're only used by setters

* test

* test

* fix eslint pre commit check

* fix: In React Native, HTML entities like ' are rendered literally as text, not decoded like in web browsers

* refactor(companion): remove ESLint and Prettier config in preparation for Biome

* feat(companion): add Biome for linting and formatting

- Install @biomejs/biome with exact version pinning (2.3.10)
- Add biome.json with formatting settings matching previous Prettier config
- Add lint, format, check, and check:ci scripts to package.json
- Update lint-staged to use Biome instead of Prettier
- Remove Prettier and prettier-plugin-tailwindcss dependencies
- Delete .prettierrc.js configuration file

* style(companion): apply Biome formatting and fix lint-staged config

- Update lint-staged to use 'biome format' instead of 'biome check'
  (pre-commit should only format, not lint)
- Apply Biome formatting to all companion files

* feat(companion): configure Biome for strict linting with pre-commit enforcement

- Apply Biome unsafe fixes (unused imports, optional chaining, etc.)
- Configure biome.json rules to disable overly strict rules for existing code:
  - noExplicitAny, noArrayIndexKey, useIterableCallbackReturn (suspicious)
  - useExhaustiveDependencies, noUnusedFunctionParameters (correctness)
  - noStaticOnlyClass (complexity)
  - noNonNullAssertion (style)
  - noStaticElementInteractions (a11y)
- Update lint-staged to use 'biome check --write --error-on-warnings'
  (pre-commit now runs both formatting AND linting, fails on warnings)

* fix(companion): enable noNonNullAssertion rule and fix all violations

- Enable noNonNullAssertion rule in biome.json (set to 'error')
- Fix 7 violations across the codebase:
  - hooks/useBookings.ts: Add runtime check before API call
  - hooks/useEventTypes.ts: Add runtime check before API call
  - hooks/useSchedules.ts: Add runtime check before API call
  - extension/entrypoints/content.ts: Add null checks for cache and getAttribute

* fix(companion): enable noStaticOnlyClass and noStaticElementInteractions rules

- Enable noStaticOnlyClass rule in biome.json
- Enable noStaticElementInteractions rule in biome.json
- Convert CalComAPIService from static class to object literal pattern
- Convert WebAuthService from static class to object literal pattern
- Add role="tooltip" to Tooltip.web.tsx for accessibility

* fix(companion): resolve TypeScript type errors in useEffect dependencies and remove unused state property

* fix(companion): enable noUnusedFunctionParameters rule and fix 9 violations

* fix(companion): enable noUnusedVariables rule and fix 4 violations

* fix(companion): enable useIterableCallbackReturn rule and fix 11 violations

* fix(companion): enable useExhaustiveDependencies rule and fix 7 violations

* fix(companion): enable noArrayIndexKey rule and fix 10 violations

* fix(companion): enable noExplicitAny rule and fix all violations

- Enable noExplicitAny rule in biome.json
- Replace any types with proper specific types across all files:
  - calcom.ts: Add proper type definitions for API responses and inputs
  - event-types.types.ts: Add BookingLimitsCount, BookingLimitsDuration, ConfirmationPolicy types
  - buildPartialUpdatePayload.ts: Fix type mismatches for booking limits functions
  - booking-actions.ts: Add proper types for booking action handlers
  - BookingDetailScreen.tsx, MarkNoShowScreen.tsx: Add types for attendee data
  - AvailabilityListItem.ios.tsx, BookingListItem.ios.tsx: Import SFSymbols7_0 type
  - extension/content.ts: Fix slot types and __cleanup invocation issues
- Remove unused imports and interfaces

* address cubics comments

* add useHookAtTopLevel rule
2025-12-27 08:19:53 -03:00

136 lines
3.7 KiB
TypeScript

import { useCallback, useMemo, useState } from "react";
import type { NativeSyntheticEvent } from "react-native";
import type { BookingFilters } from "./useBookings";
export type BookingFilter = "upcoming" | "unconfirmed" | "past" | "cancelled";
export interface BookingFilterOption {
key: BookingFilter;
label: string;
}
const FILTER_OPTIONS: BookingFilterOption[] = [
{ key: "upcoming", label: "Upcoming" },
{ key: "unconfirmed", label: "Unconfirmed" },
{ key: "past", label: "Past" },
{ key: "cancelled", label: "Cancelled" },
];
/**
* Hook to manage active booking filter state and provide filter-related utilities.
*
* Features:
* - Manages active filter state
* - Provides filter options and labels for UI components
* - Converts filter selection to API-compatible parameters
* - Handles segmented control integration
* - Supports change callbacks for dependent filter cleanup
*
* @param initialFilter - Initial filter value (defaults to "upcoming")
* @param onFilterChange - Optional callback invoked when filter changes
* @returns Object containing filter state, handlers, and computed values
*
* @example
* ```tsx
* const {
* activeFilter,
* filterLabels,
* activeIndex,
* filterParams,
* handleFilterChange,
* handleSegmentChange,
* } = useActiveBookingFilter("upcoming", () => {
* // Clear dependent filters like search query, event type filter, etc.
* setSearchQuery("");
* setSelectedEventTypeId(null);
* });
*
* // Use with React Query
* const { data: bookings } = useBookings(filterParams);
*
* // Use with SegmentedControl
* <SegmentedControl
* values={filterLabels}
* selectedIndex={activeIndex}
* onChange={handleSegmentChange}
* />
* ```
*/
export function useActiveBookingFilter(
initialFilter: BookingFilter = "upcoming",
onFilterChange?: (filter: BookingFilter) => void
) {
const [activeFilter, setActiveFilter] = useState<BookingFilter>(initialFilter);
/**
* Converts the active filter to API-compatible query parameters
*/
const filterParams = useMemo<BookingFilters>(() => {
switch (activeFilter) {
case "upcoming":
return { status: ["upcoming"], limit: 50 };
case "unconfirmed":
return { status: ["unconfirmed"], limit: 50 };
case "past":
return { status: ["past"], limit: 100 };
case "cancelled":
return { status: ["cancelled"], limit: 100 };
default:
return { status: ["upcoming"], limit: 50 };
}
}, [activeFilter]);
/**
* Array of filter labels for UI components (e.g., SegmentedControl)
*/
const filterLabels = useMemo(() => FILTER_OPTIONS.map((option) => option.label), []);
/**
* Current active filter index for UI components
*/
const activeIndex = useMemo(
() => FILTER_OPTIONS.findIndex((option) => option.key === activeFilter),
[activeFilter]
);
/**
* Changes the active filter and invokes the optional callback
*/
const handleFilterChange = useCallback(
(filter: BookingFilter) => {
setActiveFilter(filter);
onFilterChange?.(filter);
},
[onFilterChange]
);
/**
* Handler for React Native SegmentedControl onChange event
*/
const handleSegmentChange = useCallback(
(event: NativeSyntheticEvent<{ selectedSegmentIndex: number }>) => {
const { selectedSegmentIndex } = event.nativeEvent;
const selectedFilter = FILTER_OPTIONS[selectedSegmentIndex];
if (selectedFilter) {
handleFilterChange(selectedFilter.key);
}
},
[handleFilterChange]
);
return {
// State
activeFilter,
// Computed values
filterOptions: FILTER_OPTIONS,
filterLabels,
activeIndex,
filterParams,
// Handlers
handleFilterChange,
handleSegmentChange,
};
}