Files
calendar/apps/web/modules/ee/teams/components/EditMemberSheet.test.tsx
T
Benny JooGitHubbenny@cal.com <sldisek783@gmail.com>benny@cal.com <sldisek783@gmail.com>benny@cal.com <sldisek783@gmail.com>benny@cal.com <sldisek783@gmail.com>benny@cal.com <sldisek783@gmail.com>benny@cal.com <sldisek783@gmail.com>Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
8afe87ff75 refactor: Move trpc-dependent components from features to web [1] (#25859)
* refactor: migrate UnconfirmedBookingBadge from features to apps/web

Move UnconfirmedBookingBadge.tsx from packages/features/bookings/ to
apps/web/modules/bookings/components/ as part of the architectural
refactor to remove trpc client imports from the features layer.

Also removes unused preserveBookingsQueryParams function from Navigation.tsx.

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* refactor: move shell navigation and badges to apps/web

Move shell navigation components and trpc-using badges from
packages/features to apps/web/modules to fix circular dependency:

- Move navigation folder to apps/web/modules/shell/navigation/
- Move TeamInviteBadge.tsx to apps/web/modules/shell/
- Create Shell wrapper in apps/web that provides MobileNavigationContainer
- Update all Shell imports in apps/web to use the new wrapper
- Remove MobileNavigationContainer default from features Shell.tsx
- Fix pre-existing lint warnings in touched files

This establishes the pattern for migrating React components that use
trpc hooks from the features layer to the web app layer, ensuring
proper dependency direction: apps/web imports from packages/features,
never the reverse.

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: move SideBar.tsx to apps/web to fix build error

SideBar.tsx was importing Navigation from the moved navigation folder,
causing a build error. Moving SideBar.tsx to apps/web and updating the
features Shell to not have a default SidebarContainer fixes this.

The web Shell wrapper now provides both the default SidebarContainer
and MobileNavigationContainer, maintaining the injection pattern.

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* revert

* revert

* revert

* wip

* wip

* wip

* wip

* wip

* wip

* not used anywhere

* wip

* wip

* wip

* wip

* fix

* fix

* wip

* wip

* wip

* wip

* wip

* fix

* fix

* fix

* fix

* migrate

* migrate admin-adpi

* wip

* feat: migrate organization settings components from packages/features to apps/web/modules

- Migrate profile.tsx, appearance.tsx, general.tsx, privacy.tsx, guest-notifications.tsx, delegationCredential.tsx, other-team-members-view.tsx, other-team-profile-view.tsx
- Migrate attributes directory (AttributesForm.tsx, DeleteAttributeModal.tsx, ListSkeleton.tsx, attributes-create-view.tsx, attributes-edit-view.tsx, attributes-list-view.tsx)
- Migrate admin directory (AdminOrgEditPage.tsx, AdminOrgPage.tsx, WorkspacePlatformPage.tsx)
- Update all page imports to use new paths from ~/settings/organizations/
- Update relative imports in migrated files to use @calcom/features paths
- Fix lint warnings in migrated files

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: update test import path after migration

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: remove unnecessary test-setup import (already in vitest config)

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* wip

* refactor: delete original files after migration to apps/web/modules

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* fix

* fix

* fix

* fix

* wip

* refactor more

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* mv

* update import paths

* wip

* wip

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* mv

* mv

* mv

* fix

* wip

* wip

* fix

* fix

* fix

* fix: make test mocks resilient to vi.resetAllMocks()

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: fix AttributeForm test failures

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix

* fix

* refactor: move ee files to apps/web/modules/ee/ folder

- Move teams, workflows, and organizations folders to apps/web/modules/ee/
- Add LICENSE file to apps/web/modules/ee/
- Update all import paths from ~/teams/ to ~/ee/teams/
- Update all import paths from ~/settings/organizations/ to ~/ee/organizations/
- Remove duplicate MemberInvitationModal copy.tsx file

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: move useHasPaidPlan and dependent files to apps/web/modules

- Move useHasPaidPlan.ts from packages/features/billing/hooks to apps/web/modules/billing/hooks
- Move intercom files from packages/features/ee/support to apps/web/modules/ee/support
- Move ContactMenuItem.tsx and dependencies (freshchat, helpscout, zendesk) to apps/web/modules/ee/support
- Move ViewRecordingsDialog.tsx and RecordingListSkeleton to apps/web/modules/ee/video
- Move CalVideoSettings.tsx to apps/web/modules/eventtypes/components/locations
- Move CreateOrEditOutOfOfficeModal.tsx to apps/web/modules/settings/outOfOffice
- Refactor UpgradeTeamsBadge to accept props and create wrapper in apps/web/modules/billing
- Update all callers to use new file locations
- Add eslint-disable comments for pre-existing lint warnings

This fixes the tRPC server build failure caused by circular dependency where
the server build was traversing into packages/features and pulling in React
hooks that depend on @calcom/trpc/react types.

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: correct UpgradeTeamsBadge import path to use package export

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix: pass plan state through SelectProps to UpgradeTeamsBadge

- Add upgradeTeamsBadgeProps field to ExtendedOption type in Select component
- Update OptionComponent to spread upgradeTeamsBadgeProps to UpgradeTeamsBadge
- Update getOptions.ts to accept PlanState object and include upgradeTeamsBadgeProps
- Update WorkflowStepContainer.tsx to pass planState to getWorkflowTriggerOptions/getWorkflowTemplateOptions
- Update WorkflowDetailsPage.tsx to pass upgradeTeamsBadgeProps in transformed action options
- Update AddActionDialog.tsx interface and mapping to include upgradeTeamsBadgeProps
- Add eslint-disable comments for pre-existing React Hook dependency warnings

This fixes the UpgradeTeamsBadge refactoring issue where the badge was always showing
'upgrade' text instead of the correct text based on plan state (trial_mode, inactive_team_plan, etc.)

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: update import paths to use /ee/ folder for workflows and organizations

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: update workflow component imports to use /ee/ folder

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: add missing types.ts for LocationInput.tsx

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: extract BookingRedirectForm type to shared location

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix

* wip

* wip

* fix: update BookingRedirectForm import to use local types file

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* wip

* fix

* fix

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2025-12-23 12:22:26 -03:00

335 lines
9.7 KiB
TypeScript

import { render } from "@testing-library/react";
import React, { type ReactNode } from "react";
import { vi } from "vitest";
import { MembershipRole } from "@calcom/prisma/enums";
import { EditMemberSheet } from "@calcom/web/modules/ee/teams/components/EditMemberSheet";
import type { MemberPermissions } from "@calcom/web/modules/users/components/UserTable/types";
import type { State, User } from "./MemberList";
// Mock dependencies
vi.mock("@calcom/lib/hooks/useLocale", () => ({
useLocale: () => ({
t: (key: string) => key,
}),
}));
vi.mock("@calcom/trpc/react", () => ({
trpc: {
viewer: {
pbac: {
getTeamRoles: {
useQuery: () => ({
data: undefined,
isPending: false,
}),
},
},
teams: {
getUserConnectedApps: {
useQuery: () => ({
data: {},
isPending: false,
}),
},
changeMemberRole: {
useMutation: () => ({
mutate: vi.fn(),
mutateAsync: vi.fn(),
}),
},
listMembers: {
cancel: vi.fn(),
getInfiniteData: vi.fn(),
invalidate: vi.fn(),
},
get: {
setData: vi.fn(),
invalidate: vi.fn(),
},
},
},
useUtils: () => ({
viewer: {
teams: {
listMembers: {
cancel: vi.fn(),
getInfiniteData: vi.fn(),
invalidate: vi.fn(),
},
get: {
setData: vi.fn(),
invalidate: vi.fn(),
},
},
},
}),
},
}));
const mockSetEditMode = vi.fn();
const mockSetMutationLoading = vi.fn();
vi.mock("@calcom/web/modules/users/components/UserTable/EditSheet/store", () => ({
useEditMode: (
selector: (state: {
editMode: boolean;
setEditMode: typeof mockSetEditMode;
mutationLoading: boolean;
setMutationLoading: typeof mockSetMutationLoading;
}) => unknown
) => {
const state = {
editMode: false,
setEditMode: mockSetEditMode,
mutationLoading: false,
setMutationLoading: mockSetMutationLoading,
};
if (typeof selector === "function") {
return selector(state);
}
return state;
},
}));
// Mock SheetFooterControls to verify props
let capturedProps: { canChangeMemberRole?: boolean; canEditAttributesForUser?: boolean }[] = [];
vi.mock("@calcom/web/modules/users/components/UserTable/EditSheet/SheetFooterControls", () => ({
SheetFooterControls: (props: { canChangeMemberRole?: boolean; canEditAttributesForUser?: boolean }) => {
capturedProps.push(props);
return React.createElement("div", { "data-testid": "sheet-footer-controls" }, "SheetFooterControls");
},
}));
// Mock other UI components
vi.mock("@calcom/ui/components/sheet", () => ({
Sheet: ({ children }: { children: ReactNode }) =>
React.createElement("div", { "data-testid": "sheet" }, children),
SheetContent: ({ children }: { children: ReactNode }) =>
React.createElement("div", { "data-testid": "sheet-content" }, children),
SheetHeader: ({ children }: { children: ReactNode }) =>
React.createElement("div", { "data-testid": "sheet-header" }, children),
SheetBody: ({ children }: { children: ReactNode }) =>
React.createElement("div", { "data-testid": "sheet-body" }, children),
SheetFooter: ({ children }: { children: ReactNode }) =>
React.createElement("div", { "data-testid": "sheet-footer" }, children),
}));
vi.mock("@calcom/ui/components/form", () => ({
Form: ({ children }: { children: ReactNode }) => React.createElement("form", null, children),
ToggleGroup: () => React.createElement("div", { "data-testid": "toggle-group" }, "ToggleGroup"),
Select: () => React.createElement("div", { "data-testid": "select" }, "Select"),
}));
vi.mock("@calcom/ui/components/avatar", () => ({
Avatar: () => React.createElement("div", { "data-testid": "avatar" }, "Avatar"),
}));
vi.mock("@calcom/ui/components/skeleton", () => ({
Skeleton: ({ children }: { children: ReactNode }) => React.createElement("div", null, children),
Loader: () => React.createElement("div", { "data-testid": "loader" }, "Loading..."),
}));
vi.mock("@calcom/web/modules/users/components/UserTable/EditSheet/DisplayInfo", () => ({
DisplayInfo: () => <div data-testid="display-info">DisplayInfo</div>,
}));
describe("EditMemberSheet", () => {
const mockDispatch = vi.fn();
// Create a minimal mock user that satisfies the User type
const mockUser = {
id: 1,
name: "Test User",
email: "test@example.com",
username: "testuser",
role: MembershipRole.MEMBER,
accepted: true,
avatarUrl: "",
bookerUrl: "https://cal.com",
lastActiveAt: "2024-01-01",
customRoleId: null,
} as User;
const mockState: State = {
editSheet: {
user: mockUser,
showModal: true,
},
deleteMember: {
showModal: false,
},
impersonateMember: {
showModal: false,
},
teamAvailability: {
showModal: false,
},
};
beforeEach(() => {
vi.clearAllMocks();
mockSetEditMode.mockClear();
mockSetMutationLoading.mockClear();
capturedProps = [];
});
describe("Fix verification: canChangeMemberRole prop passing", () => {
it("should pass canChangeMemberRole=true to SheetFooterControls when permissions.canChangeMemberRole is true", () => {
const permissions: MemberPermissions = {
canListMembers: false,
canInvite: false,
canChangeMemberRole: true,
canRemove: false,
canImpersonate: false,
};
render(
<EditMemberSheet
state={mockState}
dispatch={mockDispatch}
currentMember={MembershipRole.OWNER}
teamId={1}
permissions={permissions}
/>
);
// Verify SheetFooterControls was called with canChangeMemberRole=true
expect(capturedProps).toContainEqual(
expect.objectContaining({
canChangeMemberRole: true,
})
);
});
it("should pass canChangeMemberRole=false to SheetFooterControls when permissions.canChangeMemberRole is false", () => {
const permissions: MemberPermissions = {
canListMembers: false,
canInvite: false,
canChangeMemberRole: false,
canRemove: false,
canImpersonate: false,
};
render(
<EditMemberSheet
state={mockState}
dispatch={mockDispatch}
currentMember={MembershipRole.OWNER}
teamId={1}
permissions={permissions}
/>
);
// Verify SheetFooterControls was called with canChangeMemberRole=false
expect(capturedProps).toContainEqual(
expect.objectContaining({
canChangeMemberRole: false,
})
);
});
it("should pass canChangeMemberRole=undefined to SheetFooterControls when permissions is undefined", () => {
render(
<EditMemberSheet
state={mockState}
dispatch={mockDispatch}
currentMember={MembershipRole.OWNER}
teamId={1}
permissions={undefined}
/>
);
// Verify SheetFooterControls was called with canChangeMemberRole=undefined
expect(capturedProps).toContainEqual(
expect.objectContaining({
canChangeMemberRole: undefined,
})
);
});
it("should pass canChangeMemberRole=undefined to SheetFooterControls when permissions object exists but canChangeMemberRole is undefined", () => {
const permissions: Partial<MemberPermissions> = {
canListMembers: true,
canInvite: false,
// canChangeMemberRole is intentionally omitted
};
render(
<EditMemberSheet
state={mockState}
dispatch={mockDispatch}
currentMember={MembershipRole.OWNER}
teamId={1}
permissions={permissions as MemberPermissions}
/>
);
// Verify SheetFooterControls was called with canChangeMemberRole=undefined
expect(capturedProps).toContainEqual(
expect.objectContaining({
canChangeMemberRole: undefined,
})
);
});
it("should pass canEditAttributesForUser from permissions to SheetFooterControls", () => {
const permissions: MemberPermissions = {
canListMembers: false,
canInvite: false,
canChangeMemberRole: true,
canRemove: false,
canImpersonate: false,
canEditAttributesForUser: true,
};
render(
<EditMemberSheet
state={mockState}
dispatch={mockDispatch}
currentMember={MembershipRole.OWNER}
teamId={1}
permissions={permissions}
/>
);
// Verify SheetFooterControls was called with both props
expect(capturedProps).toContainEqual(
expect.objectContaining({
canChangeMemberRole: true,
canEditAttributesForUser: true,
})
);
});
it("should correctly extract canChangeMemberRole from permissions object (verifies fix)", () => {
// This test specifically verifies the fix where permissions?.canChangeMemberRole
// is now correctly passed to SheetFooterControls
const permissions: MemberPermissions = {
canListMembers: false,
canInvite: false,
canChangeMemberRole: true, // This should be passed to SheetFooterControls
canRemove: false,
canImpersonate: false,
};
render(
<EditMemberSheet
state={mockState}
dispatch={mockDispatch}
currentMember={MembershipRole.OWNER}
teamId={1}
permissions={permissions}
/>
);
expect(capturedProps).toContainEqual(
expect.objectContaining({
canChangeMemberRole: true,
})
);
});
});
});