* mvp done * wip * fix ts errors and other code improvements * fix ts errors * ensure mobile layout support * Make skeleton responsive on screen resize * refactor * Add test for EmbedElement * make skeleton closer to pixel perfect * Address PR feedback * Router-preloading ## What does this PR do? <!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. --> - Fixes #XXXX (GitHub issue number) - Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description) ## Visual Demo (For contributors especially) A visual demonstration is strongly recommended, for both the original and new change **(video / image - any one)**. #### Video Demo (if applicable): - Show screen recordings of the issue or feature. - Demonstrate how to reproduce the issue, the behavior before and after the change. #### Image Demo (if applicable): - Add side-by-side screenshots of the original and updated change. - Highlight any significant change(s). ## Mandatory Tasks (DO NOT REMOVE) - [ ] I have self-reviewed the code (A decent size PR without self-review might be rejected). - [ ] I have updated the developer docs in /docs if this PR makes changes that would require a [documentation change](https://cal.com/docs). If N/A, write N/A here and check the checkbox. - [ ] I confirm automated tests are in place that prove my fix is effective or that my feature works. ## How should this be tested? <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Write details that help to start the tests --> - Are there environment variables that should be set? - What are the minimal test data to have? - What is expected (happy path) to have (input and output)? - Any other important info that could help to test that PR ## Checklist <!-- Remove bullet points below that don't apply to you --> - I haven't read the [contributing guide](https://github.com/calcom/cal.com/blob/main/CONTRIBUTING.md) - My code doesn't follow the style guidelines of this project - I haven't commented my code, particularly in hard-to-understand areas - I haven't checked if my changes generate no new warnings * wip\ * wip * fix mrge.io feedback * wip * Add README and lifecycle * Add README and lifecycle * Update routing form-seed and some other fixes * remove linkFailed fix from the branch * self-review * self-review-2 * self-review-3 * Handle soft connect\ * Update README and fix a bug with query parmas * Add one more case in routing-html playground --------- Co-authored-by: Benny Joo <sldisek783@gmail.com> Co-authored-by: amrit <iamamrit27@gmail.com>
Embeds
This folder contains all the various flavours of embeds.
core contains the core library written in vanilla JS that manages the embed.
snippet contains the Vanilla JS Code Snippet that can be installed on any website and would automatically fetch the core library.
Please see the respective folder READMEs for details on them.
Publishing to NPM. It will soon be automated using changesets github action
To publish the packages. Following steps should be followed. All commands are to be run at the root.
yarn changeset-> Creates changelog files and adds summary to changelog. Select embed packages only here.yarn changeset version-> Bumps the versions as required- Get the PR reviewed and merged
yarn publish-embed-> Releases all packages. We can't useyarn changeset publishbecause it doesn't support workspace: prefix removal yet. See https://github.com/changesets/changesets/issues/432#issuecomment-1016365428
Skeleton Loader
Skeleton loader is shown for supported page types. For all other page types, default non-skeleton loader is shown. Status:
- Layout
- Responsive
- Mobile Layout
- month_view Layout
- week_view Layout
- column_view Layout
- Theming
- Dark and Light theme NOTE: If user has preference for theme configured within app, that has to be communicated clearly in the embed too for skeleton to work
- Change in system theme should reflect without page refresh
- Page Types supported
- user.event.booking.slots
- team.event.booking.slots
- [Partially supported] user.event.booking.form - Shows skeleton but of the slots page
- [Partially supported] team.event.booking.form - Shows skeleton but of the slots page
- user.profile
- team.profile
How Routing Prerendering works
- Use API to prerender a booking link for "modal"
- When CTA is clicked by user, we check if there is a "prerendered"/"being prerendered" modal for this namespace.
- If yes, we open up the modal showing the skeleton loader and send the POST request to /api/router endpoint
- When we get the response from the endpoint, we pass on all the query params to the already rendered/being rendered iframe and embed-iframe updates the URL of the iframe to have the new query params through history.replaceState(i.e. without reloading the page)
Prerendering vs Preloading
- Preloading loads the calLink in iframe with the sole purpose of preloading the static assets, so that when the embed actually opens, it uses the static assets from browser cache.
- Prerendering means continuing over the preloaded iframe, so that the user books on the prerendered iframe only. So, it is much more complex than preloading and gives much more benefits in terms of performance.
Note: API wise
prerenderdelegates its task topreloadAPI which then identifies whether to preload or prerender.
Modalbox re-opening performance optimization
- ModalBox supports reusing the same cal-modal-box element and thus same iframe and thus providing a lightning fast experience when the same modal is opened multiple times [This feature is currently disabled in code because of stale booking page UI issues]
Embed Core Architecture and Features
Architecture Overview
Initialization and Bootstrap Process
The embed system initializes through a multi-step process:
- The embed script is loaded on the parent page
- It creates a global
Calobject that acts as the entry point - The system initializes necessary custom elements (
cal-modal-box,cal-floating-button,cal-inline) - A namespace-based action manager is created for event handling
Parent-Iframe Communication System
Communication between the parent page and the embedded iframe uses a message-based system:
// Parent to Iframe communication example
interface InterfaceWithParent {
ui: (config: UiConfig) => void;
connect: (config: PrefillAndIframeAttrsConfig) => void;
}
// Event data structure
type EventData<T> = {
type: string;
namespace: string;
fullType: string;
data: EventDataMap[T];
};
The system uses namespaced events to ensure multiple embeds on the same page don't interfere with each other.
Instruction Queue System
Commands are queued before the iframe is ready:
type Instruction = SingleInstruction | SingleInstruction[];
type InstructionQueue = Instruction[];
// Commands are queued if iframe isn't ready
if (!this.iframeReady) {
this.iframeDoQueue.push(doInIframeArg);
return;
}
Embedding Methods
Inline Embedding
Embeds the calendar directly within the page flow:
Cal.inline({
elementOrSelector: "#my-cal-inline",
calLink: "organization/event-type"
});
Modal Embedding
Creates a modal dialog with the calendar:
Cal.modal({
calLink: "organization/event-type",
config: {
// Optional configuration
}
});
FloatingButton Embedding
Adds a floating action button that opens the calendar in a modal. It uses modal embedding under the hood.
Cal.floatingButton({
calLink: "organization/event-type",
buttonText: "Book meeting",
buttonPosition: "bottom-right"
});
Configuration and Customization
Prefill System
Allows pre-filling form fields:
Cal.inline({
calLink: "organization/event-type",
config: {
name: "John Doe",
email: "john@example.com",
notes: "Initial discussion"
}
});
Query Parameter Handling
The system allows automatically forwarding query params to the iframe, by setting. This code must be present right after the embed snippet is added to the page.
Cal.config = Cal.config || {};
Cal.config.forwardQueryParams=true
Advanced Features
Routing Prerendering System
The prerendering system optimizes the initial load:
Cal.prerender({
calLink: "organization/event-type",
type: "modal"
});
Key aspects:
- Creates a hidden iframe
- Loads the booking page but doesn't send the slots availability request
- Tries to reuse whenever it makes sense and do a fresh load otherwise
Iframe Reuse and Reload Conditions. There could be three situations:
- Reuse
- Reuse the iframe but refetch the slots
- Do a fresh load in iframe
-
Reuse:
- Modal opens when
- Modal is not in a failed state
- config, params are same as the last time
- No threshold violations
- Modal opens when
-
Reuse the iframe but refetch the slots:
- Only embed
configchanges (handled via "connect" flow) - Query query params changes (handled via "connect" flow)
- Crossed slots stale time threshold (EMBED_MODAL_IFRAME_SLOT_STALE_TIME)
- Only embed
-
Fresh Reload Conditions:
- Different path being loaded(i.e. /pro vs /free)
- Modal is in a failed state
- Time since last render exceeds EMBED_MODAL_IFRAME_FORCE_RELOAD_THRESHOLD_MS