* fix: apply PBAC to routing form CRUD
* apply permission checks to the UI
* moving prisma call to repository [WIP]
* rename repository and fix type error
* update implementation
* fix formMutation handler
* remove unused import
* revert some rename
* add RolePermission for 'routingForm'
* Revert "revert some rename"
This reverts commit 0ef3114c0d27b821271b36296de531654b37749f.
* clean up PrismaRoutingFormRepository
* fix unit test
* remove no longer necessary code
* fix type definition
* explicit permission handling
* do not disable un-editable routing form
* fix: correct property name from readonly to readOnly in ListLinkItem
- Fix TypeScript error in routing forms component
- Change readonly={readOnly} to readOnly={readOnly} to match component interface
- Resolves type check failure in CI
Co-Authored-By: hariom@cal.com <hariombalhara@gmail.com>
---------
Co-authored-by: Hariom Balhara <hariombalhara@gmail.com>
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
168 lines
4.1 KiB
TypeScript
168 lines
4.1 KiB
TypeScript
import { Resource } from "@calcom/features/pbac/domain/types/permission-registry";
|
|
import { getResourcePermissions } from "@calcom/features/pbac/lib/resource-permissions";
|
|
import { MembershipRepository } from "@calcom/lib/server/repository/membership";
|
|
import { MembershipRole } from "@calcom/prisma/enums";
|
|
import type { AppGetServerSidePropsContext, AppPrisma, AppUser } from "@calcom/types/AppGetServerSideProps";
|
|
|
|
import { enrichFormWithMigrationData } from "../enrichFormWithMigrationData";
|
|
import { getSerializableForm } from "../lib/getSerializableForm";
|
|
|
|
export const getServerSidePropsForSingleFormView = async function getServerSidePropsForSingleFormView(
|
|
context: AppGetServerSidePropsContext,
|
|
prisma: AppPrisma,
|
|
user: AppUser
|
|
) {
|
|
if (!user) {
|
|
return {
|
|
redirect: {
|
|
permanent: false,
|
|
destination: "/auth/login",
|
|
},
|
|
};
|
|
}
|
|
const { params } = context;
|
|
if (!params) {
|
|
return {
|
|
notFound: true,
|
|
};
|
|
}
|
|
const appPages = params.pages.slice(1);
|
|
const formId = appPages[0];
|
|
if (!formId || appPages.length > 1) {
|
|
return {
|
|
notFound: true,
|
|
};
|
|
}
|
|
|
|
const form = await prisma.app_RoutingForms_Form.findUnique({
|
|
where: {
|
|
id: formId,
|
|
},
|
|
include: {
|
|
user: {
|
|
select: {
|
|
id: true,
|
|
movedToProfileId: true,
|
|
organization: {
|
|
select: {
|
|
slug: true,
|
|
},
|
|
},
|
|
username: true,
|
|
theme: true,
|
|
brandColor: true,
|
|
darkBrandColor: true,
|
|
metadata: true,
|
|
},
|
|
},
|
|
team: {
|
|
select: {
|
|
slug: true,
|
|
name: true,
|
|
parent: {
|
|
select: { slug: true },
|
|
},
|
|
parentId: true,
|
|
metadata: true,
|
|
},
|
|
},
|
|
_count: {
|
|
select: {
|
|
responses: true,
|
|
},
|
|
},
|
|
},
|
|
});
|
|
if (!form) {
|
|
return {
|
|
notFound: true,
|
|
};
|
|
}
|
|
|
|
const { user: u, ...formWithoutUser } = form;
|
|
|
|
const formWithoutProfileInfo = {
|
|
...formWithoutUser,
|
|
team: form.team
|
|
? {
|
|
slug: form.team.slug,
|
|
name: form.team.name,
|
|
}
|
|
: null,
|
|
};
|
|
|
|
const { UserRepository } = await import("@calcom/lib/server/repository/user");
|
|
|
|
const userRepo = new UserRepository(prisma);
|
|
const formWithUserInfoProfile = {
|
|
...form,
|
|
user: await userRepo.enrichUserWithItsProfile({ user: form.user }),
|
|
};
|
|
|
|
// Get PBAC permissions for team-scoped routing forms
|
|
let permissions = {
|
|
canCreate: false,
|
|
canRead: false,
|
|
canEdit: false,
|
|
canDelete: false,
|
|
};
|
|
|
|
if (!form.teamId) {
|
|
// For personal forms (teamId = null),
|
|
// check if the form belongs to the current user
|
|
if (form.userId !== user.id) {
|
|
return {
|
|
notFound: true,
|
|
};
|
|
}
|
|
|
|
permissions = {
|
|
canCreate: true,
|
|
canRead: true,
|
|
canEdit: true,
|
|
canDelete: true,
|
|
};
|
|
} else {
|
|
// team-scoped routing form
|
|
// Get user's role in the team
|
|
const membership = await MembershipRepository.findUniqueByUserIdAndTeamId({
|
|
userId: user.id,
|
|
teamId: form.teamId,
|
|
});
|
|
|
|
if (!membership) {
|
|
return {
|
|
notFound: true,
|
|
};
|
|
}
|
|
|
|
permissions = await getResourcePermissions({
|
|
userId: user.id,
|
|
teamId: form.teamId,
|
|
resource: Resource.RoutingForm,
|
|
userRole: membership.role,
|
|
fallbackRoles: {
|
|
read: { roles: [MembershipRole.MEMBER, MembershipRole.ADMIN, MembershipRole.OWNER] },
|
|
create: { roles: [MembershipRole.ADMIN, MembershipRole.OWNER] },
|
|
update: { roles: [MembershipRole.ADMIN, MembershipRole.OWNER] },
|
|
delete: { roles: [MembershipRole.ADMIN, MembershipRole.OWNER] },
|
|
},
|
|
});
|
|
}
|
|
|
|
return {
|
|
props: {
|
|
form: await getSerializableForm({ form: formWithoutProfileInfo }),
|
|
enrichedWithUserProfileForm: await getSerializableForm({
|
|
form: enrichFormWithMigrationData(formWithUserInfoProfile),
|
|
}),
|
|
permissions: {
|
|
canCreate: permissions.canCreate,
|
|
canRead: permissions.canRead,
|
|
canEdit: permissions.canEdit,
|
|
canDelete: permissions.canDelete,
|
|
},
|
|
},
|
|
};
|
|
};
|