* wip * wip * feature: Booking Tasker without DI yet * feature: Booking Tasker with DI * fix type check 1 * fix type check 2 * fix * comment booking tasker for now * fix: DI regularBookingService api v2 * fix: convert trigger.dev SDK imports to dynamic imports to fix unit tests The unit tests were failing because BookingEmailAndSmsTriggerTasker.ts had static imports of trigger files that depend on @trigger.dev/sdk. This caused Vitest to try to resolve the SDK at module load time, even though it should be optional. Changed all imports in BookingEmailAndSmsTriggerTasker.ts from static to dynamic (using await import()) so the trigger files are only loaded when the tasker methods are actually called, not at module load time during tests. This fixes the 'Failed to load url @trigger.dev/sdk' errors that were causing 28+ test failures. Co-Authored-By: morgan@cal.com <morgan@cal.com> * fix unit tests * keep inline smsAndEmailHandler.send calls * chore: add team feature flag * add satisfies ModuleLoader * fix type check app flags * move trigger in feature * fix: add trigger.dev prisma generator * fix: email app statuses * fix: CalEvtBuilder unit test * chore: improvements, schema, config, retry * fixup! chore: improvements, schema, config, retry * chore: cleanup code * chore: cleanup code * chore: clean code and give full payload * remove log * add booking notifications queue * add attendee phone number for sms * bump trigger to 4.1.0 * add missing booking seat data in attendee * update config * fix logger regular booking service * fix: prisma as external deps of trigger * fix yarn.lock * revert change to example app booking page * fix: resolve circular dependencies and improve cold start performance in trigger tasks - Convert BookingRepository import to type-only in CalendarEventBuilder.ts to eliminate circular dependency risk - Convert EventNameObjectType, CalendarEvent, and JsonObject imports to type-only in BookingEmailAndSmsTaskService.ts - Use dynamic imports in all trigger notification tasks (confirm, request, reschedule, rr-reschedule) to reduce cold start time - Move heavy imports (BookingEmailSmsHandler, BookingRepository, prisma, TriggerDevLogger, BookingEmailAndSmsTaskService) inside run functions - Eliminates module-level prisma import which violates repo guidelines and adds cold start overhead - Reduces initial module dependency graph by deferring heavy imports (email templates, workflows, large repositories) until task execution Co-Authored-By: morgan@cal.com <morgan@cal.com> * fix: improve cold start performance in reminderScheduler with dynamic imports - Remove module-level prisma import (violates 'No prisma outside repositories' guideline) - Use dynamic imports for UserRepository (1,168 lines) - only loaded when needed in EMAIL_ATTENDEE action - Use dynamic imports for twilio provider (386 lines) - only loaded in cancelScheduledMessagesAndScheduleEmails - Use dynamic imports for all manager functions by action type: - scheduleSMSReminder (387 lines) - loaded only for SMS actions - scheduleEmailReminder (459 lines) - loaded only for Email actions - scheduleWhatsappReminder (266 lines) - loaded only for WhatsApp actions - scheduleAIPhoneCall (478 lines) - loaded only for AI phone call actions - Use dynamic imports for sendOrScheduleWorkflowEmails in cancelScheduledMessagesAndScheduleEmails - Significantly reduces cold start time by deferring heavy module loading until execution paths need them - Eliminates module-level prisma import that violated repository pattern guidelines Co-Authored-By: morgan@cal.com <morgan@cal.com> * fix: improve cold start performance in BookingEmailSmsHandler with dynamic imports - Remove module-level imports of all email-manager functions (653 LOC + 30+ email templates) - Add dynamic imports in each method (_handleRescheduled, _handleRoundRobinRescheduled, _handleConfirmed, _handleRequested, handleAddGuests) - Defer heavy email-manager loading until method execution - Verified no circular dependencies between email-manager and bookings - Significantly reduces cold start time for RegularBookingService and BookingEmailAndSmsTaskService Co-Authored-By: morgan@cal.com <morgan@cal.com> * fix: use dynamic imports * update yarn lock * code review * trigger config project ref in env * update yarn lock * add .env.example trigger variables * add .env.example trigger variables * fix: cleanup error handling and loggin * fix: trigger config from env * fix: small typo fix * fix: ai review comments * fix: ai review comments * ai review * Add `create` on `WorkflowReminderRepository` * `sendWorkflowEmails` tasker to accept lazy payload * Add `scheduleLazyEmailWorkflow` to `WorkflowService * Process scheduled date in `scheduleLazyEmailWorkflow` * Type fixes * Use `WorkflowService` to schedule * Refactor `scheduleEmailReminderForEvt` to use `WorkflowService.processWorkflowScheduledDate` * Pass seat reference to lazy scheduled workflow reminder * Refactor `WorkflowReminderRepository` to accept prisma as constructor * Abstract `FormSubmissionData` type * Abstract select statement and add get by uid to `BookingRepository` * Add `FormSubmissionData` type * Add `findByIdIncludeStepAndWorkflow` to `WorkflowReminderRepository` * Tasker payload to accept `workflowReminderId` * Create `BookingSeatRepository` * Write `workflowReminderId` to tasker payload * Add `generateCommonScheduleFunctionParams` to `WorkflowService` * Init * Use services in tasker * Abstract types * In reminderScheduler use workflowService to generate common params * Type fix * Return params from emailWorkflowService.generateParametersToBuildEmailWorkflowContent * Use emailWorkflowService to generate params * Abstract types * Generate email content and send in EmailWorkflowService * Move check to caller * Use EmailWorkflowService to generate email payload in emailReminderManager * Fix initalizing repository * Use evt.videoCallData first before the booking metadata * Only get non-deleted references to build calendar event * Remove check for videoCallData.id * Dynamic import credit service * BookingRepository.getByUid to only return what we need from attendee * Type fixes * test: Add comprehensive tests for lazy email workflow generation and fix broken tests - Fix prisma mocks in sms-manager.test.ts and outOfOfficeCreateOrUpdate.handler.test.ts to export both 'default' and named 'prisma' exports - Add EmailWorkflowService.test.ts with 4 tests for error handling paths - Add sendWorkflowEmails.test.ts with 7 tests for schema validation and email sending - Add tests to WorkflowService.test.ts for scheduleLazyEmailWorkflow, processWorkflowScheduledDate, and generateCommonScheduleFunctionParams methods Co-Authored-By: joe@cal.com <j.auyeung419@gmail.com> * Write `seatReferenceUid` * Return promise * Fix log * Change to `Promise.allSettled` * Type fix * Fix failing test * fix: reorder workflow step checks to fix test failure The test 'should throw error if workflow step not found on reminder' was failing because the code checked workflowStep.verifiedAt before checking if workflowStep exists. When workflowStep is null, this caused the error message to include 'undefined' instead of the expected workflow step id. Fixed by reordering the checks: 1. First check if workflowStep exists 2. Then check if workflowStep.verifiedAt exists Also updated the test expectation to match the correct error message. Co-Authored-By: joe@cal.com <j.auyeung419@gmail.com> --------- Co-authored-by: cal.com <morgan@cal.com> Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com> Co-authored-by: hbjORbj <sldisek783@gmail.com> Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Alex van Andel <me@alexvanandel.com>
214 lines
6.3 KiB
TypeScript
214 lines
6.3 KiB
TypeScript
import { describe, expect, vi, beforeEach, test } from "vitest";
|
|
|
|
vi.mock("@calcom/emails/workflow-email-service", () => ({
|
|
sendCustomWorkflowEmail: vi.fn(),
|
|
}));
|
|
|
|
const mockGetBookingForCalEventBuilderFromUid = vi.fn();
|
|
vi.mock("@calcom/features/bookings/repositories/BookingRepository", () => ({
|
|
BookingRepository: vi.fn().mockImplementation(() => ({
|
|
getBookingForCalEventBuilderFromUid: mockGetBookingForCalEventBuilderFromUid,
|
|
})),
|
|
}));
|
|
|
|
vi.mock("@calcom/features/bookings/repositories/BookingSeatRepository", () => ({
|
|
BookingSeatRepository: vi.fn(),
|
|
}));
|
|
|
|
const mockHandleSendEmailWorkflowTask = vi.fn();
|
|
vi.mock("@calcom/features/ee/workflows/lib/service/EmailWorkflowService", () => ({
|
|
EmailWorkflowService: vi.fn().mockImplementation(() => ({
|
|
handleSendEmailWorkflowTask: mockHandleSendEmailWorkflowTask,
|
|
})),
|
|
}));
|
|
|
|
vi.mock("@calcom/features/ee/workflows/repositories/WorkflowReminderRepository", () => ({
|
|
WorkflowReminderRepository: vi.fn(),
|
|
}));
|
|
|
|
vi.mock("@calcom/prisma", () => ({
|
|
default: {},
|
|
prisma: {},
|
|
}));
|
|
|
|
vi.mock("@calcom/features/CalendarEventBuilder", () => ({
|
|
CalendarEventBuilder: {
|
|
fromBooking: vi.fn(),
|
|
},
|
|
}));
|
|
|
|
import { sendCustomWorkflowEmail } from "@calcom/emails/workflow-email-service";
|
|
import { CalendarEventBuilder } from "@calcom/features/CalendarEventBuilder";
|
|
|
|
import { sendWorkflowEmails, ZSendWorkflowEmailsSchema } from "./sendWorkflowEmails";
|
|
|
|
const mockSendCustomWorkflowEmail = vi.mocked(sendCustomWorkflowEmail);
|
|
const mockCalendarEventBuilder = vi.mocked(CalendarEventBuilder);
|
|
|
|
describe("sendWorkflowEmails", () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks();
|
|
});
|
|
|
|
describe("Schema validation", () => {
|
|
test("should validate eager email payload", () => {
|
|
const eagerPayload = {
|
|
to: ["test@example.com"],
|
|
subject: "Test Subject",
|
|
html: "<p>Test Body</p>",
|
|
replyTo: "reply@example.com",
|
|
sender: "Sender Name",
|
|
attachments: [
|
|
{
|
|
content: "content",
|
|
filename: "file.txt",
|
|
},
|
|
],
|
|
};
|
|
|
|
const result = ZSendWorkflowEmailsSchema.parse(eagerPayload);
|
|
expect(result).toEqual(eagerPayload);
|
|
});
|
|
|
|
test("should validate lazy email payload", () => {
|
|
const lazyPayload = {
|
|
bookingUid: "booking-123",
|
|
workflowReminderId: 1,
|
|
};
|
|
|
|
const result = ZSendWorkflowEmailsSchema.parse(lazyPayload);
|
|
expect(result).toEqual(lazyPayload);
|
|
});
|
|
});
|
|
|
|
describe("Eager email sending", () => {
|
|
test("should send email with eager payload", async () => {
|
|
const payload = {
|
|
to: ["test@example.com", "test2@example.com"],
|
|
subject: "Test Subject",
|
|
html: "<p>Test Body</p>",
|
|
replyTo: "reply@example.com",
|
|
sender: "Sender Name",
|
|
};
|
|
|
|
await sendWorkflowEmails(JSON.stringify(payload));
|
|
|
|
expect(mockSendCustomWorkflowEmail).toHaveBeenCalledTimes(2);
|
|
expect(mockSendCustomWorkflowEmail).toHaveBeenCalledWith({
|
|
to: "test@example.com",
|
|
subject: "Test Subject",
|
|
html: "<p>Test Body</p>",
|
|
replyTo: "reply@example.com",
|
|
sender: "Sender Name",
|
|
});
|
|
expect(mockSendCustomWorkflowEmail).toHaveBeenCalledWith({
|
|
to: "test2@example.com",
|
|
subject: "Test Subject",
|
|
html: "<p>Test Body</p>",
|
|
replyTo: "reply@example.com",
|
|
sender: "Sender Name",
|
|
});
|
|
});
|
|
|
|
test("should send email with attachments", async () => {
|
|
const payload = {
|
|
to: ["test@example.com"],
|
|
subject: "Test Subject",
|
|
html: "<p>Test Body</p>",
|
|
attachments: [
|
|
{
|
|
content: "base64content",
|
|
filename: "event.ics",
|
|
},
|
|
],
|
|
};
|
|
|
|
await sendWorkflowEmails(JSON.stringify(payload));
|
|
|
|
expect(mockSendCustomWorkflowEmail).toHaveBeenCalledWith({
|
|
to: "test@example.com",
|
|
subject: "Test Subject",
|
|
html: "<p>Test Body</p>",
|
|
attachments: [
|
|
{
|
|
content: "base64content",
|
|
filename: "event.ics",
|
|
},
|
|
],
|
|
});
|
|
});
|
|
});
|
|
|
|
describe("Lazy email generation", () => {
|
|
test("should generate and send email with lazy payload", async () => {
|
|
const payload = {
|
|
bookingUid: "booking-123",
|
|
workflowReminderId: 1,
|
|
};
|
|
|
|
const mockBooking = {
|
|
uid: "booking-123",
|
|
user: { id: 1, name: "User", email: "user@example.com" },
|
|
eventType: { id: 1, title: "Meeting" },
|
|
};
|
|
|
|
const mockCalendarEvent = {
|
|
uid: "booking-123",
|
|
title: "Meeting",
|
|
organizer: { email: "user@example.com" },
|
|
attendees: [{ email: "attendee@example.com" }],
|
|
};
|
|
|
|
const mockBuilder = {
|
|
build: vi.fn().mockReturnValue(mockCalendarEvent),
|
|
} as unknown as CalendarEventBuilder;
|
|
|
|
mockGetBookingForCalEventBuilderFromUid.mockResolvedValue(mockBooking);
|
|
mockCalendarEventBuilder.fromBooking.mockResolvedValue(mockBuilder);
|
|
|
|
await sendWorkflowEmails(JSON.stringify(payload));
|
|
|
|
expect(mockGetBookingForCalEventBuilderFromUid).toHaveBeenCalledWith("booking-123");
|
|
expect(mockHandleSendEmailWorkflowTask).toHaveBeenCalledWith({
|
|
evt: mockCalendarEvent,
|
|
workflowReminderId: 1,
|
|
});
|
|
});
|
|
|
|
test("should throw error if booking not found", async () => {
|
|
const payload = {
|
|
bookingUid: "non-existent-booking",
|
|
workflowReminderId: 1,
|
|
};
|
|
|
|
mockGetBookingForCalEventBuilderFromUid.mockResolvedValue(null);
|
|
|
|
await expect(sendWorkflowEmails(JSON.stringify(payload))).rejects.toThrow("Booking not found");
|
|
});
|
|
|
|
test("should throw error if calendar event cannot be built", async () => {
|
|
const payload = {
|
|
bookingUid: "booking-123",
|
|
workflowReminderId: 1,
|
|
};
|
|
|
|
const mockBooking = {
|
|
uid: "booking-123",
|
|
user: { id: 1, name: "User", email: "user@example.com" },
|
|
eventType: { id: 1, title: "Meeting" },
|
|
};
|
|
|
|
const mockBuilder = {
|
|
build: vi.fn().mockReturnValue(null),
|
|
} as unknown as CalendarEventBuilder;
|
|
|
|
mockGetBookingForCalEventBuilderFromUid.mockResolvedValue(mockBooking);
|
|
mockCalendarEventBuilder.fromBooking.mockResolvedValue(mockBuilder);
|
|
|
|
await expect(sendWorkflowEmails(JSON.stringify(payload))).rejects.toThrow(
|
|
"Calendar event could not be built"
|
|
);
|
|
});
|
|
});
|
|
});
|