Files
calendar/packages/lib/server/service/routingForm/RoutingFormResponseDataFactory.test.ts
T
Joe Au-YeungGitHubDevin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>Alex van Andel
f85f226982 fix: Create RoutingFormResponseService to get field value from identifier (#22396)
* Make identifier required

* Fallback to null if identifier isn't present

* Type fix

* Type fixes

* Type fix

* Create `RoutingFormResponseRepository`

* Create `RoutingFormResponseService`

* Use repsotiories to find form value

* Delete console.logs

* Undo change in `ZResponseInputSchema` schema

* Type fix

* Undo changes

* fix: correct import path in RoutingFormResponseService to resolve runtime errors

- Change relative import path to use @calcom alias
- Prevents import resolution failures that cause app startup issues

Co-Authored-By: joe@cal.com <j.auyeung419@gmail.com>

* Undo changes

* Update type

* Update typing

* Address feedback

* Address feedback

* chore: Provide a suggestion for pr 22396, new structure (#22491)

* chore: Provide a suggestion for pr 22396, new structure

* Refactor to create two create methods with bookingUid and id

* Use `createWithBookingUid`

* Extract routing form response parser to seperate util

* Added more and improved test cases

* Fix

---------

Co-authored-by: Joe Au-Yeung <j.auyeung419@gmail.com>

* Factory included wrong calls

* Fix test for findFieldValueByIdentifier

* Add tests

* Fix test

* Fix test

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Alex van Andel <me@alexvanandel.com>
2025-07-17 22:40:18 +01:00

95 lines
3.5 KiB
TypeScript

import { describe, it, expect, beforeEach, vi } from "vitest";
import type { RoutingFormResponseRepositoryInterface } from "../../repository/RoutingFormResponseRepository.interface";
import { RoutingFormResponseDataFactory } from "./RoutingFormResponseDataFactory";
import { parseRoutingFormResponse } from "./responseData/parseRoutingFormResponse";
vi.mock("./responseData/parseRoutingFormResponse", () => ({
parseRoutingFormResponse: vi.fn(),
}));
const mockLogger = {
getSubLogger: () => ({
error: vi.fn(),
}),
};
const mockRoutingFormResponseRepo: RoutingFormResponseRepositoryInterface = {
findByBookingUidIncludeForm: vi.fn(),
findByIdIncludeForm: vi.fn(),
};
describe("RoutingFormResponseDataFactory", () => {
let factory: RoutingFormResponseDataFactory;
beforeEach(() => {
vi.clearAllMocks();
factory = new RoutingFormResponseDataFactory({
logger: mockLogger as any,
routingFormResponseRepo: mockRoutingFormResponseRepo,
});
});
describe("createWithBookingUid", () => {
it("should call parseRoutingFormResponse with correct data when form response is found", async () => {
const mockFormResponse = {
id: 1,
response: { name: "test" },
form: { fields: [{ label: "name", type: "text" }] },
};
const bookingUid = "test-uid";
vi.mocked(mockRoutingFormResponseRepo.findByBookingUidIncludeForm).mockResolvedValue(
mockFormResponse as any
);
const result = await factory.createWithBookingUid(bookingUid);
expect(mockRoutingFormResponseRepo.findByBookingUidIncludeForm).toHaveBeenCalledWith(bookingUid);
expect(parseRoutingFormResponse).toHaveBeenCalledWith(
mockFormResponse.response,
mockFormResponse.form.fields
);
});
it("should throw an error if form response is not found", async () => {
const bookingUid = "test-uid";
vi.mocked(mockRoutingFormResponseRepo.findByBookingUidIncludeForm).mockResolvedValue(null);
await expect(factory.createWithBookingUid(bookingUid)).rejects.toThrow("Form response not found");
expect(mockRoutingFormResponseRepo.findByBookingUidIncludeForm).toHaveBeenCalledWith(bookingUid);
expect(parseRoutingFormResponse).not.toHaveBeenCalled();
});
});
describe("createWithResponseId", () => {
it("should call parseRoutingFormResponse with correct data when form response is found", async () => {
const mockFormResponse = {
id: 1,
response: { email: "test@example.com" },
form: { fields: [{ label: "email", type: "email" }] },
};
const responseId = 1;
vi.mocked(mockRoutingFormResponseRepo.findByIdIncludeForm).mockResolvedValue(mockFormResponse as any);
const result = await factory.createWithResponseId(responseId);
expect(mockRoutingFormResponseRepo.findByIdIncludeForm).toHaveBeenCalledWith(responseId);
expect(parseRoutingFormResponse).toHaveBeenCalledWith(
mockFormResponse.response,
mockFormResponse.form.fields
);
});
it("should throw an error if form response is not found", async () => {
const responseId = 1;
vi.mocked(mockRoutingFormResponseRepo.findByIdIncludeForm).mockResolvedValue(null);
await expect(factory.createWithResponseId(responseId)).rejects.toThrow("Form response not found");
expect(mockRoutingFormResponseRepo.findByIdIncludeForm).toHaveBeenCalledWith(responseId);
expect(parseRoutingFormResponse).not.toHaveBeenCalled();
});
});
});