Hariom BalharaandGitHub
ed76d163cf
## What does this PR do? 1. cal.com/sales page is a special case where embed-iframe exists in top as well as in iframe. This causes a looping of events somehow due to embed-iframe firing events and those being received by the top embed-iframe. 2. Added new `navigatedToBooker` event to know when the user lands on booker page. Corresponding PR in website that uses `navigatedToBooker` event and has a demo as well https://github.com/calcom/website/pull/741 Earlier added `routed` event seems to happen too early ## Type of change - Bug fix (non-breaking change which fixes an issue) ## How should this be tested? - Simply navigate to booker and wait for the event. ## Mandatory Tasks - [x] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected. ## Tests - Didn't add any tests for this as the changed seems straightforward ## Checklist - I haven't added tests that prove my fix is effective or that my feature works
Embeds
This folder contains all the various flavours of embeds.
core contains the core library written in vanilla JS that manages the embed.
snippet contains the Vanilla JS Code Snippet that can be installed on any website and would automatically fetch the core library.
Please see the respective folder READMEs for details on them.
Publishing to NPM. It will soon be automated using changesets github action
To publish the packages. Following steps should be followed. All commands are to be run at the root.
yarn changeset-> Creates changelog files and adds summary to changelog. Select embed packages only here.yarn changeset version-> Bumps the versions as required- Get the PR reviewed and merged
yarn publish-embed-> Releases all packages. We can't useyarn changeset publishbecause it doesn't support workspace: prefix removal yet. See https://github.com/changesets/changesets/issues/432#issuecomment-1016365428