* feat: add Webhook resource to PBAC system with permission enforcement - Add Webhook resource to PBAC permission registry with CRUD actions - Implement PBAC permission checks in webhook handlers (create, edit, delete) - Add webhook permission translations to common.json - Use PermissionCheckService with fallback roles [ADMIN, OWNER] for team webhooks - Maintain backward compatibility when PBAC is disabled - Follow same pattern as workflow PBAC implementation from PR #22845 Co-Authored-By: sean@cal.com <Sean@brydon.io> * fix: implement PBAC permission filtering in webhook list handler - Add PermissionCheckService to filter team webhooks by webhook.read permission - Only show webhooks from teams where user has proper permissions - Maintain backward compatibility with fallback to all team memberships Co-Authored-By: sean@cal.com <Sean@brydon.io> * add migration for default roles * new forUserMethod * update webhook repository * fix UI showing/hiding webhooks for webhoo.create teams * WIP pbac procedure migratoin + tests * add more roles to get fallback * permissions in cmponents instead of readOnly * passPermissions to list item * push instant events logic * Git merge * wip teamId accessable refactor * fix delete handler --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
87 lines
2.1 KiB
TypeScript
87 lines
2.1 KiB
TypeScript
import { PermissionCheckService } from "@calcom/features/pbac/services/permission-check.service";
|
|
import {
|
|
updateTriggerForExistingBookings,
|
|
deleteWebhookScheduledTriggers,
|
|
cancelNoShowTasksForBooking,
|
|
} from "@calcom/features/webhooks/lib/scheduleTrigger";
|
|
import { prisma } from "@calcom/prisma";
|
|
import { MembershipRole } from "@calcom/prisma/enums";
|
|
import type { TrpcSessionUser } from "@calcom/trpc/server/types";
|
|
|
|
import { TRPCError } from "@trpc/server";
|
|
|
|
import type { TEditInputSchema } from "./edit.schema";
|
|
|
|
type EditOptions = {
|
|
ctx: {
|
|
user: NonNullable<TrpcSessionUser>;
|
|
};
|
|
input: TEditInputSchema;
|
|
};
|
|
|
|
export const editHandler = async ({ input, ctx }: EditOptions) => {
|
|
const { id, ...data } = input;
|
|
|
|
const webhook = await prisma.webhook.findUnique({
|
|
where: {
|
|
id,
|
|
},
|
|
});
|
|
|
|
if (!webhook) {
|
|
return null;
|
|
}
|
|
|
|
if (webhook.platform) {
|
|
const { user } = ctx;
|
|
if (user?.role !== "ADMIN") {
|
|
throw new TRPCError({ code: "UNAUTHORIZED" });
|
|
}
|
|
}
|
|
|
|
if (webhook.teamId) {
|
|
const permissionService = new PermissionCheckService();
|
|
|
|
const hasPermission = await permissionService.checkPermission({
|
|
userId: ctx.user.id,
|
|
teamId: webhook.teamId,
|
|
permission: "webhook.update",
|
|
fallbackRoles: [MembershipRole.ADMIN, MembershipRole.OWNER],
|
|
});
|
|
|
|
if (!hasPermission) {
|
|
throw new TRPCError({
|
|
code: "UNAUTHORIZED",
|
|
});
|
|
}
|
|
}
|
|
|
|
const updatedWebhook = await prisma.webhook.update({
|
|
where: {
|
|
id,
|
|
},
|
|
data: {
|
|
...data,
|
|
time: data.time ?? null,
|
|
timeUnit: data.timeUnit ?? null,
|
|
},
|
|
});
|
|
|
|
if (data.active) {
|
|
const activeTriggersBefore = webhook.active ? webhook.eventTriggers : [];
|
|
await updateTriggerForExistingBookings(webhook, activeTriggersBefore, updatedWebhook.eventTriggers);
|
|
} else if (!data.active && webhook.active) {
|
|
await cancelNoShowTasksForBooking({
|
|
webhook: {
|
|
id: webhook.id,
|
|
userId: webhook.userId,
|
|
teamId: webhook.teamId,
|
|
eventTypeId: webhook.eventTypeId,
|
|
},
|
|
});
|
|
await deleteWebhookScheduledTriggers({ webhookId: webhook.id });
|
|
}
|
|
|
|
return updatedWebhook;
|
|
};
|