Files
calendar/packages/lib/server/service/__tests__/InsightsRoutingService.integration-test.ts
T
Eunjae LeeGitHubeunjae@cal.com <hey@eunjae.dev>Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
a1922efab5 feat: make orgId optional for user and team scopes in /insights and /insights/routing (#23912)
* feat: make orgId optional for user and team scopes in InsightsRoutingBaseService

- User scope authorization only checks formUserId and formTeamId IS NULL
- Team scope now supports standalone teams without organizations
- Add validation logic to return NOTHING_CONDITION if team belongs to org but no orgId provided
- Add comprehensive test coverage for null/undefined orgId scenarios in both scopes
- Aligns schema with actual usage patterns and supports teams without organizations

Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>

* feat: extend orgId optional support to InsightsBookingBaseService

- Make orgId optional for user and team scopes in InsightsBookingBaseService
- Update InsightsBookingServicePublicOptions type to allow orgId: number | null
- Add validation logic for team scope to handle missing orgId
- Add comprehensive test coverage for null/undefined orgId scenarios
- Fix type casting issues in test file
- Maintains backward compatibility while supporting teams without organizations

Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>

* fix: correct authorization logic for optional orgId in team scope

- Skip isOwnerOrAdmin check for team scope when orgId is null (standalone teams)
- Maintain security for org scope and team scope with orgId
- Fixes integration test failures for null orgId test cases

Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>

* fix: use != null instead of !== undefined for orgId checks

- Properly handle both null and undefined orgId values in authorization logic
- Fix integration test failures where null orgId was incorrectly triggering isOwnerOrAdmin check
- Ensure team scope with null orgId skips ownership validation for standalone teams

Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>

* fix: always validate team membership for team scope

- Remove orgId condition from isOwnerOrAdmin check for team scope
- Ensure both standalone teams and org-based teams require ownership validation
- Maintain orgId validation logic in buildTeamAuthorizationCondition methods

Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>

* fix: use nullish() for orgId schema validation

- Change from .optional() to .nullish() to allow both null and undefined
- Fixes schema validation when tests pass orgId: null
- Resolves authorization logic returning NOTHING_CONDITION for valid cases

Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>

* feat: replace isOwnerOrAdmin with PBAC checkPermission in insights services

- Replace isOwnerOrAdmin method in InsightsBookingBaseService with checkPermission from PermissionCheckService
- Replace isOwnerOrAdmin method in InsightsRoutingBaseService with checkPermission from PermissionCheckService
- Use permission 'insights.read' with fallback roles MembershipRole.OWNER and MembershipRole.ADMIN
- Maintain same method signature and behavior while leveraging PBAC system

Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>

* clean up types

* add comment

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2025-09-19 14:13:21 +00:00

1633 lines
47 KiB
TypeScript

import { randomUUID } from "crypto";
import { v4 as uuid } from "uuid";
import { describe, expect, it, vi, beforeAll, afterAll } from "vitest";
import { ColumnFilterType } from "@calcom/features/data-table/lib/types";
import { prisma } from "@calcom/prisma";
import type { Team, User, Membership } from "@calcom/prisma/client";
import { Prisma } from "@calcom/prisma/client";
import { BookingStatus, MembershipRole } from "@calcom/prisma/enums";
import {
InsightsRoutingBaseService as InsightsRoutingService,
type InsightsRoutingServicePublicOptions,
} from "../../service/InsightsRoutingBaseService";
// SQL condition constants for testing
const NOTHING_CONDITION = Prisma.sql`1=0`;
// Helper function to create default filters for testing
const createDefaultFilters = () => ({
startDate: new Date(Date.now() - 2 * 24 * 60 * 60 * 1000).toISOString(),
endDate: new Date().toISOString(),
});
// Helper function to create unique test data
async function createTestData({
teamRole = MembershipRole.MEMBER,
orgRole = MembershipRole.MEMBER,
moreTeamsAndUsers = [],
}: {
teamRole?: MembershipRole;
orgRole?: MembershipRole;
moreTeamsAndUsers?: MembershipRole[][]; // Array of teams, each team has array of user roles
} = {}) {
// Create test user
const user = await prisma.user.create({
data: {
email: `test-user-${randomUUID()}@example.com`,
username: `testuser-${randomUUID()}`,
name: "Test User",
},
});
// Create test organization
const org = await prisma.team.create({
data: {
name: "Test Org",
slug: `test-org-${randomUUID()}`,
isOrganization: true,
},
});
// Create test team under the organization
const team = await prisma.team.create({
data: {
name: "Test Team",
slug: `test-team-${randomUUID()}`,
isOrganization: false,
parentId: org.id,
},
});
// Create test event type
const eventType = await prisma.eventType.create({
data: {
title: "Test Event Type",
slug: `test-event-type-${randomUUID()}`,
length: 60,
userId: user.id,
teamId: team.id,
},
});
// Create test booking
const booking = await prisma.booking.create({
data: {
uid: `test-booking-${randomUUID()}`,
title: "Test Booking",
startTime: new Date(),
endTime: new Date(Date.now() + 60 * 60 * 1000),
userId: user.id,
eventTypeId: eventType.id,
status: BookingStatus.PENDING,
},
});
// Create test routing form
const form = await prisma.app_RoutingForms_Form.create({
data: {
name: "Test Routing Form",
userId: user.id,
teamId: team.id,
fields: [
{
id: `text-field-id-${randomUUID()}`,
type: "text",
label: "Name",
required: true,
},
{
id: `email-field-id-${randomUUID()}`,
type: "email",
label: "Email",
required: true,
},
],
},
});
// Create test form response
const formResponse = await prisma.app_RoutingForms_FormResponse.create({
data: {
formFillerId: `test-filler-${randomUUID()}`,
formId: form.id,
response: {
[`text-field-id-${randomUUID()}`]: {
label: "Name",
value: "Test Name",
},
[`email-field-id-${randomUUID()}`]: {
label: "Email",
value: "test@example.com",
},
},
routedToBookingUid: booking.uid,
},
});
const membership = await prisma.membership.create({
data: {
userId: user.id,
teamId: team.id,
role: teamRole,
accepted: true,
},
});
const orgMembership = await prisma.membership.create({
data: {
userId: user.id,
teamId: org.id,
role: orgRole,
accepted: true,
},
});
// Create additional teams and users based on moreTeamsAndUsers
const additionalTeams: Team[] = [];
const additionalUsers: User[] = [];
const additionalMemberships: Membership[] = [];
for (let i = 0; i < moreTeamsAndUsers.length; i++) {
const teamRoles = moreTeamsAndUsers[i];
const additionalTeam = await prisma.team.create({
data: {
name: `Additional Team ${i + 1}`,
slug: `additional-team-${i + 1}-${randomUUID()}`,
isOrganization: false,
parentId: org.id,
},
});
additionalTeams.push(additionalTeam);
for (let j = 0; j < teamRoles.length; j++) {
const role = teamRoles[j];
const additionalUser = await prisma.user.create({
data: {
email: `additional-user-${i}-${j}-${randomUUID()}@example.com`,
username: `additionaluser-${i}-${j}-${randomUUID()}`,
name: `Additional User ${i}-${j}`,
},
});
additionalUsers.push(additionalUser);
const additionalMembership = await prisma.membership.create({
data: {
userId: additionalUser.id,
teamId: additionalTeam.id,
role: role,
accepted: true,
},
});
additionalMemberships.push(additionalMembership);
}
}
// Cleanup function
const cleanup = async () => {
// Delete in reverse order to avoid foreign key constraints
for (const membership of additionalMemberships) {
await prisma.membership.delete({
where: { id: membership.id },
});
}
for (const user of additionalUsers) {
await prisma.user.delete({
where: { id: user.id },
});
}
for (const team of additionalTeams) {
await prisma.team.delete({
where: { id: team.id },
});
}
await prisma.membership.delete({
where: { id: orgMembership.id },
});
await prisma.membership.delete({
where: { id: membership.id },
});
await prisma.app_RoutingForms_FormResponse.delete({
where: { id: formResponse.id },
});
await prisma.booking.delete({
where: { id: booking.id },
});
await prisma.eventType.delete({
where: { id: eventType.id },
});
await prisma.app_RoutingForms_Form.delete({
where: { id: form.id },
});
await prisma.team.delete({
where: { id: team.id },
});
await prisma.team.delete({
where: { id: org.id },
});
await prisma.user.delete({
where: { id: user.id },
});
};
return {
user,
org,
team,
eventType,
booking,
form,
formResponse,
membership,
orgMembership,
additionalTeams,
additionalUsers,
additionalMemberships,
cleanup,
};
}
describe("InsightsRoutingService Integration Tests", () => {
describe("Authorization Conditions", () => {
it("should return NOTHING for invalid options", async () => {
const service = new InsightsRoutingService({
prisma,
options: null as unknown as InsightsRoutingServicePublicOptions,
filters: createDefaultFilters(),
});
const conditions = await service.getAuthorizationConditions();
expect(conditions).toEqual(NOTHING_CONDITION);
});
it("should return NOTHING for non-owner/admin user", async () => {
const testData = await createTestData();
// Create a regular user who is not an owner/admin
const regularUser = await prisma.user.create({
data: {
email: `regular-user-${randomUUID()}@example.com`,
username: `regularuser-${randomUUID()}`,
name: "Regular User",
},
});
// Add the user as a regular member (not owner/admin) to the organization
const membership = await prisma.membership.create({
data: {
userId: regularUser.id,
teamId: testData.org.id,
role: MembershipRole.MEMBER,
accepted: true,
},
});
const service = new InsightsRoutingService({
prisma,
options: {
scope: "org",
userId: regularUser.id,
orgId: testData.org.id,
teamId: undefined,
},
filters: createDefaultFilters(),
});
const conditions = await service.getAuthorizationConditions();
expect(conditions).toEqual(NOTHING_CONDITION);
// Clean up
await prisma.membership.delete({
where: { id: membership.id },
});
await prisma.user.delete({
where: { id: regularUser.id },
});
await testData.cleanup();
});
it("should build user scope conditions", async () => {
const testData = await createTestData({
teamRole: MembershipRole.OWNER,
orgRole: MembershipRole.OWNER,
});
const service = new InsightsRoutingService({
prisma,
options: {
scope: "user",
userId: testData.user.id,
orgId: testData.org.id,
teamId: undefined,
},
filters: createDefaultFilters(),
});
const conditions = await service.getAuthorizationConditions();
expect(conditions).toEqual(
Prisma.sql`rfrd."formUserId" = ${testData.user.id} AND rfrd."formTeamId" IS NULL`
);
await testData.cleanup();
});
it("should build user scope conditions with null orgId", async () => {
const testData = await createTestData({
teamRole: MembershipRole.OWNER,
orgRole: MembershipRole.OWNER,
});
const service = new InsightsRoutingService({
prisma,
options: {
scope: "user",
userId: testData.user.id,
orgId: null,
teamId: undefined,
},
filters: createDefaultFilters(),
});
const conditions = await service.getAuthorizationConditions();
expect(conditions).toEqual(
Prisma.sql`rfrd."formUserId" = ${testData.user.id} AND rfrd."formTeamId" IS NULL`
);
await testData.cleanup();
});
it("should build user scope conditions with undefined orgId", async () => {
const testData = await createTestData({
teamRole: MembershipRole.OWNER,
orgRole: MembershipRole.OWNER,
});
const service = new InsightsRoutingService({
prisma,
options: {
scope: "user",
userId: testData.user.id,
orgId: null,
teamId: undefined,
},
filters: createDefaultFilters(),
});
const conditions = await service.getAuthorizationConditions();
expect(conditions).toEqual(
Prisma.sql`rfrd."formUserId" = ${testData.user.id} AND rfrd."formTeamId" IS NULL`
);
await testData.cleanup();
});
it("should build team scope conditions", async () => {
const testData = await createTestData({
teamRole: MembershipRole.OWNER,
orgRole: MembershipRole.OWNER,
});
const service = new InsightsRoutingService({
prisma,
options: {
scope: "team",
userId: testData.user.id,
orgId: testData.org.id,
teamId: testData.team.id,
},
filters: createDefaultFilters(),
});
const conditions = await service.getAuthorizationConditions();
expect(conditions).toEqual(Prisma.sql`rfrd."formTeamId" = ${testData.team.id}`);
// Clean up
await testData.cleanup();
});
it("should build org scope conditions", async () => {
const testData = await createTestData({
teamRole: MembershipRole.OWNER,
orgRole: MembershipRole.OWNER,
moreTeamsAndUsers: [
[MembershipRole.MEMBER], // Team 2: 1 user with MEMBER role
[MembershipRole.MEMBER], // Team 3: 1 user with MEMBER role
],
});
// Get references to additional data
const team2 = testData.additionalTeams[0]; // First additional team
const team3 = testData.additionalTeams[1]; // Second additional team
const service = new InsightsRoutingService({
prisma,
options: {
scope: "org",
userId: testData.user.id,
orgId: testData.org.id,
teamId: undefined,
},
filters: createDefaultFilters(),
});
const conditions = await service.getAuthorizationConditions();
// Build expected team IDs array for org scope
const expectedTeamIds = [testData.org.id, testData.team.id, team2.id, team3.id];
expect(conditions).toEqual(
Prisma.sql`(rfrd."formTeamId" = ANY(${expectedTeamIds})) OR (rfrd."formUserId" = ${testData.user.id} AND rfrd."formTeamId" IS NULL)`
);
await testData.cleanup();
});
it("should return NOTHING for team scope when team is not child of org", async () => {
const testData = await createTestData({
teamRole: MembershipRole.OWNER,
orgRole: MembershipRole.OWNER,
});
// Create a team that is not a child of the org
const unrelatedTeam = await prisma.team.create({
data: {
name: "Unrelated Team",
slug: `unrelated-team-${randomUUID()}`,
isOrganization: false,
parentId: null, // Not part of the org
},
});
const service = new InsightsRoutingService({
prisma,
options: {
scope: "team",
userId: testData.user.id,
orgId: testData.org.id,
teamId: unrelatedTeam.id,
},
filters: createDefaultFilters(),
});
const conditions = await service.getAuthorizationConditions();
expect(conditions).toEqual(NOTHING_CONDITION);
// Clean up
await prisma.team.delete({
where: { id: unrelatedTeam.id },
});
await testData.cleanup();
});
it("should build team scope conditions with null orgId for standalone team", async () => {
const testData = await createTestData({
teamRole: MembershipRole.OWNER,
orgRole: MembershipRole.OWNER,
});
const standaloneTeam = await prisma.team.create({
data: {
name: "Standalone Team",
slug: `standalone-team-${randomUUID()}`,
isOrganization: false,
parentId: null,
},
});
await prisma.membership.create({
data: {
userId: testData.user.id,
teamId: standaloneTeam.id,
role: MembershipRole.OWNER,
accepted: true,
},
});
const service = new InsightsRoutingService({
prisma,
options: {
scope: "team",
userId: testData.user.id,
orgId: null,
teamId: standaloneTeam.id,
},
filters: createDefaultFilters(),
});
const conditions = await service.getAuthorizationConditions();
expect(conditions).toEqual(Prisma.sql`rfrd."formTeamId" = ${standaloneTeam.id}`);
await prisma.membership.deleteMany({
where: { teamId: standaloneTeam.id },
});
await prisma.team.delete({
where: { id: standaloneTeam.id },
});
await testData.cleanup();
});
it("should return NOTHING_CONDITION for team scope when team belongs to org but no orgId provided", async () => {
const testData = await createTestData({
teamRole: MembershipRole.OWNER,
orgRole: MembershipRole.OWNER,
});
const service = new InsightsRoutingService({
prisma,
options: {
scope: "team",
userId: testData.user.id,
orgId: null,
teamId: testData.team.id,
},
filters: createDefaultFilters(),
});
const conditions = await service.getAuthorizationConditions();
expect(conditions).toEqual(NOTHING_CONDITION);
await testData.cleanup();
});
it("should build team scope conditions with undefined orgId for standalone team", async () => {
const testData = await createTestData({
teamRole: MembershipRole.OWNER,
orgRole: MembershipRole.OWNER,
});
const standaloneTeam = await prisma.team.create({
data: {
name: "Standalone Team 2",
slug: `standalone-team-2-${randomUUID()}`,
isOrganization: false,
parentId: null,
},
});
await prisma.membership.create({
data: {
userId: testData.user.id,
teamId: standaloneTeam.id,
role: MembershipRole.OWNER,
accepted: true,
},
});
const service = new InsightsRoutingService({
prisma,
options: {
scope: "team",
userId: testData.user.id,
orgId: null,
teamId: standaloneTeam.id,
},
filters: createDefaultFilters(),
});
const conditions = await service.getAuthorizationConditions();
expect(conditions).toEqual(Prisma.sql`rfrd."formTeamId" = ${standaloneTeam.id}`);
await prisma.membership.deleteMany({
where: { teamId: standaloneTeam.id },
});
await prisma.team.delete({
where: { id: standaloneTeam.id },
});
await testData.cleanup();
});
});
describe("Filter Conditions", () => {
it("should build filter conditions when dates are provided", async () => {
const testData = await createTestData();
const service = new InsightsRoutingService({
prisma,
options: {
scope: "user",
userId: testData.user.id,
orgId: testData.org.id,
teamId: undefined,
},
filters: {
startDate: "2024-01-01",
endDate: "2024-12-31",
},
});
const conditions = await service.getFilterConditions();
expect(conditions).toEqual(
Prisma.sql`rfrd."createdAt" >= ${"2024-01-01"}::timestamp AND rfrd."createdAt" <= ${"2024-12-31"}::timestamp`
);
await testData.cleanup();
});
});
describe("Caching", () => {
it("should cache authorization conditions", async () => {
const testData = await createTestData({
teamRole: MembershipRole.OWNER,
orgRole: MembershipRole.OWNER,
});
const service = new InsightsRoutingService({
prisma,
options: {
scope: "user",
userId: testData.user.id,
orgId: testData.org.id,
teamId: undefined,
},
filters: createDefaultFilters(),
});
// First call should build conditions
const conditions1 = await service.getAuthorizationConditions();
expect(conditions1).toEqual(
Prisma.sql`rfrd."formUserId" = ${testData.user.id} AND rfrd."formTeamId" IS NULL`
);
// Second call should use cached conditions
const conditions2 = await service.getAuthorizationConditions();
expect(conditions2).toEqual(conditions1);
// Clean up
await testData.cleanup();
});
it("should cache filter conditions", async () => {
const testData = await createTestData();
const service = new InsightsRoutingService({
prisma,
options: {
scope: "user",
userId: testData.user.id,
orgId: testData.org.id,
teamId: undefined,
},
filters: createDefaultFilters(),
});
// First call should build conditions
const conditions1 = await service.getFilterConditions();
expect(conditions1).toBeDefined();
// Second call should use cached conditions
const conditions2 = await service.getFilterConditions();
expect(conditions2).toEqual(conditions1);
await testData.cleanup();
});
});
describe("getBaseConditions", () => {
it("should combine authorization and filter conditions", async () => {
const testData = await createTestData({
teamRole: MembershipRole.OWNER,
orgRole: MembershipRole.OWNER,
});
const filters = createDefaultFilters();
const dateCondition = Prisma.sql`rfrd."createdAt" >= ${filters.startDate}::timestamp AND rfrd."createdAt" <= ${filters.endDate}::timestamp`;
const service = new InsightsRoutingService({
prisma,
options: {
scope: "user",
userId: testData.user.id,
orgId: testData.org.id,
teamId: undefined,
},
filters,
});
const results = await service.getBaseConditions();
expect(results).toEqual(
Prisma.sql`((rfrd."formUserId" = ${testData.user.id} AND rfrd."formTeamId" IS NULL) AND (${dateCondition}))`
);
await testData.cleanup();
});
it("should include personal form in org scope", async () => {
const testData = await createTestData({
teamRole: MembershipRole.OWNER,
orgRole: MembershipRole.OWNER,
});
const personalForm = await prisma.app_RoutingForms_Form.create({
data: {
name: "My Personal Form",
userId: testData.user.id,
teamId: null,
fields: [
{
id: "text-field-id",
type: "text",
label: "Name",
required: true,
},
],
},
});
const personalFormResponse = await prisma.app_RoutingForms_FormResponse.create({
data: {
formFillerId: `personal-form-filler-${randomUUID()}`,
formId: personalForm.id,
response: {
"text-field-id": {
label: "Name",
value: "Personal Form Response",
},
},
},
});
const service = new InsightsRoutingService({
prisma,
options: {
scope: "org",
userId: testData.user.id,
orgId: testData.org.id,
teamId: undefined,
},
filters: createDefaultFilters(),
});
const baseConditions = await service.getBaseConditions();
const results = await prisma.$queryRaw<Array<{ id: number }>>`
SELECT id FROM "RoutingFormResponseDenormalized" rfrd WHERE ${baseConditions}
`;
// Should only return the authorized user's form response
expect(results).toHaveLength(2);
expect(results[0]?.id).toBe(testData.formResponse.id);
expect(results[1]?.id).toBe(personalFormResponse.id);
// Clean up
await prisma.app_RoutingForms_FormResponse.delete({
where: { id: personalFormResponse.id },
});
await prisma.app_RoutingForms_Form.delete({
where: { id: personalForm.id },
});
await testData.cleanup();
});
it("should get personal form response", async () => {
const testData = await createTestData({
teamRole: MembershipRole.OWNER,
orgRole: MembershipRole.OWNER,
});
const personalForm = await prisma.app_RoutingForms_Form.create({
data: {
name: "My Personal Form",
userId: testData.user.id,
teamId: null,
fields: [
{
id: "text-field-id",
type: "text",
label: "Name",
required: true,
},
],
},
});
const personalFormResponse = await prisma.app_RoutingForms_FormResponse.create({
data: {
formFillerId: `personal-form-filler-${randomUUID()}`,
formId: personalForm.id,
response: {
"text-field-id": {
label: "Name",
value: "Personal Form Response",
},
},
},
});
// Create another user and form
const otherUser = await prisma.user.create({
data: {
email: `other-user-${randomUUID()}@example.com`,
username: `otheruser-${randomUUID()}`,
name: "Other User",
},
});
const otherForm = await prisma.app_RoutingForms_Form.create({
data: {
name: "Other User Form",
userId: otherUser.id,
teamId: null,
fields: [
{
id: "text-field-id",
type: "text",
label: "Name",
required: true,
},
],
},
});
const otherFormResponse = await prisma.app_RoutingForms_FormResponse.create({
data: {
formFillerId: `other-form-filler-${randomUUID()}`,
formId: otherForm.id,
response: {
"text-field-id": {
label: "Name",
value: "Other Form Response",
},
},
},
});
const service = new InsightsRoutingService({
prisma,
options: {
scope: "user",
userId: testData.user.id,
orgId: testData.org.id,
teamId: undefined,
},
filters: createDefaultFilters(),
});
const baseConditions = await service.getBaseConditions();
const results = await prisma.$queryRaw<Array<{ id: number }>>`
SELECT id FROM "RoutingFormResponseDenormalized" rfrd WHERE ${baseConditions}
`;
// Should only return the authorized user's form response
expect(results).toHaveLength(1);
expect(results[0]?.id).toBe(personalFormResponse.id);
expect(results[0]?.id).not.toBe(otherFormResponse.id);
// Clean up
await prisma.app_RoutingForms_FormResponse.deleteMany({
where: { id: { in: [personalFormResponse.id, otherFormResponse.id] } },
});
await prisma.app_RoutingForms_Form.deleteMany({
where: { id: { in: [personalForm.id, otherForm.id] } },
});
await prisma.user.delete({
where: { id: otherUser.id },
});
await testData.cleanup();
});
it("should fetch all forms in org scope when user is in same team", async () => {
const testData = await createTestData({
teamRole: MembershipRole.OWNER,
orgRole: MembershipRole.OWNER,
});
// Create another user in the same team
const teamMember = await prisma.user.create({
data: {
email: `team-member-${randomUUID()}@example.com`,
username: `teammember-${randomUUID()}`,
name: "Team Member",
},
});
// Add the team member to the same team
const teamMembership = await prisma.membership.create({
data: {
userId: teamMember.id,
teamId: testData.team.id,
role: MembershipRole.MEMBER,
accepted: true,
},
});
// Create a form under the team member
const teamMemberForm = await prisma.app_RoutingForms_Form.create({
data: {
name: "Team Member Form",
userId: teamMember.id,
teamId: testData.team.id, // Same team as the original user
fields: [
{
id: `text-field-id-${randomUUID()}`,
type: "text",
label: "Name",
required: true,
},
],
},
});
// Create a form response for the team member's form
const teamMemberFormResponse = await prisma.app_RoutingForms_FormResponse.create({
data: {
formFillerId: `team-member-form-filler-${randomUUID()}`,
formId: teamMemberForm.id,
response: {
[`text-field-id-${randomUUID()}`]: {
label: "Name",
value: "Team Member Form Response",
},
},
},
});
const service = new InsightsRoutingService({
prisma,
options: {
scope: "org",
userId: testData.user.id,
orgId: testData.org.id,
teamId: undefined,
},
filters: createDefaultFilters(),
});
const baseConditions = await service.getBaseConditions();
const results = await prisma.$queryRaw<Array<{ id: number }>>`
SELECT id FROM "RoutingFormResponseDenormalized" rfrd WHERE ${baseConditions}
`;
// Should return both form responses (original user's and team member's)
expect(results).toHaveLength(2);
const responseIds = results.map((r) => r.id).sort();
const expectedIds = [testData.formResponse.id, teamMemberFormResponse.id].sort();
expect(responseIds).toEqual(expectedIds);
// Clean up
await prisma.app_RoutingForms_FormResponse.delete({
where: { id: teamMemberFormResponse.id },
});
await prisma.app_RoutingForms_Form.delete({
where: { id: teamMemberForm.id },
});
await prisma.membership.delete({
where: { id: teamMembership.id },
});
await prisma.user.delete({
where: { id: teamMember.id },
});
await testData.cleanup();
});
});
describe("columnFilters", () => {
beforeAll(() => {
vi.useFakeTimers().setSystemTime(new Date("2025-08-20T00:00:00.000Z"));
});
afterAll(() => {
vi.useRealTimers();
vi.restoreAllMocks();
});
it("should handle empty columnFilters", async () => {
const testData = await createTestData({
teamRole: MembershipRole.OWNER,
orgRole: MembershipRole.OWNER,
});
const defaultFilters = createDefaultFilters();
const service = new InsightsRoutingService({
prisma,
options: {
scope: "user",
userId: testData.user.id,
orgId: testData.org.id,
teamId: undefined,
},
filters: {
...defaultFilters,
columnFilters: [],
},
});
const filterConditions = await service.getFilterConditions();
expect(filterConditions).toEqual(
Prisma.sql`rfrd."createdAt" >= ${defaultFilters.startDate}::timestamp AND rfrd."createdAt" <= ${defaultFilters.endDate}::timestamp`
);
await testData.cleanup();
});
it("should handle undefined columnFilters", async () => {
const testData = await createTestData({
teamRole: MembershipRole.OWNER,
orgRole: MembershipRole.OWNER,
});
const defaultFilters = createDefaultFilters();
const service = new InsightsRoutingService({
prisma,
options: {
scope: "user",
userId: testData.user.id,
orgId: testData.org.id,
teamId: undefined,
},
filters: {
...defaultFilters,
columnFilters: undefined,
},
});
const filterConditions = await service.getFilterConditions();
expect(filterConditions).toEqual(
Prisma.sql`rfrd."createdAt" >= ${defaultFilters.startDate}::timestamp AND rfrd."createdAt" <= ${defaultFilters.endDate}::timestamp`
);
await testData.cleanup();
});
it("should filter by booking status order (multi-select)", async () => {
const testData = await createTestData({
teamRole: MembershipRole.OWNER,
orgRole: MembershipRole.OWNER,
});
const defaultFilters = createDefaultFilters();
const service = new InsightsRoutingService({
prisma,
options: {
scope: "user",
userId: testData.user.id,
orgId: testData.org.id,
teamId: undefined,
},
filters: {
...defaultFilters,
columnFilters: [
{
id: "bookingStatusOrder",
value: {
type: ColumnFilterType.MULTI_SELECT,
data: ["pending", "accepted"],
},
},
],
},
});
const filterConditions = await service.getFilterConditions();
expect(filterConditions).toEqual(
Prisma.sql`(rfrd."createdAt" >= ${defaultFilters.startDate}::timestamp AND rfrd."createdAt" <= ${
defaultFilters.endDate
}::timestamp) AND (rfrd."bookingStatusOrder" = ANY(${["pending", "accepted"]}))`
);
await testData.cleanup();
});
it("should filter by booking assignment reason (text)", async () => {
const testData = await createTestData({
teamRole: MembershipRole.OWNER,
orgRole: MembershipRole.OWNER,
});
const defaultFilters = createDefaultFilters();
const service = new InsightsRoutingService({
prisma,
options: {
scope: "user",
userId: testData.user.id,
orgId: testData.org.id,
teamId: undefined,
},
filters: {
...defaultFilters,
columnFilters: [
{
id: "bookingAssignmentReason",
value: {
type: ColumnFilterType.TEXT,
data: { operator: "contains", operand: "manual" },
},
},
],
},
});
const filterConditions = await service.getFilterConditions();
expect(filterConditions).toEqual(
Prisma.sql`(rfrd."createdAt" >= ${defaultFilters.startDate}::timestamp AND rfrd."createdAt" <= ${
defaultFilters.endDate
}::timestamp) AND (rfrd."bookingAssignmentReason" ILIKE ${`%manual%`})`
);
await testData.cleanup();
});
it("should filter by booking UID (text)", async () => {
const testData = await createTestData({
teamRole: MembershipRole.OWNER,
orgRole: MembershipRole.OWNER,
});
const defaultFilters = createDefaultFilters();
const service = new InsightsRoutingService({
prisma,
options: {
scope: "user",
userId: testData.user.id,
orgId: testData.org.id,
teamId: undefined,
},
filters: {
...defaultFilters,
columnFilters: [
{
id: "bookingUid",
value: {
type: ColumnFilterType.TEXT,
data: { operator: "equals", operand: "test-booking-123" },
},
},
],
},
});
const filterConditions = await service.getFilterConditions();
expect(filterConditions).toEqual(
Prisma.sql`(rfrd."createdAt" >= ${defaultFilters.startDate}::timestamp AND rfrd."createdAt" <= ${
defaultFilters.endDate
}::timestamp) AND (rfrd."bookingUid" = ${"test-booking-123"})`
);
await testData.cleanup();
});
it("should filter by member user IDs (multi-select)", async () => {
const testData = await createTestData({
teamRole: MembershipRole.OWNER,
orgRole: MembershipRole.OWNER,
});
const defaultFilters = createDefaultFilters();
const service = new InsightsRoutingService({
prisma,
options: {
scope: "user",
userId: testData.user.id,
orgId: testData.org.id,
teamId: undefined,
},
filters: {
...defaultFilters,
columnFilters: [
{
id: "bookingUserId",
value: {
type: ColumnFilterType.MULTI_SELECT,
data: [testData.user.id, 999],
},
},
],
},
});
const filterConditions = await service.getFilterConditions();
expect(filterConditions).toEqual(
Prisma.sql`(rfrd."createdAt" >= ${defaultFilters.startDate}::timestamp AND rfrd."createdAt" <= ${
defaultFilters.endDate
}::timestamp) AND (rfrd."bookingUserId" = ANY(${[testData.user.id, 999]}))`
);
await testData.cleanup();
});
it("should filter by attendee name (text)", async () => {
const testData = await createTestData({
teamRole: MembershipRole.OWNER,
orgRole: MembershipRole.OWNER,
});
const defaultFilters = createDefaultFilters();
const service = new InsightsRoutingService({
prisma,
options: {
scope: "user",
userId: testData.user.id,
orgId: testData.org.id,
teamId: undefined,
},
filters: {
...defaultFilters,
columnFilters: [
{
id: "attendeeName",
value: {
type: ColumnFilterType.TEXT,
data: { operator: "contains", operand: "john" },
},
},
],
},
});
const filterConditions = await service.getFilterConditions();
expect(filterConditions).toEqual(
Prisma.sql`(rfrd."createdAt" >= ${defaultFilters.startDate}::timestamp AND rfrd."createdAt" <= ${
defaultFilters.endDate
}::timestamp) AND (EXISTS (
SELECT 1 FROM "Booking" b
INNER JOIN "Attendee" a ON a."bookingId" = b."id"
WHERE b."uid" = rfrd."bookingUid"
AND a.name ILIKE ${"%john%"}
))`
);
await testData.cleanup();
});
it("should filter by attendee email (text)", async () => {
const testData = await createTestData({
teamRole: MembershipRole.OWNER,
orgRole: MembershipRole.OWNER,
});
const defaultFilters = createDefaultFilters();
const service = new InsightsRoutingService({
prisma,
options: {
scope: "user",
userId: testData.user.id,
orgId: testData.org.id,
teamId: undefined,
},
filters: {
...defaultFilters,
columnFilters: [
{
id: "attendeeEmail",
value: {
type: ColumnFilterType.TEXT,
data: { operator: "endsWith", operand: "@gmail.com" },
},
},
],
},
});
const filterConditions = await service.getFilterConditions();
expect(filterConditions).toEqual(
Prisma.sql`(rfrd."createdAt" >= ${defaultFilters.startDate}::timestamp AND rfrd."createdAt" <= ${
defaultFilters.endDate
}::timestamp) AND (EXISTS (
SELECT 1 FROM "Booking" b
INNER JOIN "Attendee" a ON a."bookingId" = b."id"
WHERE b."uid" = rfrd."bookingUid"
AND a.email ILIKE ${"%@gmail.com"}
))`
);
await testData.cleanup();
});
it("should filter by attendee phone number (text)", async () => {
const testData = await createTestData({
teamRole: MembershipRole.OWNER,
orgRole: MembershipRole.OWNER,
});
const defaultFilters = createDefaultFilters();
const service = new InsightsRoutingService({
prisma,
options: {
scope: "user",
userId: testData.user.id,
orgId: testData.org.id,
teamId: undefined,
},
filters: {
...defaultFilters,
columnFilters: [
{
id: "attendeePhone",
value: {
type: ColumnFilterType.TEXT,
data: { operator: "contains", operand: "000" },
},
},
],
},
});
const filterConditions = await service.getFilterConditions();
expect(filterConditions).toEqual(
Prisma.sql`(rfrd."createdAt" >= ${defaultFilters.startDate}::timestamp AND rfrd."createdAt" <= ${
defaultFilters.endDate
}::timestamp) AND (EXISTS (
SELECT 1 FROM "Booking" b
INNER JOIN "Attendee" a ON a."bookingId" = b."id"
WHERE b."uid" = rfrd."bookingUid"
AND a."phoneNumber" ILIKE ${"%000%"}
))`
);
await testData.cleanup();
});
it("should filter by custom form fields (text)", async () => {
const customFieldId = uuid();
const testData = await createTestData({
teamRole: MembershipRole.OWNER,
orgRole: MembershipRole.OWNER,
});
const defaultFilters = createDefaultFilters();
const service = new InsightsRoutingService({
prisma,
options: {
scope: "user",
userId: testData.user.id,
orgId: testData.org.id,
teamId: undefined,
},
filters: {
...defaultFilters,
columnFilters: [
{
id: customFieldId,
value: {
type: ColumnFilterType.TEXT,
data: { operator: "equals", operand: "test value" },
},
},
],
},
});
const filterConditions = await service.getFilterConditions();
expect(filterConditions).toEqual(
Prisma.sql`(rfrd."createdAt" >= ${defaultFilters.startDate}::timestamp AND rfrd."createdAt" <= ${
defaultFilters.endDate
}::timestamp) AND (EXISTS (
SELECT 1 FROM "RoutingFormResponseField" rrf
WHERE rrf."responseId" = rfrd."id"
AND rrf."fieldId" = ${customFieldId}
AND rrf."valueString" = ${"test value"}
))`
);
await testData.cleanup();
});
it("should filter by custom form fields (multi-select)", async () => {
const testData = await createTestData({
teamRole: MembershipRole.OWNER,
orgRole: MembershipRole.OWNER,
});
const customFieldId = uuid();
const defaultFilters = createDefaultFilters();
const service = new InsightsRoutingService({
prisma,
options: {
scope: "user",
userId: testData.user.id,
orgId: testData.org.id,
teamId: undefined,
},
filters: {
...defaultFilters,
columnFilters: [
{
id: customFieldId,
value: {
type: ColumnFilterType.MULTI_SELECT,
data: ["option1", "option2"],
},
},
],
},
});
const filterConditions = await service.getFilterConditions();
expect(filterConditions).toEqual(
Prisma.sql`(rfrd."createdAt" >= ${defaultFilters.startDate}::timestamp AND rfrd."createdAt" <= ${
defaultFilters.endDate
}::timestamp) AND (EXISTS (
SELECT 1 FROM "RoutingFormResponseField" rrf
WHERE rrf."responseId" = rfrd."id"
AND rrf."fieldId" = ${customFieldId}
AND rrf."valueStringArray" @> ${["option1", "option2"]}
))`
);
await testData.cleanup();
});
it("should combine multiple filters with AND", async () => {
const customFieldId = uuid();
const testData = await createTestData({
teamRole: MembershipRole.OWNER,
orgRole: MembershipRole.OWNER,
});
const defaultFilters = createDefaultFilters();
const service = new InsightsRoutingService({
prisma,
options: {
scope: "user",
userId: testData.user.id,
orgId: testData.org.id,
teamId: undefined,
},
filters: {
...defaultFilters,
columnFilters: [
{
id: "bookingStatusOrder",
value: {
type: ColumnFilterType.MULTI_SELECT,
data: ["pending"],
},
},
{
id: "bookingAssignmentReason",
value: {
type: ColumnFilterType.TEXT,
data: { operator: "contains", operand: "manual" },
},
},
{
id: customFieldId,
value: {
type: ColumnFilterType.TEXT,
data: { operator: "equals", operand: "test" },
},
},
],
},
});
const filterConditions = await service.getFilterConditions();
expect(filterConditions).toEqual(
Prisma.sql`(((rfrd."createdAt" >= ${defaultFilters.startDate}::timestamp AND rfrd."createdAt" <= ${
defaultFilters.endDate
}::timestamp) AND (rfrd."bookingStatusOrder" = ANY(${[
"pending",
]}))) AND (rfrd."bookingAssignmentReason" ILIKE ${`%manual%`})) AND (EXISTS (
SELECT 1 FROM "RoutingFormResponseField" rrf
WHERE rrf."responseId" = rfrd."id"
AND rrf."fieldId" = ${customFieldId}
AND rrf."valueString" = ${"test"}
))`
);
await testData.cleanup();
});
it("should filter by form ID (single-select)", async () => {
const testData = await createTestData({
teamRole: MembershipRole.OWNER,
orgRole: MembershipRole.OWNER,
});
const defaultFilters = createDefaultFilters();
const service = new InsightsRoutingService({
prisma,
options: {
scope: "user",
userId: testData.user.id,
orgId: testData.org.id,
teamId: undefined,
},
filters: {
...defaultFilters,
columnFilters: [
{
id: "formId",
value: {
type: ColumnFilterType.SINGLE_SELECT,
data: "form-123",
},
},
],
},
});
const filterConditions = await service.getFilterConditions();
expect(filterConditions).toEqual(
Prisma.sql`(rfrd."createdAt" >= ${defaultFilters.startDate}::timestamp AND rfrd."createdAt" <= ${
defaultFilters.endDate
}::timestamp) AND (rfrd."formId" = ${"form-123"})`
);
await testData.cleanup();
});
it("should filter by form ID with other filters", async () => {
const testData = await createTestData({
teamRole: MembershipRole.OWNER,
orgRole: MembershipRole.OWNER,
});
const defaultFilters = createDefaultFilters();
const service = new InsightsRoutingService({
prisma,
options: {
scope: "user",
userId: testData.user.id,
orgId: testData.org.id,
teamId: undefined,
},
filters: {
...defaultFilters,
columnFilters: [
{
id: "formId",
value: {
type: ColumnFilterType.SINGLE_SELECT,
data: "form-456",
},
},
{
id: "bookingStatusOrder",
value: {
type: ColumnFilterType.MULTI_SELECT,
data: ["pending", "accepted"],
},
},
],
},
});
const filterConditions = await service.getFilterConditions();
expect(filterConditions).toEqual(
Prisma.sql`((rfrd."createdAt" >= ${defaultFilters.startDate}::timestamp AND rfrd."createdAt" <= ${
defaultFilters.endDate
}::timestamp) AND (rfrd."bookingStatusOrder" = ANY(${[
"pending",
"accepted",
]}))) AND (rfrd."formId" = ${"form-456"})`
);
await testData.cleanup();
});
it("should exclude system filters from form field processing", async () => {
const testData = await createTestData({
teamRole: MembershipRole.OWNER,
orgRole: MembershipRole.OWNER,
});
const customFieldId = uuid();
const defaultFilters = createDefaultFilters();
const service = new InsightsRoutingService({
prisma,
options: {
scope: "user",
userId: testData.user.id,
orgId: testData.org.id,
teamId: undefined,
},
filters: {
...defaultFilters,
columnFilters: [
{
id: "bookingStatusOrder", // System filter
value: {
type: ColumnFilterType.MULTI_SELECT,
data: ["pending"],
},
},
{
id: customFieldId, // Custom field filter
value: {
type: ColumnFilterType.TEXT,
data: { operator: "equals", operand: "test" },
},
},
],
},
});
const filterConditions = await service.getFilterConditions();
expect(filterConditions).toEqual(
Prisma.sql`((rfrd."createdAt" >= ${defaultFilters.startDate}::timestamp AND rfrd."createdAt" <= ${
defaultFilters.endDate
}::timestamp) AND (rfrd."bookingStatusOrder" = ANY(${["pending"]}))) AND (EXISTS (
SELECT 1 FROM "RoutingFormResponseField" rrf
WHERE rrf."responseId" = rfrd."id"
AND rrf."fieldId" = ${customFieldId}
AND rrf."valueString" = ${"test"}
))`
);
await testData.cleanup();
});
});
});