* feat: add Webhook resource to PBAC system with permission enforcement - Add Webhook resource to PBAC permission registry with CRUD actions - Implement PBAC permission checks in webhook handlers (create, edit, delete) - Add webhook permission translations to common.json - Use PermissionCheckService with fallback roles [ADMIN, OWNER] for team webhooks - Maintain backward compatibility when PBAC is disabled - Follow same pattern as workflow PBAC implementation from PR #22845 Co-Authored-By: sean@cal.com <Sean@brydon.io> * fix: implement PBAC permission filtering in webhook list handler - Add PermissionCheckService to filter team webhooks by webhook.read permission - Only show webhooks from teams where user has proper permissions - Maintain backward compatibility with fallback to all team memberships Co-Authored-By: sean@cal.com <Sean@brydon.io> * add migration for default roles * new forUserMethod * update webhook repository * fix UI showing/hiding webhooks for webhoo.create teams * WIP pbac procedure migratoin + tests * add more roles to get fallback * permissions in cmponents instead of readOnly * passPermissions to list item * push instant events logic * Git merge * wip teamId accessable refactor * fix delete handler --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
97 lines
3.4 KiB
TypeScript
97 lines
3.4 KiB
TypeScript
"use client";
|
|
|
|
import { useRouter } from "next/navigation";
|
|
|
|
import SettingsHeader from "@calcom/features/settings/appDir/SettingsHeader";
|
|
import { APP_NAME, WEBAPP_URL } from "@calcom/lib/constants";
|
|
import { useBookerUrl } from "@calcom/lib/hooks/useBookerUrl";
|
|
import { useLocale } from "@calcom/lib/hooks/useLocale";
|
|
import type { RouterOutputs } from "@calcom/trpc/react";
|
|
import classNames from "@calcom/ui/classNames";
|
|
import { Avatar } from "@calcom/ui/components/avatar";
|
|
import { EmptyScreen } from "@calcom/ui/components/empty-screen";
|
|
|
|
import { WebhookListItem, CreateNewWebhookButton } from "../components";
|
|
|
|
type WebhooksByViewer = RouterOutputs["viewer"]["webhook"]["getByViewer"];
|
|
|
|
type Props = {
|
|
data: WebhooksByViewer;
|
|
};
|
|
|
|
const WebhooksView = ({ data }: Props) => {
|
|
return (
|
|
<div>
|
|
<WebhooksList webhooksByViewer={data} />
|
|
</div>
|
|
);
|
|
};
|
|
|
|
const WebhooksList = ({ webhooksByViewer }: { webhooksByViewer: WebhooksByViewer }) => {
|
|
const { t } = useLocale();
|
|
const router = useRouter();
|
|
const { profiles, webhookGroups } = webhooksByViewer;
|
|
const bookerUrl = useBookerUrl();
|
|
|
|
const hasTeams = profiles && profiles.length > 1;
|
|
|
|
return (
|
|
<SettingsHeader
|
|
title={t("webhooks")}
|
|
description={t("add_webhook_description", { appName: APP_NAME })}
|
|
CTA={webhooksByViewer.webhookGroups.length > 0 ? <CreateNewWebhookButton /> : null}
|
|
borderInShellHeader={false}>
|
|
{!!webhookGroups.length ? (
|
|
<div className={classNames("mt-6")}>
|
|
{webhookGroups.map((group) => (
|
|
<div key={group.teamId}>
|
|
{hasTeams && (
|
|
<div className="items-centers flex">
|
|
<Avatar
|
|
alt={group.profile.image || ""}
|
|
imageSrc={group.profile.image || `${bookerUrl}/${group.profile.name}/avatar.png`}
|
|
size="md"
|
|
className="inline-flex justify-center"
|
|
/>
|
|
<div className="text-emphasis ml-2 flex flex-grow items-center font-bold">
|
|
{group.profile.name || ""}
|
|
</div>
|
|
</div>
|
|
)}
|
|
<div className="flex flex-col" key={group.profile.slug}>
|
|
<div className={classNames("border-subtle mb-8 mt-3 rounded-lg border border-t")}>
|
|
{group.webhooks.map((webhook, index) => (
|
|
<WebhookListItem
|
|
key={webhook.id}
|
|
webhook={webhook}
|
|
lastItem={group.webhooks.length === index + 1}
|
|
permissions={{
|
|
canEditWebhook: group?.metadata?.canModify ?? false,
|
|
canDeleteWebhook: group?.metadata?.canDelete ?? false,
|
|
}}
|
|
onEditWebhook={() =>
|
|
router.push(`${WEBAPP_URL}/settings/developer/webhooks/${webhook.id}`)
|
|
}
|
|
/>
|
|
))}
|
|
</div>
|
|
</div>
|
|
</div>
|
|
))}
|
|
</div>
|
|
) : (
|
|
<EmptyScreen
|
|
Icon="link"
|
|
headline={t("create_your_first_webhook")}
|
|
description={t("create_your_first_webhook_description", { appName: APP_NAME })}
|
|
className="mt-6 rounded-b-lg"
|
|
buttonRaw={<CreateNewWebhookButton />}
|
|
border={true}
|
|
/>
|
|
)}
|
|
</SettingsHeader>
|
|
);
|
|
};
|
|
|
|
export default WebhooksView;
|