f4248bf20d
* feat: implement FeatureOptInService WIP * clean up * feat: consolidate feature repositories and add updateFeatureForUser - Implement updateFeatureForUser in FeaturesRepository (similar to updateFeatureForTeam) - Move getUserFeatureState and getTeamFeatureState from PrismaFeatureOptInRepository to FeaturesRepository - Update FeatureOptInService to use only FeaturesRepository - Add setUserFeatureState and setTeamFeatureState methods to FeatureOptInService - Update _router.ts to remove PrismaFeatureOptInRepository usage - Remove PrismaFeatureOptInRepository.ts and FeatureOptInRepositoryInterface.ts - Update features.repository.interface.ts and features.repository.mock.ts - Add integration tests for updateFeatureForUser, getUserFeatureState, getTeamFeatureState - Update service.integration-test.ts to use FeaturesRepository Co-Authored-By: eunjae@cal.com <hey@eunjae.dev> * refactor: rename updateFeatureForUser to setUserFeatureState Rename to match the convention used for setTeamFeatureState Co-Authored-By: eunjae@cal.com <hey@eunjae.dev> * refactor: return FeatureState type from getUserFeatureState and getTeamFeatureState * fix integration tests * clean up logics * update services and router * refactor: change getUserFeatureState and getTeamFeatureState to accept featureIds array - Renamed getUserFeatureState to getUserFeatureStates - Renamed getTeamFeatureState to getTeamFeatureStates - Changed parameter from featureId: string to featureIds: string[] - Changed return type from FeatureState to Record<string, FeatureState> - Updated FeatureOptInService to use the new batch methods - Added tests for querying multiple features in a single call - Optimized listFeaturesForTeam to fetch all feature states in one query Co-Authored-By: eunjae@cal.com <hey@eunjae.dev> * feat: add getFeatureStateForTeams for batch querying multiple teams - Added getFeatureStateForTeams method to query a single feature across multiple teams in one call - Updated FeatureOptInService.resolveFeatureStateAcrossTeams to use the new batch method - Replaces N+1 queries with a single database query for team states - Added comprehensive integration tests for the new method Co-Authored-By: eunjae@cal.com <hey@eunjae.dev> * refactor: combine org and team state queries into single call - Include orgId in the teamIds array passed to getFeatureStateForTeams - Extract org state and team states from the combined result - Reduces database queries from 3 to 2 in resolveFeatureStateAcrossTeams Co-Authored-By: eunjae@cal.com <hey@eunjae.dev> * refactor: use team.isOrganization and clarify computeEffectiveState comment Co-Authored-By: eunjae@cal.com <hey@eunjae.dev> * refactor: use MembershipRepository.findAllByUserId with isOrganization Co-Authored-By: eunjae@cal.com <hey@eunjae.dev> * feat: add featureId validation using isOptInFeature type guard Co-Authored-By: eunjae@cal.com <hey@eunjae.dev> * less queries * add fallback value * fix type error * move files * add autoOptInFeatures column * use autoOptInFeatures flag within FeatureOptInService * add setUserAutoOptIn and setTeamAutoOptIn * fix computeEffectiveState logic * rewrite computeEffectiveState * clean up integration tests * clean up in afterEach * fix type error * refactor: use FeaturesRepository methods instead of direct Prisma calls Replace all manual userFeatures and teamFeatures Prisma operations with the new setUserFeatureState and setTeamFeatureState repository methods. Changes include: - Admin handlers (assignFeatureToTeam, unassignFeatureFromTeam) - Test fixtures and integration tests - Playwright fixtures - Development scripts This ensures consistent feature flag management through the repository pattern and supports the new tri-state semantics (enabled/disabled/inherit). Co-Authored-By: eunjae@cal.com <hey@eunjae.dev> * clean up * fix the logic * extract some logic into applyAutoOptIn() * remove wrong code * refactor: convert setUserFeatureState and setTeamFeatureState to object params with discriminated union - Convert multiple positional parameters to single object parameter - Use discriminated union types: assignedBy required for enabled/disabled, omitted for inherit - Update all callers across repository, service, handlers, fixtures, and tests * fix type error * use Promise.all * fix --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
100 lines
2.7 KiB
TypeScript
100 lines
2.7 KiB
TypeScript
import type { FeatureId, FeatureState } from "./config";
|
|
import type { IFeaturesRepository } from "./features.repository.interface";
|
|
|
|
export class MockFeaturesRepository implements IFeaturesRepository {
|
|
async checkIfUserHasFeature(_userId: number, slug: string) {
|
|
return slug === "mock-feature";
|
|
}
|
|
|
|
async getUserFeaturesStatus(
|
|
_userId: number,
|
|
slugs: string[]
|
|
): Promise<Record<string, boolean>> {
|
|
return Object.fromEntries(
|
|
slugs.map((slug) => [slug, slug === "mock-feature"])
|
|
);
|
|
}
|
|
|
|
async checkIfUserHasFeatureNonHierarchical(_userId: number, slug: string) {
|
|
return slug === "mock-feature";
|
|
}
|
|
|
|
async checkIfTeamHasFeature(_teamId: number, slug: FeatureId) {
|
|
return slug === "mock-feature";
|
|
}
|
|
|
|
async checkIfFeatureIsEnabledGlobally(_slug: FeatureId) {
|
|
return true;
|
|
}
|
|
|
|
async getTeamsWithFeatureEnabled(_slug: FeatureId): Promise<number[]> {
|
|
return [];
|
|
}
|
|
|
|
async setUserFeatureState(
|
|
_input:
|
|
| {
|
|
userId: number;
|
|
featureId: FeatureId;
|
|
state: "enabled" | "disabled";
|
|
assignedBy: string;
|
|
}
|
|
| { userId: number; featureId: FeatureId; state: "inherit" }
|
|
): Promise<void> {
|
|
// Mock implementation - do nothing
|
|
}
|
|
|
|
async setTeamFeatureState(
|
|
_input:
|
|
| {
|
|
teamId: number;
|
|
featureId: FeatureId;
|
|
state: "enabled" | "disabled";
|
|
assignedBy: string;
|
|
}
|
|
| { teamId: number; featureId: FeatureId; state: "inherit" }
|
|
): Promise<void> {
|
|
// Mock implementation - do nothing
|
|
}
|
|
|
|
async getUserFeatureStates(_input: {
|
|
userId: number;
|
|
featureIds: FeatureId[];
|
|
}): Promise<Record<string, FeatureState>> {
|
|
// Mock implementation - return inherit for all features
|
|
const result: Record<string, FeatureState> = {};
|
|
for (const featureId of _input.featureIds) {
|
|
result[featureId] = "inherit";
|
|
}
|
|
return result;
|
|
}
|
|
|
|
async getTeamsFeatureStates(_input: {
|
|
teamIds: number[];
|
|
featureIds: FeatureId[];
|
|
}): Promise<Record<string, Record<number, FeatureState>>> {
|
|
// Mock implementation - return empty (all teams inherit)
|
|
return {};
|
|
}
|
|
|
|
async getUserAutoOptIn(_userId: number): Promise<boolean> {
|
|
// Mock implementation - default to false
|
|
return false;
|
|
}
|
|
|
|
async getTeamsAutoOptIn(
|
|
_teamIds: number[]
|
|
): Promise<Record<number, boolean>> {
|
|
// Mock implementation - return empty (all teams default to false)
|
|
return {};
|
|
}
|
|
|
|
async setUserAutoOptIn(_userId: number, _enabled: boolean): Promise<void> {
|
|
// Mock implementation - do nothing
|
|
}
|
|
|
|
async setTeamAutoOptIn(_teamId: number, _enabled: boolean): Promise<void> {
|
|
// Mock implementation - do nothing
|
|
}
|
|
}
|