Files
calendar/packages/ui/components/editor/plugins/AddVariablesDropdown.tsx
T
455973b394 fix(ui): improve Variables Dropdown styling consistency (#26675)
* fix(ui): improve Variables Dropdown styling consistency

- Change focus ring from brand-800 to subtle for consistent design
- Add rounded-md to dropdown container for visual consistency
- Add rounded-md to DropdownMenuItem for rounded corners
- Remove redundant hover:bg-muted and conditional bg-muted styling

Fixes #25848

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix: restore keyboard navigation active state indicator

Keep the conditional bg-muted styling for the selected item during
keyboard navigation, while still removing the redundant hover:bg-muted
since DropdownMenuItem already handles hover styling.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

---------

Co-authored-by: simiondolha <simiondolha@users.noreply.github.com>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Co-authored-by: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com>
2026-01-13 14:53:11 -03:00

187 lines
6.9 KiB
TypeScript

import { useMemo, useState, useRef, useEffect } from "react";
import { useLocale } from "@calcom/lib/hooks/useLocale";
import useMediaQuery from "@calcom/lib/hooks/useMediaQuery";
import classNames from "../../../classNames";
import { Dropdown, DropdownMenuContent, DropdownMenuItem, DropdownMenuTrigger } from "../../dropdown";
import { Input } from "../../form";
import { Icon } from "../../icon";
interface IAddVariablesDropdown {
addVariable: (variable: string) => void;
isTextEditor?: boolean;
variables: string[];
addVariableButtonTop?: boolean;
addVariableButtonClassName?: string;
}
export const AddVariablesDropdown = (props: IAddVariablesDropdown) => {
const { t } = useLocale();
const [query, setQuery] = useState("");
const isMobile = useMediaQuery("(max-width: 640px)");
const [isOpen, setisOpen] = useState(false);
const [selectedIndex, setSelectedIndex] = useState<number>(-1);
const itemRefs = useRef<(HTMLButtonElement | null)[]>([]);
const dropdownContainerRef = useRef<HTMLDivElement>(null);
useEffect(() => {
if (selectedIndex >= 0 && dropdownContainerRef.current && itemRefs.current[selectedIndex]) {
const container = dropdownContainerRef.current;
const selectedItem = itemRefs.current[selectedIndex];
if (selectedItem) {
const containerRect = container.getBoundingClientRect();
const itemRect = selectedItem.getBoundingClientRect();
if (itemRect.bottom > containerRect.bottom) {
container.scrollTop += itemRect.bottom - containerRect.bottom;
} else if (itemRect.top < containerRect.top) {
container.scrollTop -= containerRect.top - itemRect.top;
}
}
}
}, [selectedIndex]);
const filteredVariables = useMemo(() => {
const q = query.trim().toLowerCase();
if (!q) return props.variables;
return props.variables.filter((variable) => {
const key = variable.toLowerCase();
const name = t(`${variable}_variable`).toLowerCase();
const info = t(`${variable}_info`).toLowerCase();
return key.includes(q) || name.includes(q) || info.includes(q);
});
}, [props.variables, query, t]);
const handleOnOpen = (open: boolean) => {
setisOpen(open);
if (!open) setQuery("");
setSelectedIndex(open && filteredVariables.length > 0 ? 0 : -1);
};
const handleKeyDown = (e: React.KeyboardEvent) => {
if (filteredVariables.length === 0 || !isOpen) return;
switch (e.key) {
case "Enter":
e.preventDefault();
if (selectedIndex >= 0 && selectedIndex < filteredVariables.length) {
props.addVariable(t(`${filteredVariables[selectedIndex]}_variable`));
}
setisOpen(false);
setQuery("");
setSelectedIndex(-1);
break;
case "ArrowUp":
e.preventDefault();
setSelectedIndex((prev) => {
if (filteredVariables.length === 0) return -1;
if (prev <= 0 || prev === -1) return filteredVariables.length - 1;
return prev - 1;
});
break;
case "ArrowDown":
e.preventDefault();
setSelectedIndex((prev) => {
if (filteredVariables.length === 0) return -1;
if (prev >= filteredVariables.length - 1) return 0;
return prev + 1;
});
break;
case "Escape":
e.preventDefault();
setisOpen(false);
setQuery("");
setSelectedIndex(-1);
break;
}
};
return (
<Dropdown onOpenChange={handleOnOpen} open={isOpen}>
<DropdownMenuTrigger
aria-label="Add variable"
className="focus:bg-cal-muted pt-[6px] focus:outline-none">
<div className="items-center">
{props.isTextEditor ? (
<>
<div className="hidden sm:flex">
{t("add_variable")}
<Icon name="chevron-down" className="ml-1 mt-[2px] h-4 w-4" />
</div>
<div className="block sm:hidden">
{props.addVariableButtonTop ? (
<div className="flex">
{t("add_variable")}
<Icon name="chevron-down" className="ml-1 mt-[2px] h-4 w-4" />
</div>
) : (
"+"
)}
</div>
</>
) : (
<div className="flex">
{t("add_variable")}
<Icon name="chevron-down" className="ml-1 mt-[2px] h-4 w-4" />
</div>
)}
</div>
</DropdownMenuTrigger>
<DropdownMenuContent className="w-52" onKeyDown={handleKeyDown}>
<div className="stack-y-2 p-1">
<div className="text-muted ml-1 text-left text-xs font-medium tracking-wide">
{t("add_dynamic_variables")}
</div>
<div>
<Input
type="text"
size="sm"
value={query}
onChange={(e) => setQuery(e.target.value)}
placeholder={t("search_variables")}
aria-label={t("search_variables")}
className="border-subtle bg-default focus:ring-subtle w-full rounded-md border px-3 py-2 text-sm outline-none focus:ring-1"
/>
</div>
<div className="max-h-64 overflow-y-auto overflow-x-hidden rounded-md md:max-h-80" ref={dropdownContainerRef}>
{filteredVariables.length === 0 ? (
<div className="text-subtle px-4 py-2 text-center text-sm">{t("no_variables_found")}</div>
) : (
filteredVariables.map((variable, index) => (
<DropdownMenuItem key={variable} className="w-full rounded-md p-1 hover:ring-0 focus:outline-none">
<button
ref={(el) => (itemRefs.current[index] = el)}
key={variable}
type="button"
className={`w-full rounded-md px-3 py-2 text-left transition-colors focus:outline-none ${
selectedIndex === index ? "bg-muted" : ""
}`}
onMouseEnter={() => setSelectedIndex(index)}
data-active={selectedIndex === index}
onClick={() => {
props.addVariable(t(`${variable}_variable`));
setQuery("");
}}>
<div className="flex flex-col">
<div
className={classNames(
"text-default font-mono text-sm",
isMobile ? "break-all" : "truncate"
)}>
{`{${t(`${variable}_variable`).toUpperCase().replace(/ /g, "_")}}`}
</div>
<div className="text-muted hidden text-xs sm:block">{t(`${variable}_info`)}</div>
</div>
</button>
</DropdownMenuItem>
))
)}
</div>
</div>
</DropdownMenuContent>
</Dropdown>
);
};