2dc0e2a6f2
* fix: use highest role for org admins accessing sub team event types When an org admin who is also a member of a sub team (but only as MEMBER role) tries to update a sub team event type, they were being denied access. This was because the permission check logic was using the team MEMBER role instead of checking both team and org roles and using the highest one. This fix updates PermissionCheckService.checkPermission() and checkPermissions() to use the highest role between team membership and org membership, similar to how getEventTypePermissions() already works. Changes: - Added getHighestRole() helper method to determine the highest role between two roles - Updated checkPermission() to check both team and org membership and use the highest role - Updated checkPermissions() to use the same logic - Added test case for org admin who is team member updating sub team event type Fixes the issue where org admins get 'permission required eventType.update' errors when updating sub team event types. Co-Authored-By: joe@cal.com <j.auyeung419@gmail.com> * test: add PBAC-enabled test case for org admin accessing sub team event types Adds a test case to verify that when PBAC is enabled, org admins who are also members of a sub team (but only with MEMBER role) can still access sub team event types through their org-level ADMIN permissions. This complements the existing fallback (PBAC disabled) test case and ensures both code paths handle org admin permissions correctly. Co-Authored-By: joe@cal.com <j.auyeung419@gmail.com> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>