Files
calendar/packages/features/ee/integration-attribute-sync/services/IntegrationAttributeSyncService.test.ts
T
Joe Au-YeungGitHubDevin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>Hariom Balharacubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
6501743e5e feat: Add attribute sync logic from Salesforce (#26517)
* Add db schema

* Add `CredentialRepository.findByTeamIdAndSlugs`

* Add enabled app slugs for attribute syncing

* Create repository for `IntegrationAttributeSync`

* Create zod schemas

* Create `AttributeSyncUserRuleOutputMapper`

* Create `IntegrationAttributeSyncService`

* Create DI contianer

* Create trpc endpoints

* Create page

* Include team name in `CredentialRepository.findByTeamIdAndSlugs`

* Update schema and relations

* Update types and schemas

* Add more methods to IntegrationAttributeSyncRepository

* Add more services to `IntegrationAttributeSyncService`
- getById
- Init updateIncludeRulesAndMappings

* Refactor `getTeams.handler` to use repository

* Create `createAttributeSync` trpc endpoint

* Create `updateAttributeSync` trpc endpoint

* Add router to trpc

* Create attribute sync child components

* Pass custom actions to `FormCard`

* Create `IntegrationAttributeSyncCard`

* Pass inital props via server side

* Fix prop

* Only refetch on mutation

* Fixes

* Add form error when duplicate field and attribute combo

* Add `updateTransactionWithRUleAndMappings` logic

* Adjust zod schemas

* Service add `updateIncludeRulesAndMappings`

* Pass orgId from server to component

* Rename types

* Add deleteById method to repository

* Add name to integrationAttributeSync

* Add deleteById method to service

* Rename method

* Add deleteAttributeSync trpc endpoint

* Make the IntegrationAttributeSyncCard a dummy component

* test: add tests for IntegrationAttributeSync feature

Co-Authored-By: joe@cal.com <j.auyeung419@gmail.com>

* Move creating a attribute sync record to the service

* Add i18n strings

* Safe select credential in find by id and team

* Fix default credentialId value in form

* Update repository return types

* Add i18n string

* Make credentialId optional for form schema

* Fix label

* Add cascade deletes

* Add verification that syncs belong to org

* Create mapper for repository output

* Type fixes

* Remove old test file

* Pass `attributeOptions` from parent to children

* Infer types from zod schema

* Type fixes

* Type fix

* Clean up

* Add i18n strings

* Remove unused file

* Address feedback

* Add migration file

* Address feedback

* Add validation for new integration values

* Remove unused router

* Move away from z.infer to z.ZodType

* Clean up comments

* Type fix

* Type fixes

* Type fix

* fix: add passthrough to syncFormDataSchema to preserve extra fields

Co-Authored-By: joe@cal.com <j.auyeung419@gmail.com>

* fix: remove incorrect test that expected extra fields to pass through syncFormDataSchema

Co-Authored-By: joe@cal.com <j.auyeung419@gmail.com>

* Add endpoint for SF to call

* Create scratch org config

* Create sf cli scripts

* Create package logic

* Update README

* Remove unused file

* Add indexes

* Add aria label

* Address feedback - consistent validation

* Fix import paths for attribute types

* Add `CredentialRepository.findByAppIdAndKeyValue`

* Get credential by instance URL

* Verify incoming sfdc orgId matches credential sfdc orgId

* Rename method

* Get user name integration syncs

* refactor: change attributeSyncRules array to singular attributeSyncRule

The database schema enforces a one-to-one relationship between
IntegrationAttributeSync and AttributeSyncRule (via @unique constraint),
and the UI only supports a single rule. This change makes the TypeScript
type match the database schema and UI behavior.

Changes:
- Update IntegrationAttributeSync interface to use attributeSyncRule: AttributeSyncRule | null
- Update mapper to return singular rule instead of wrapping in array
- Update UI component to access sync.attributeSyncRule directly
- Update IIntegrationAttributeSyncUpdateParams Omit type
- Update tests to use attributeSyncRule: null instead of attributeSyncRules: []

Co-Authored-By: joe@cal.com <j.auyeung419@gmail.com>

* Convert `membershipRepository.findAllByUserId` to a normal method

* Add temp files to git ignore

* Init  and process team conditions

* Biome formatting

* Add `AttributeService` to get user attributes

* Add DI container for AttributeService

* AttributeSyncService evaluate attribute conditions

* Create DI container for attributeSyncService

* Return result for full condition

* Evaluate if attribute sync should apply to user

* Add  method

* Change PrismaAttributeOptionRepository to instance methods

* Init AttributeSyncFieldMappingsService and process attribute syncs

* Add AttributeSyncFieldMappingService DI container

* Refactor orgId to organizationId

* Add membership validation to sync field service

* AttributeSYncFieldMappingService use repository methods

* AttributeSyncFieldMappingService.processMappings add mapping logic

* Add DI tokens

* user-sync endpoint to implement attribute syncing

* Validate team belongs to org for rule

* test: add tests for AttributeSyncRuleService, AttributeSyncFieldMappingService, and AttributeService

Co-Authored-By: joe@cal.com <j.auyeung419@gmail.com>

* Remove duplicate migration file

* Fix merge conflict

* fix: resolve type errors in attribute sync feature (#26814)

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

* Rename  variable

* Fix log typo

* Fix file name

* Add error logging

* Use credential teamId

* fix: add missing mockTeamRepository and team validation to tests

Co-Authored-By: joe@cal.com <j.auyeung419@gmail.com>

* Fix naming

* Fix file import

* Type fix

* Pass MembershipRepository as a dep in AttributeSyncFieldMappingService

* Type fix

* fix: add mockMembershipRepository to AttributeSyncFieldMappingService tests

Co-Authored-By: joe@cal.com <j.auyeung419@gmail.com>

* Update packages/app-store/salesforce/api/user-sync.ts

Add error handling when getting orgId from stored salesforce id

Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>

* fix: address Cubic code review comments

- PrismaAttributeRepository: use nested select instead of include: true for options
- CredentialRepository: use this.primaClient instead of global prisma, use select instead of include for relations
- AttributeSyncFieldMappingService: optimize O(n*m) complexity with Map lookup for O(1) access

Co-Authored-By: joe@cal.com <j.auyeung419@gmail.com>

* Fix typo in CredentialRepository

* Update README

* Update sfdx-project

* Add SFDC package tests

* fix: improve Salesforce Apex test assertions to verify actual behavior

- Enhanced CalComHttpMock to track HTTP callout invocations and capture requests
- Updated UserUpdateHandlerTest to verify HTTP callouts are made with correct data
- Updated CalComCalloutQueueableTest to verify HTTP callouts are made correctly
- Replaced System.assert(true, ...) with meaningful assertions that verify:
  - Correct number of HTTP callouts
  - Request body contains expected fields
  - Request method is POST

Addresses Cubic AI review feedback (confidence 9/10 issues only)

Co-Authored-By: unknown <>

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Hariom Balhara <hariombalhara@gmail.com>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
2026-01-15 09:19:57 -05:00

562 lines
22 KiB
TypeScript

import { describe, it, expect, vi, beforeEach } from "vitest";
import type { CredentialRepository } from "@calcom/features/credentials/repositories/CredentialRepository";
import type { TeamRepository } from "@calcom/features/ee/teams/repositories/TeamRepository";
import { enabledAppSlugs } from "../constants";
import type { IIntegrationAttributeSyncRepository } from "../repositories/IIntegrationAttributeSyncRepository";
import {
IntegrationAttributeSyncService,
UnauthorizedAttributeError,
} from "./IntegrationAttributeSyncService";
describe("IntegrationAttributeSyncService", () => {
let service: IntegrationAttributeSyncService;
let mockCredentialRepository: {
findByTeamIdAndSlugs: ReturnType<typeof vi.fn>;
};
let mockIntegrationAttributeSyncRepository: {
getByOrganizationId: ReturnType<typeof vi.fn>;
getById: ReturnType<typeof vi.fn>;
getSyncFieldMappings: ReturnType<typeof vi.fn>;
getMappedAttributeIdsByOrganization: ReturnType<typeof vi.fn>;
getAttributeIdsByOrganization: ReturnType<typeof vi.fn>;
updateTransactionWithRuleAndMappings: ReturnType<typeof vi.fn>;
deleteById: ReturnType<typeof vi.fn>;
};
let mockTeamRepository: {
findTeamsNotBelongingToOrgByIds: ReturnType<typeof vi.fn>;
};
beforeEach(() => {
vi.resetAllMocks();
mockCredentialRepository = {
findByTeamIdAndSlugs: vi.fn(),
};
mockIntegrationAttributeSyncRepository = {
getByOrganizationId: vi.fn(),
getById: vi.fn(),
getSyncFieldMappings: vi.fn(),
getMappedAttributeIdsByOrganization: vi.fn(),
getAttributeIdsByOrganization: vi.fn(),
updateTransactionWithRuleAndMappings: vi.fn(),
deleteById: vi.fn(),
};
mockTeamRepository = {
findTeamsNotBelongingToOrgByIds: vi.fn(),
};
service = new IntegrationAttributeSyncService({
credentialRepository: mockCredentialRepository as unknown as CredentialRepository,
integrationAttributeSyncRepository:
mockIntegrationAttributeSyncRepository as unknown as IIntegrationAttributeSyncRepository,
teamRepository: mockTeamRepository as unknown as TeamRepository,
});
});
describe("getEnabledAppCredentials", () => {
it("should call credentialRepository.findByTeamIdAndSlugs with correct params", async () => {
const organizationId = 123;
const expectedCredentials = [
{ id: 1, type: "salesforce", teamId: organizationId },
{ id: 2, type: "salesforce", teamId: organizationId },
];
mockCredentialRepository.findByTeamIdAndSlugs.mockResolvedValue(expectedCredentials);
const result = await service.getEnabledAppCredentials(organizationId);
expect(mockCredentialRepository.findByTeamIdAndSlugs).toHaveBeenCalledWith({
teamId: organizationId,
slugs: enabledAppSlugs,
});
expect(result).toEqual(expectedCredentials);
});
it("should return empty array when no credentials found", async () => {
const organizationId = 123;
mockCredentialRepository.findByTeamIdAndSlugs.mockResolvedValue([]);
const result = await service.getEnabledAppCredentials(organizationId);
expect(result).toEqual([]);
});
});
describe("getAllIntegrationAttributeSyncs", () => {
it("should call repository.getByOrganizationId with correct organizationId", async () => {
const organizationId = 456;
const expectedSyncs = [
{
id: "sync-1",
name: "Sync 1",
organizationId,
integration: "salesforce",
enabled: true,
attributeSyncRule: null,
syncFieldMappings: [],
},
];
mockIntegrationAttributeSyncRepository.getByOrganizationId.mockResolvedValue(expectedSyncs);
const result = await service.getAllIntegrationAttributeSyncs(organizationId);
expect(mockIntegrationAttributeSyncRepository.getByOrganizationId).toHaveBeenCalledWith(organizationId);
expect(result).toEqual(expectedSyncs);
});
it("should return empty array when no syncs found", async () => {
const organizationId = 456;
mockIntegrationAttributeSyncRepository.getByOrganizationId.mockResolvedValue([]);
const result = await service.getAllIntegrationAttributeSyncs(organizationId);
expect(result).toEqual([]);
});
});
describe("getById", () => {
it("should call repository.getById with correct id", async () => {
const syncId = "sync-123";
const expectedSync = {
id: syncId,
name: "Test Sync",
organizationId: 123,
integration: "salesforce",
enabled: true,
attributeSyncRule: null,
syncFieldMappings: [],
};
mockIntegrationAttributeSyncRepository.getById.mockResolvedValue(expectedSync);
const result = await service.getById(syncId);
expect(mockIntegrationAttributeSyncRepository.getById).toHaveBeenCalledWith(syncId);
expect(result).toEqual(expectedSync);
});
it("should return null when sync not found", async () => {
const syncId = "non-existent";
mockIntegrationAttributeSyncRepository.getById.mockResolvedValue(null);
const result = await service.getById(syncId);
expect(result).toBeNull();
});
});
describe("updateIncludeRulesAndMappings", () => {
const baseFormData = {
id: "sync-123",
name: "Test Sync",
credentialId: 1,
enabled: true,
organizationId: 123,
ruleId: "rule-123",
rule: {
operator: "AND" as const,
conditions: [
{
identifier: "teamId" as const,
operator: "equals" as const,
value: [1, 2],
},
],
},
};
it("should create new mappings when they don't have ids", async () => {
const formData = {
...baseFormData,
syncFieldMappings: [
{ integrationFieldName: "field1", attributeId: "attr-1", enabled: true },
{ integrationFieldName: "field2", attributeId: "attr-2", enabled: false },
],
};
mockIntegrationAttributeSyncRepository.getMappedAttributeIdsByOrganization.mockResolvedValue([]);
mockIntegrationAttributeSyncRepository.getAttributeIdsByOrganization.mockResolvedValue(["attr-1", "attr-2"]);
mockIntegrationAttributeSyncRepository.getSyncFieldMappings.mockResolvedValue([]);
mockIntegrationAttributeSyncRepository.updateTransactionWithRuleAndMappings.mockResolvedValue(undefined);
mockTeamRepository.findTeamsNotBelongingToOrgByIds.mockResolvedValue([]);
await service.updateIncludeRulesAndMappings(formData);
expect(mockIntegrationAttributeSyncRepository.updateTransactionWithRuleAndMappings).toHaveBeenCalledWith({
integrationAttributeSync: {
id: formData.id,
name: formData.name,
credentialId: formData.credentialId,
enabled: formData.enabled,
organizationId: formData.organizationId,
},
attributeSyncRule: {
id: formData.ruleId,
rule: formData.rule,
},
fieldMappingsToCreate: formData.syncFieldMappings,
fieldMappingsToUpdate: [],
fieldMappingsToDelete: [],
});
});
it("should update existing mappings when they have ids", async () => {
const formData = {
...baseFormData,
syncFieldMappings: [
{ id: "mapping-1", integrationFieldName: "field1", attributeId: "attr-1", enabled: true },
{ id: "mapping-2", integrationFieldName: "field2", attributeId: "attr-2", enabled: false },
],
};
mockIntegrationAttributeSyncRepository.getMappedAttributeIdsByOrganization.mockResolvedValue([]);
mockIntegrationAttributeSyncRepository.getAttributeIdsByOrganization.mockResolvedValue(["attr-1", "attr-2"]);
mockIntegrationAttributeSyncRepository.getSyncFieldMappings.mockResolvedValue([
{ id: "mapping-1", integrationFieldName: "field1", attributeId: "attr-1", enabled: true },
{ id: "mapping-2", integrationFieldName: "field2", attributeId: "attr-2", enabled: true },
]);
mockIntegrationAttributeSyncRepository.updateTransactionWithRuleAndMappings.mockResolvedValue(undefined);
mockTeamRepository.findTeamsNotBelongingToOrgByIds.mockResolvedValue([]);
await service.updateIncludeRulesAndMappings(formData);
expect(mockIntegrationAttributeSyncRepository.updateTransactionWithRuleAndMappings).toHaveBeenCalledWith({
integrationAttributeSync: {
id: formData.id,
name: formData.name,
credentialId: formData.credentialId,
enabled: formData.enabled,
organizationId: formData.organizationId,
},
attributeSyncRule: {
id: formData.ruleId,
rule: formData.rule,
},
fieldMappingsToCreate: [],
fieldMappingsToUpdate: formData.syncFieldMappings,
fieldMappingsToDelete: [],
});
});
it("should delete mappings that are no longer in the form data", async () => {
const formData = {
...baseFormData,
syncFieldMappings: [
{ id: "mapping-1", integrationFieldName: "field1", attributeId: "attr-1", enabled: true },
],
};
mockIntegrationAttributeSyncRepository.getMappedAttributeIdsByOrganization.mockResolvedValue([]);
mockIntegrationAttributeSyncRepository.getAttributeIdsByOrganization.mockResolvedValue(["attr-1"]);
mockIntegrationAttributeSyncRepository.getSyncFieldMappings.mockResolvedValue([
{ id: "mapping-1", integrationFieldName: "field1", attributeId: "attr-1", enabled: true },
{ id: "mapping-2", integrationFieldName: "field2", attributeId: "attr-2", enabled: true },
{ id: "mapping-3", integrationFieldName: "field3", attributeId: "attr-3", enabled: true },
]);
mockIntegrationAttributeSyncRepository.updateTransactionWithRuleAndMappings.mockResolvedValue(undefined);
mockTeamRepository.findTeamsNotBelongingToOrgByIds.mockResolvedValue([]);
await service.updateIncludeRulesAndMappings(formData);
expect(mockIntegrationAttributeSyncRepository.updateTransactionWithRuleAndMappings).toHaveBeenCalledWith({
integrationAttributeSync: {
id: formData.id,
name: formData.name,
credentialId: formData.credentialId,
enabled: formData.enabled,
organizationId: formData.organizationId,
},
attributeSyncRule: {
id: formData.ruleId,
rule: formData.rule,
},
fieldMappingsToCreate: [],
fieldMappingsToUpdate: [formData.syncFieldMappings[0]],
fieldMappingsToDelete: ["mapping-2", "mapping-3"],
});
});
it("should handle mixed create, update, and delete operations", async () => {
const formData = {
...baseFormData,
syncFieldMappings: [
{ id: "mapping-1", integrationFieldName: "field1-updated", attributeId: "attr-1", enabled: false },
{ integrationFieldName: "field-new", attributeId: "attr-new", enabled: true },
],
};
mockIntegrationAttributeSyncRepository.getMappedAttributeIdsByOrganization.mockResolvedValue([]);
mockIntegrationAttributeSyncRepository.getAttributeIdsByOrganization.mockResolvedValue(["attr-1", "attr-new"]);
mockIntegrationAttributeSyncRepository.getSyncFieldMappings.mockResolvedValue([
{ id: "mapping-1", integrationFieldName: "field1", attributeId: "attr-1", enabled: true },
{ id: "mapping-2", integrationFieldName: "field2", attributeId: "attr-2", enabled: true },
]);
mockIntegrationAttributeSyncRepository.updateTransactionWithRuleAndMappings.mockResolvedValue(undefined);
mockTeamRepository.findTeamsNotBelongingToOrgByIds.mockResolvedValue([]);
await service.updateIncludeRulesAndMappings(formData);
expect(mockIntegrationAttributeSyncRepository.updateTransactionWithRuleAndMappings).toHaveBeenCalledWith({
integrationAttributeSync: {
id: formData.id,
name: formData.name,
credentialId: formData.credentialId,
enabled: formData.enabled,
organizationId: formData.organizationId,
},
attributeSyncRule: {
id: formData.ruleId,
rule: formData.rule,
},
fieldMappingsToCreate: [
{ integrationFieldName: "field-new", attributeId: "attr-new", enabled: true },
],
fieldMappingsToUpdate: [
{ id: "mapping-1", integrationFieldName: "field1-updated", attributeId: "attr-1", enabled: false },
],
fieldMappingsToDelete: ["mapping-2"],
});
});
it("should handle attribute-based conditions in rules", async () => {
const formData = {
...baseFormData,
rule: {
operator: "OR" as const,
conditions: [
{
identifier: "attributeId" as const,
attributeId: "attr-123",
operator: "in" as const,
value: ["option-1", "option-2"],
},
],
},
syncFieldMappings: [],
};
mockIntegrationAttributeSyncRepository.getMappedAttributeIdsByOrganization.mockResolvedValue([]);
mockIntegrationAttributeSyncRepository.getAttributeIdsByOrganization.mockResolvedValue([]);
mockIntegrationAttributeSyncRepository.getSyncFieldMappings.mockResolvedValue([]);
mockIntegrationAttributeSyncRepository.updateTransactionWithRuleAndMappings.mockResolvedValue(undefined);
await service.updateIncludeRulesAndMappings(formData);
expect(mockIntegrationAttributeSyncRepository.updateTransactionWithRuleAndMappings).toHaveBeenCalledWith(
expect.objectContaining({
attributeSyncRule: {
id: formData.ruleId,
rule: formData.rule,
},
})
);
});
});
describe("validateAttributeOwnership", () => {
const baseFormData = {
id: "sync-123",
name: "Test Sync",
credentialId: 1,
enabled: true,
organizationId: 123,
ruleId: "rule-123",
rule: {
operator: "AND" as const,
conditions: [
{
identifier: "teamId" as const,
operator: "equals" as const,
value: [1, 2],
},
],
},
};
it("should throw UnauthorizedAttributeError when attribute does not belong to organization", async () => {
const formData = {
...baseFormData,
syncFieldMappings: [
{ integrationFieldName: "field1", attributeId: "attr-1", enabled: true },
{ integrationFieldName: "field2", attributeId: "attr-invalid", enabled: true },
],
};
mockIntegrationAttributeSyncRepository.getMappedAttributeIdsByOrganization.mockResolvedValue([]);
mockIntegrationAttributeSyncRepository.getAttributeIdsByOrganization.mockResolvedValue(["attr-1"]);
mockIntegrationAttributeSyncRepository.getSyncFieldMappings.mockResolvedValue([]);
await expect(service.updateIncludeRulesAndMappings(formData)).rejects.toThrow(UnauthorizedAttributeError);
});
it("should include invalid attribute ids in the error", async () => {
const formData = {
...baseFormData,
syncFieldMappings: [
{ integrationFieldName: "field1", attributeId: "attr-valid", enabled: true },
{ integrationFieldName: "field2", attributeId: "attr-invalid-1", enabled: true },
{ integrationFieldName: "field3", attributeId: "attr-invalid-2", enabled: true },
],
};
mockIntegrationAttributeSyncRepository.getMappedAttributeIdsByOrganization.mockResolvedValue([]);
mockIntegrationAttributeSyncRepository.getAttributeIdsByOrganization.mockResolvedValue(["attr-valid"]);
mockIntegrationAttributeSyncRepository.getSyncFieldMappings.mockResolvedValue([]);
await expect(service.updateIncludeRulesAndMappings(formData)).rejects.toSatisfy((error) => {
expect(error).toBeInstanceOf(UnauthorizedAttributeError);
expect((error as UnauthorizedAttributeError).attributeIds).toEqual(["attr-invalid-1", "attr-invalid-2"]);
return true;
});
});
it("should pass validation when all attributes belong to organization", async () => {
const formData = {
...baseFormData,
syncFieldMappings: [
{ integrationFieldName: "field1", attributeId: "attr-1", enabled: true },
{ integrationFieldName: "field2", attributeId: "attr-2", enabled: true },
],
};
mockIntegrationAttributeSyncRepository.getMappedAttributeIdsByOrganization.mockResolvedValue([]);
mockIntegrationAttributeSyncRepository.getAttributeIdsByOrganization.mockResolvedValue(["attr-1", "attr-2"]);
mockIntegrationAttributeSyncRepository.getSyncFieldMappings.mockResolvedValue([]);
mockIntegrationAttributeSyncRepository.updateTransactionWithRuleAndMappings.mockResolvedValue(undefined);
mockTeamRepository.findTeamsNotBelongingToOrgByIds.mockResolvedValue([]);
await expect(service.updateIncludeRulesAndMappings(formData)).resolves.not.toThrow();
});
it("should pass validation when syncFieldMappings is empty", async () => {
const formData = {
...baseFormData,
syncFieldMappings: [],
};
mockIntegrationAttributeSyncRepository.getMappedAttributeIdsByOrganization.mockResolvedValue([]);
mockIntegrationAttributeSyncRepository.getAttributeIdsByOrganization.mockResolvedValue([]);
mockIntegrationAttributeSyncRepository.getSyncFieldMappings.mockResolvedValue([]);
mockIntegrationAttributeSyncRepository.updateTransactionWithRuleAndMappings.mockResolvedValue(undefined);
mockTeamRepository.findTeamsNotBelongingToOrgByIds.mockResolvedValue([]);
await expect(service.updateIncludeRulesAndMappings(formData)).resolves.not.toThrow();
});
});
describe("deleteById", () => {
it("should call repository.deleteById with correct id", async () => {
const syncId = "sync-to-delete";
mockIntegrationAttributeSyncRepository.deleteById.mockResolvedValue(undefined);
await service.deleteById(syncId);
expect(mockIntegrationAttributeSyncRepository.deleteById).toHaveBeenCalledWith(syncId);
});
});
describe("team validation", () => {
describe("updateIncludeRulesAndMappings", () => {
const baseFormData = {
id: "sync-123",
name: "Test Sync",
credentialId: 1,
enabled: true,
organizationId: 123,
ruleId: "rule-123",
syncFieldMappings: [],
};
it("should throw error when team IDs do not belong to organization", async () => {
const formData = {
...baseFormData,
rule: {
operator: "AND" as const,
conditions: [
{
identifier: "teamId" as const,
operator: "equals" as const,
value: [1, 2, 3],
},
],
},
};
mockIntegrationAttributeSyncRepository.getMappedAttributeIdsByOrganization.mockResolvedValue([]);
mockIntegrationAttributeSyncRepository.getAttributeIdsByOrganization.mockResolvedValue([]);
mockTeamRepository.findTeamsNotBelongingToOrgByIds.mockResolvedValue([{ id: 2 }, { id: 3 }]);
await expect(service.updateIncludeRulesAndMappings(formData)).rejects.toThrow(
"Teams do not belong to this organization: 2, 3"
);
expect(mockTeamRepository.findTeamsNotBelongingToOrgByIds).toHaveBeenCalledWith({
teamIds: [1, 2, 3],
orgId: 123,
});
});
it("should not validate teams when no team conditions in rule", async () => {
const formData = {
...baseFormData,
rule: {
operator: "OR" as const,
conditions: [
{
identifier: "attributeId" as const,
attributeId: "attr-123",
operator: "in" as const,
value: ["option-1"],
},
],
},
};
mockIntegrationAttributeSyncRepository.getMappedAttributeIdsByOrganization.mockResolvedValue([]);
mockIntegrationAttributeSyncRepository.getAttributeIdsByOrganization.mockResolvedValue([]);
mockIntegrationAttributeSyncRepository.getSyncFieldMappings.mockResolvedValue([]);
mockIntegrationAttributeSyncRepository.updateTransactionWithRuleAndMappings.mockResolvedValue(undefined);
await service.updateIncludeRulesAndMappings(formData);
expect(mockTeamRepository.findTeamsNotBelongingToOrgByIds).not.toHaveBeenCalled();
});
it("should proceed when all team IDs belong to organization", async () => {
const formData = {
...baseFormData,
rule: {
operator: "AND" as const,
conditions: [
{
identifier: "teamId" as const,
operator: "equals" as const,
value: [1, 2],
},
],
},
};
mockTeamRepository.findTeamsNotBelongingToOrgByIds.mockResolvedValue([]);
mockIntegrationAttributeSyncRepository.getMappedAttributeIdsByOrganization.mockResolvedValue([]);
mockIntegrationAttributeSyncRepository.getAttributeIdsByOrganization.mockResolvedValue([]);
mockIntegrationAttributeSyncRepository.getSyncFieldMappings.mockResolvedValue([]);
mockIntegrationAttributeSyncRepository.updateTransactionWithRuleAndMappings.mockResolvedValue(undefined);
await service.updateIncludeRulesAndMappings(formData);
expect(mockTeamRepository.findTeamsNotBelongingToOrgByIds).toHaveBeenCalledWith({
teamIds: [1, 2],
orgId: 123,
});
expect(mockIntegrationAttributeSyncRepository.updateTransactionWithRuleAndMappings).toHaveBeenCalled();
});
});
});
});