Files
calendar/packages/features/ee/dsync/lib/handleUserEvents.test.ts
T
Benny JooGitHubDevin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
f5d345b133 refactor: remove @calcom/web imports from @calcom/features and add @calcom/testing package (#26480)
* fix: remove @calcom/web imports from packages/features to eliminate circular dependency

- Migrate UserTableUser and MemberPermissions types to packages/features/users/types/user-table.ts
- Migrate useGeo hook to packages/features/geo/GeoContext.tsx
- Migrate buildLegacyRequest to packages/lib/buildLegacyCtx.ts
- Migrate Calendar component to packages/features/calendars/weeklyview/components/
- Move test utilities (bookingScenario, fixtures) to packages/features/test/
- Update all imports in packages/features to use new locations
- Add re-exports in apps/web for backward compatibility

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: delete original implementation files and fix type issues

- Delete original calendar component files in apps/web (keep only re-export stubs)
- Migrate OutOfOfficeInSlots to packages/features/bookings/components
- Convert apps/web OutOfOfficeInSlots to re-export stub
- Fix className vs class issue in Calendar.tsx
- Fix @calcom/trpc import violation in user-table.ts by using structural type

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: add missing isGroup and contains fields to UserTableUser attributes type

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: update customRole type to match actual Prisma Role model

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix build

* fix

* fix

* cleanup weeklyview

* fix

* refactor to mv MemberPermissions to types package

* add types dependency to features

* fix

* fix

* fix

* fix

* fix

* fix

* rename

* rename

* migrate

* migrate

* migrate

* fix

* fix

* fix

* refactor: move test utilities from packages/features/test to tests/libs

- Move bookingScenario utilities to tests/libs/bookingScenario
- Move fixtures to tests/libs/fixtures
- Update all imports in packages/features test files to use new location
- Update all imports in apps/web test files to use new location
- Eliminates duplication of test utilities between packages/features and apps/web

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: correct relative import paths for tests/libs in test files

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* refactor: replace test utility implementations with re-exports to tests/libs

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: fix test import paths and move signup handler tests to apps/web

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: move buildLegacyCtx to packages/lib and restore handlers to packages/features

- Move buildLegacyCtx from apps/web/lib to packages/lib to break circular dependency
- Update apps/web/lib/buildLegacyCtx.ts to re-export from @calcom/lib
- Restore signup handlers and tests to packages/features/auth/signup/handlers
- Update handler imports to use @calcom/lib/buildLegacyCtx instead of @calcom/web/lib/buildLegacyCtx

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: update recurring-event.test.ts imports to use tests/libs path

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* refactor: delete test re-export files and update imports to use tests/libs directly

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: update remaining test imports to use tests/libs directly

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: update handleRecurringEventBooking calls to match function signature (1 arg)

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* remove

* migrate tests

* migrate tests

* refactor: update test mock imports by removing  and using async  for mock creators.

* fix type errors

* fix: add type assertion for MockUser in p2002.test-suite.ts

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: restore locale import in compareReminderBodyToTemplate.test.ts using relative path

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* feat: create @calcom/testing package and migrate tests from /tests directory

- Created new @calcom/testing package in /packages/testing
- Moved all files from /tests to /packages/testing
- Updated all imports across the codebase to use @calcom/testing alias
- Removed /tests directory at root level

This allows other packages like @calcom/features and @calcom/web to import
testing utilities using the @calcom/testing alias instead of relative paths.

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix

* fix

* fix: add missing useBookings export to @calcom/atoms package

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: add missing useCalendarsBusyTimes and useConnectedCalendars exports to @calcom/atoms

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* chore: add @calcom/testing as explicit devDependency to packages that use it

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* refactor: move setupVitest.ts into @calcom/testing package

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix

* chore: add biome rules to restrict @calcom/testing imports

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix

* rename libs to lib

* rename libs to lib

* add rule

* add rule

* refactor: remove @calcom/features imports from @calcom/testing

- Move mockPaymentSuccessWebhookFromStripe to fresh-booking.test.ts
- Replace ProfileRepository.generateProfileUid() with uuidv4()
- Clone Tracking type into @calcom/testing/src/lib/types.ts
- Update imports in expects.ts and getMockRequestDataForBooking.ts
- Move source files into src/ folder
- Move CalendarManager mock to @calcom/features

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* fix: add explicit exports for nested paths in @calcom/testing

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>

* improve

* improve

* fix

* fix

* fix type checks

* fix type checks

* fix type checks

* fix tests

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2026-01-08 16:59:11 +09:00

431 lines
12 KiB
TypeScript

import prismock from "@calcom/testing/lib/__mocks__/prisma";
import type { DirectorySyncEvent } from "@boxyhq/saml-jackson";
import { describe, expect, it, vi, beforeEach } from "vitest";
import { IdentityProvider, MembershipRole } from "@calcom/prisma/enums";
import handleUserEvents from "./handleUserEvents";
vi.mock("@calcom/lib/logger", () => ({
default: {
getSubLogger: () => ({
debug: vi.fn(),
error: vi.fn(),
warn: vi.fn(),
}),
},
}));
vi.mock("@calcom/lib/server/i18n", () => ({
getTranslation: vi.fn().mockResolvedValue((key: string) => key),
}));
vi.mock("@calcom/trpc/server/routers/viewer/teams/inviteMember/utils", () => ({
getTeamOrThrow: vi.fn(),
sendExistingUserTeamInviteEmails: vi.fn(),
sendSignupToOrganizationEmail: vi.fn(),
}));
vi.mock("./assignValueToUser", () => ({
assignValueToUserInOrgBulk: vi.fn(),
}));
vi.mock("./users/createUsersAndConnectToOrg", () => ({
default: vi.fn(),
}));
vi.mock("./users/inviteExistingUserToOrg", () => ({
default: vi.fn().mockResolvedValue({
id: 1,
username: "testuser",
email: "test@example.com",
}),
}));
vi.mock("./removeUserFromOrg", () => ({
default: vi.fn(),
}));
vi.mock("@calcom/features/users/repositories/UserRepository", () => ({
UserRepository: vi.fn().mockImplementation(function() { return {
isAMemberOfOrganization: vi.fn().mockResolvedValue(false),
}; }),
}));
async function createMockOrganization({ id, name, slug }: { id: number; name: string; slug: string }) {
return prismock.team.create({
data: {
id,
name,
slug,
isOrganization: true,
},
});
}
async function createMockUser({ email, organizationId }: { email: string; organizationId: number | null }) {
return prismock.user.create({
data: {
email,
username: email.split("@")[0],
organizationId,
completedOnboarding: true,
identityProvider: IdentityProvider.CAL,
locale: "en",
},
});
}
async function createMockMembership({
userId,
teamId,
role = MembershipRole.MEMBER,
}: {
userId: number;
teamId: number;
role?: MembershipRole;
}) {
return prismock.membership.create({
data: {
userId,
teamId,
role,
accepted: true,
disableImpersonation: false,
},
});
}
describe("handleUserEvents", () => {
const directoryId = "test-directory-id";
const organizationId = 1001;
const organizationName = "Test Organization";
const organizationSlug = "test-org";
beforeEach(async () => {
vi.clearAllMocks();
await createMockOrganization({
id: organizationId,
name: organizationName,
slug: organizationSlug,
});
const { getTeamOrThrow } = await import("@calcom/trpc/server/routers/viewer/teams/inviteMember/utils");
vi.mocked(getTeamOrThrow).mockResolvedValue({
id: organizationId,
name: organizationName,
slug: organizationSlug,
isOrganization: true,
parent: null,
parentId: null,
metadata: null,
} as Awaited<ReturnType<typeof getTeamOrThrow>>);
});
describe("Cross-tenant hijack prevention", () => {
it("should throw an error when user belongs to a different organization", async () => {
const userEmail = "user@example.com";
const differentOrgId = 2002;
await createMockOrganization({
id: differentOrgId,
name: "Different Organization",
slug: "different-org",
});
await createMockUser({
email: userEmail,
organizationId: 9999,
});
const event: DirectorySyncEvent = {
event: "user.created",
tenant: "test-tenant",
directory_id: directoryId,
data: {
id: "user-123",
email: userEmail,
first_name: "Test",
last_name: "User",
active: true,
raw: {
schemas: [],
},
},
};
await expect(handleUserEvents(event, organizationId)).rejects.toThrow(
"User belongs to another organization."
);
});
it("should succeed when user belongs to the correct organization", async () => {
const userEmail = "user@example.com";
const user = await createMockUser({
email: userEmail,
organizationId: organizationId,
});
await createMockMembership({
userId: user.id,
teamId: organizationId,
});
const event: DirectorySyncEvent = {
event: "user.created",
tenant: "test-tenant",
directory_id: directoryId,
data: {
id: "user-123",
email: userEmail,
first_name: "Test",
last_name: "User",
active: true,
raw: {
schemas: [],
},
},
};
const { UserRepository } = await import("@calcom/features/users/repositories/UserRepository");
vi.mocked(UserRepository).mockImplementation(function () {
return {
isAMemberOfOrganization: vi.fn().mockResolvedValue(true),
} as unknown as InstanceType<typeof UserRepository>;
});
await expect(handleUserEvents(event, organizationId)).resolves.not.toThrow();
});
it("should pass when user has no organizationId (allow existing user to be added to an org)", async () => {
const userEmail = "legacy@example.com";
await createMockUser({
email: userEmail,
organizationId: null,
});
const event: DirectorySyncEvent = {
event: "user.created",
tenant: "test-tenant",
directory_id: directoryId,
data: {
id: "user-123",
email: userEmail,
first_name: "Legacy",
last_name: "User",
active: true,
raw: {
schemas: [],
},
},
};
await expect(handleUserEvents(event, organizationId)).resolves.toBeUndefined();
});
it("should succeed when user does not exist yet (new user creation)", async () => {
const userEmail = "newuser@example.com";
const event: DirectorySyncEvent = {
event: "user.created",
tenant: "test-tenant",
directory_id: directoryId,
data: {
id: "user-123",
email: userEmail,
first_name: "New",
last_name: "User",
active: true,
raw: {
schemas: [],
},
},
};
const createUsersAndConnectToOrg = (await import("./users/createUsersAndConnectToOrg")).default;
vi.mocked(createUsersAndConnectToOrg).mockResolvedValue(undefined);
await expect(handleUserEvents(event, organizationId)).resolves.not.toThrow();
expect(createUsersAndConnectToOrg).toHaveBeenCalledWith({
createUsersAndConnectToOrgProps: {
emailsToCreate: [userEmail],
identityProvider: IdentityProvider.CAL,
identityProviderId: null,
},
org: expect.objectContaining({
id: organizationId,
name: organizationName,
}),
});
});
});
describe("User activation and deactivation", () => {
it("should invite existing user when active is true and user is not a member", async () => {
const userEmail = "user@example.com";
await createMockUser({
email: userEmail,
organizationId: organizationId,
});
const event: DirectorySyncEvent = {
event: "user.updated",
tenant: "test-tenant",
directory_id: directoryId,
data: {
id: "user-123",
email: userEmail,
first_name: "Test",
last_name: "User",
active: true,
raw: {
schemas: [],
},
},
};
const { UserRepository } = await import("@calcom/features/users/repositories/UserRepository");
vi.mocked(UserRepository).mockImplementation(function () {
return {
isAMemberOfOrganization: vi.fn().mockResolvedValue(false),
} as unknown as InstanceType<typeof UserRepository>;
});
const inviteExistingUserToOrg = (await import("./users/inviteExistingUserToOrg")).default;
const sendExistingUserTeamInviteEmails = (
await import("@calcom/trpc/server/routers/viewer/teams/inviteMember/utils")
).sendExistingUserTeamInviteEmails;
await handleUserEvents(event, organizationId);
expect(inviteExistingUserToOrg).toHaveBeenCalled();
expect(sendExistingUserTeamInviteEmails).toHaveBeenCalled();
});
it("should remove user from organization when active is false", async () => {
const userEmail = "user@example.com";
const user = await createMockUser({
email: userEmail,
organizationId: organizationId,
});
const event: DirectorySyncEvent = {
event: "user.updated",
tenant: "test-tenant",
directory_id: directoryId,
data: {
id: "user-123",
email: userEmail,
first_name: "Test",
last_name: "User",
active: false,
raw: {
schemas: [],
},
},
};
const removeUserFromOrg = (await import("./removeUserFromOrg")).default;
await handleUserEvents(event, organizationId);
expect(removeUserFromOrg).toHaveBeenCalledWith({
userId: user.id,
orgId: organizationId,
});
});
it("should sync custom attributes when user is already a member and active", async () => {
const userEmail = "user@example.com";
const user = await createMockUser({
email: userEmail,
organizationId: organizationId,
});
await createMockMembership({
userId: user.id,
teamId: organizationId,
});
const event: DirectorySyncEvent = {
event: "user.updated",
tenant: "test-tenant",
directory_id: directoryId,
data: {
id: "user-123",
email: userEmail,
first_name: "Test",
last_name: "User",
active: true,
raw: {
schemas: ["custom:enterprise"],
"custom:enterprise": {
department: "Engineering",
},
},
},
};
const { UserRepository } = await import("@calcom/features/users/repositories/UserRepository");
vi.mocked(UserRepository).mockImplementation(function () {
return {
isAMemberOfOrganization: vi.fn().mockResolvedValue(true),
} as unknown as InstanceType<typeof UserRepository>;
});
const { assignValueToUserInOrgBulk } = await import("./assignValueToUser");
await handleUserEvents(event, organizationId);
expect(assignValueToUserInOrgBulk).toHaveBeenCalledWith({
orgId: organizationId,
userId: user.id,
attributeLabelToValueMap: {
department: "Engineering",
},
updater: {
dsyncId: directoryId,
},
});
});
});
describe("Error handling", () => {
it("should throw an error when organization is not found", async () => {
const userEmail = "user@example.com";
const nonExistentOrgId = 9999;
const event: DirectorySyncEvent = {
event: "user.created",
tenant: "test-tenant",
directory_id: directoryId,
data: {
id: "user-123",
email: userEmail,
first_name: "Test",
last_name: "User",
active: true,
raw: {
schemas: [],
},
},
};
const { getTeamOrThrow } = await import("@calcom/trpc/server/routers/viewer/teams/inviteMember/utils");
vi.mocked(getTeamOrThrow).mockResolvedValue(
null as unknown as Awaited<ReturnType<typeof getTeamOrThrow>>
);
await expect(handleUserEvents(event, nonExistentOrgId)).rejects.toThrow("Org not found");
});
});
});