9dca13305f
* migration plus feature flag * show navigation route + inital roles migration * add a check permission use case to take in the feature flags for a team * bulk update script * inital frontend work for displaying roles * move to a more "anemic domain models" approach * update test to match new DDD strutcture * fix tests * update transaction call back types to include trx * align fe types after transaction to DDD * move away from usecases to a more domain tailored approach * get permissions per resource and map them to domain permission string * update permision logic * correctly get the logic for *.* permissions on owner * wip sheet logic for ssr * role list * use nuqs for sheet parsing on handle change * fox * improve hook usage * enable PBAC router * delete modal etc * i18n and inital rough layout of roles + permisions creating * add color to migrations * add colors and new method to tests * move hooks out of infra into client with provider * move hooks out of infra into client with provider * memo features and ensure render once * remove comment * seed color * use role colours * match i18n * add custom color picker to edit/create form * fix advanced mode toggle * more work on adv permission group * update migrations * abstract lots of core form logic to a custom hook * improve UX for selecting all and toggling all * improve code quality and use domain mappers in role repositoryu * call server action to revalidate cache * call invalidate cache on delete * fix re-render + improves update logic wip * fix txn for assinging role to member * wip on assigning users custom roles * fix repo * update logic for checking if users can update roles * remove member from permission check * check users permission and assign roles * move to factory approach * move default rolesIDs to constant * add facuted values to table * display custom role in table * fix type error * fix role filter * check pbac feature flag to see what column to filter on * push repo mocks and other mocks to fix unit tests * fix and add test for empty permissions when creating a role * pass updates to repo so we actually update roles * fix types * fix types * restore lock changes * fix role service test for new updates section * fix updated at types * update mocks to use feature repository mock * remove roletype from db in model * prevent multiple queries * fix typeof in role model * fix and migrate i18n to one registery * fix and update i18n to be in registery * fix type error + fall back in service instead of repo for BL * more type errors * update members faceted values to bennys refactor * fix types * remove the _resource from type conditionally * fix managment factory types to expose PBAC enbaled obol * narrow down types * wip fix for types * more fix types * cast role * fix tests * attempt of fixing _resoucre key access type * attempt of fixing _resoucre key access type * seperate migraations to batches * add invalidate time to team features * restore router to main * push main lock * Update packages/features/pbac/domain/types/permission-registry.ts Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> * Update packages/features/pbac/domain/mappers/PermissionMapper.ts Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> * Update packages/prisma/migrations/20250527091330_add_color_to_pbac_role/migration.sql Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> * Update packages/prisma/migrations/20250617070118_update_memberships_one_time/migration.sql Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> * Update apps/web/app/(use-page-wrapper)/settings/(settings-layout)/organizations/roles/_components/AdvancedPermissionGroup.tsx Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> * fix mapped type * restore migration * skip _resource * use partical * fix type errors in tests and hooks * Simplified the role field in the editSchema to use z.nativeEnum(MembershipRole) * fix type errors for editsheet * fix type errors for editsheet * Apply suggestion from comment 2151515295 * remove footer since we dont have docs yet * add i18n * lock all toggle chevron * use prisma * tidy up old manage permission * fix i18n * remove can manage from role permission check * auto select read * address benny feedback * fix type * fix type * update function name due to merge * fix types * update tests to match new membership method from merge * address cubic feedback --------- Co-authored-by: Eunjae Lee <hey@eunjae.dev> Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
283 lines
7.7 KiB
TypeScript
283 lines
7.7 KiB
TypeScript
import type { Table } from "@tanstack/react-table";
|
|
import { describe, it, expect, vi } from "vitest";
|
|
|
|
import type { UserTableUser } from "@calcom/features/users/components/UserTable/types";
|
|
import { generateCsvRawForMembersTable, generateHeaderFromReactTable } from "@calcom/lib/csvUtils";
|
|
import { MembershipRole } from "@calcom/prisma/enums";
|
|
|
|
function createMockTable(data: UserTableUser[]): Table<UserTableUser> {
|
|
return {
|
|
getHeaderGroups: vi.fn().mockReturnValue([
|
|
{
|
|
headers: [
|
|
{
|
|
id: "select",
|
|
column: { columnDef: { header: "" } },
|
|
getContext: () => ({}),
|
|
},
|
|
{
|
|
id: "member",
|
|
column: { columnDef: { header: "Members" } },
|
|
getContext: () => ({}),
|
|
},
|
|
{
|
|
id: "role",
|
|
column: { columnDef: { header: "Role" } },
|
|
getContext: () => ({}),
|
|
},
|
|
{
|
|
id: "teams",
|
|
column: { columnDef: { header: "Teams" } },
|
|
getContext: () => ({}),
|
|
},
|
|
{
|
|
id: "attr1",
|
|
column: { columnDef: { header: () => "Attribute 1" } },
|
|
getContext: () => ({}),
|
|
},
|
|
{
|
|
id: "attr2",
|
|
column: { columnDef: { header: () => "Attribute 2" } },
|
|
getContext: () => ({}),
|
|
},
|
|
{
|
|
id: "actions",
|
|
column: { columnDef: { header: "" } },
|
|
getContext: () => ({}),
|
|
},
|
|
],
|
|
},
|
|
]),
|
|
getRowModel: vi.fn().mockReturnValue({ rows: data.map((item) => ({ original: item })) }),
|
|
} as unknown as Table<UserTableUser>;
|
|
}
|
|
|
|
describe("generate Csv for Org Users Table", () => {
|
|
const orgDomain = "https://acme.cal.com";
|
|
const mockAttributeIds = ["attr1", "attr2"];
|
|
const mockUser: UserTableUser = {
|
|
id: 1,
|
|
username: "testuser",
|
|
email: "test@example.com",
|
|
timeZone: "UTC",
|
|
role: MembershipRole.MEMBER,
|
|
avatarUrl: null,
|
|
accepted: true,
|
|
disableImpersonation: false,
|
|
completedOnboarding: true,
|
|
teams: [],
|
|
attributes: [],
|
|
lastActiveAt: new Date().toISOString(),
|
|
createdAt: null,
|
|
updatedAt: null,
|
|
customRole: {
|
|
type: "SYSTEM",
|
|
id: "member_role",
|
|
name: "Member",
|
|
description: "Default member role",
|
|
teamId: null,
|
|
createdAt: new Date(),
|
|
updatedAt: new Date(),
|
|
color: null,
|
|
},
|
|
};
|
|
|
|
it("should throw if no headers", () => {
|
|
expect(() => generateCsvRawForMembersTable([], [], mockAttributeIds, orgDomain)).toThrow();
|
|
});
|
|
|
|
it("should generate correct CSV headers", () => {
|
|
const mockTable = createMockTable([]);
|
|
const csv = generateCsvRawForMembersTable(
|
|
generateHeaderFromReactTable(mockTable) ?? [],
|
|
[],
|
|
mockAttributeIds,
|
|
orgDomain
|
|
);
|
|
const headers = csv?.split("\n")[0];
|
|
expect(headers).toBe("Members,Link,Role,Teams,Attribute 1,Attribute 2");
|
|
});
|
|
|
|
it("should handle user with single attribute value", () => {
|
|
const mockData: UserTableUser[] = [
|
|
{
|
|
...mockUser,
|
|
teams: [{ id: 1, name: "Team1", slug: "team1" }],
|
|
attributes: [
|
|
{
|
|
id: "1",
|
|
attributeId: "attr1",
|
|
value: "value1",
|
|
slug: "slug1",
|
|
contains: [],
|
|
weight: 0,
|
|
isGroup: false,
|
|
},
|
|
],
|
|
},
|
|
];
|
|
|
|
const mockTable = createMockTable(mockData);
|
|
const csv = generateCsvRawForMembersTable(
|
|
generateHeaderFromReactTable(mockTable) ?? [],
|
|
mockData,
|
|
mockAttributeIds,
|
|
orgDomain
|
|
);
|
|
|
|
expect(csv).toMatchInlineSnapshot(`
|
|
"Members,Link,Role,Teams,Attribute 1,Attribute 2
|
|
test@example.com,https://acme.cal.com/testuser,MEMBER,Team1,value1,"
|
|
`);
|
|
});
|
|
|
|
it("should handle user with multiple attribute values for same attribute", () => {
|
|
const mockData: UserTableUser[] = [
|
|
{
|
|
...mockUser,
|
|
teams: [{ id: 1, name: "Team1", slug: "team1" }],
|
|
attributes: [
|
|
{
|
|
id: "1",
|
|
attributeId: "attr1",
|
|
value: "value1",
|
|
slug: "slug1",
|
|
contains: [],
|
|
weight: 0,
|
|
isGroup: false,
|
|
},
|
|
{
|
|
id: "2",
|
|
attributeId: "attr1",
|
|
value: "value2",
|
|
slug: "slug1",
|
|
contains: [],
|
|
weight: 0,
|
|
isGroup: false,
|
|
},
|
|
],
|
|
},
|
|
];
|
|
|
|
const mockTable = createMockTable(mockData);
|
|
const csv = generateCsvRawForMembersTable(
|
|
generateHeaderFromReactTable(mockTable) ?? [],
|
|
mockData,
|
|
mockAttributeIds,
|
|
orgDomain
|
|
);
|
|
|
|
expect(csv).toMatchInlineSnapshot(`
|
|
"Members,Link,Role,Teams,Attribute 1,Attribute 2
|
|
test@example.com,https://acme.cal.com/testuser,MEMBER,Team1,"value1,value2","
|
|
`);
|
|
});
|
|
|
|
it("should handle user with multiple teams", () => {
|
|
const mockData: UserTableUser[] = [
|
|
{
|
|
...mockUser,
|
|
teams: [
|
|
{ id: 1, name: "Team1", slug: "team1" },
|
|
{ id: 2, name: "Team2", slug: "team2" },
|
|
],
|
|
attributes: [],
|
|
},
|
|
];
|
|
|
|
const mockTable = createMockTable(mockData);
|
|
const csv = generateCsvRawForMembersTable(
|
|
generateHeaderFromReactTable(mockTable) ?? [],
|
|
mockData,
|
|
mockAttributeIds,
|
|
orgDomain
|
|
);
|
|
|
|
expect(csv).toMatchInlineSnapshot(`
|
|
"Members,Link,Role,Teams,Attribute 1,Attribute 2
|
|
test@example.com,https://acme.cal.com/testuser,MEMBER,"Team1,Team2",,"
|
|
`);
|
|
});
|
|
|
|
it("should handle values that need sanitization", () => {
|
|
const mockData: UserTableUser[] = [
|
|
{
|
|
...mockUser,
|
|
teams: [{ id: 1, name: "Team,1", slug: "team1" }],
|
|
attributes: [
|
|
{
|
|
id: "1",
|
|
attributeId: "attr1",
|
|
value: "value,1",
|
|
slug: "slug1",
|
|
contains: [],
|
|
weight: 0,
|
|
isGroup: false,
|
|
},
|
|
],
|
|
},
|
|
];
|
|
|
|
const mockTable = createMockTable(mockData);
|
|
const csv = generateCsvRawForMembersTable(
|
|
generateHeaderFromReactTable(mockTable) ?? [],
|
|
mockData,
|
|
mockAttributeIds,
|
|
orgDomain
|
|
);
|
|
|
|
expect(csv).toMatchInlineSnapshot(`
|
|
"Members,Link,Role,Teams,Attribute 1,Attribute 2
|
|
test@example.com,https://acme.cal.com/testuser,MEMBER,"Team,1","value,1","
|
|
`);
|
|
});
|
|
|
|
it("should handle all membership roles", () => {
|
|
const roles: MembershipRole[] = ["OWNER", "ADMIN", "MEMBER"];
|
|
const mockData: UserTableUser[] = roles.map((role) => ({
|
|
...mockUser,
|
|
username: role.toLowerCase(),
|
|
role,
|
|
email: `${role.toLowerCase()}@example.com`,
|
|
}));
|
|
|
|
const mockTable = createMockTable(mockData);
|
|
const csv = generateCsvRawForMembersTable(
|
|
generateHeaderFromReactTable(mockTable) ?? [],
|
|
mockData,
|
|
mockAttributeIds,
|
|
orgDomain
|
|
);
|
|
|
|
expect(csv).toMatchInlineSnapshot(`
|
|
"Members,Link,Role,Teams,Attribute 1,Attribute 2
|
|
owner@example.com,https://acme.cal.com/owner,OWNER,,,
|
|
admin@example.com,https://acme.cal.com/admin,ADMIN,,,
|
|
member@example.com,https://acme.cal.com/member,MEMBER,,,"
|
|
`);
|
|
});
|
|
|
|
it("should handle users without teams and attributes", () => {
|
|
const mockData: UserTableUser[] = [
|
|
{
|
|
...mockUser,
|
|
username: "testuser",
|
|
avatarUrl: null,
|
|
},
|
|
];
|
|
|
|
const mockTable = createMockTable(mockData);
|
|
const csv = generateCsvRawForMembersTable(
|
|
generateHeaderFromReactTable(mockTable) ?? [],
|
|
mockData,
|
|
mockAttributeIds,
|
|
orgDomain
|
|
);
|
|
|
|
expect(csv).toMatchInlineSnapshot(`
|
|
"Members,Link,Role,Teams,Attribute 1,Attribute 2
|
|
test@example.com,https://acme.cal.com/testuser,MEMBER,,,"
|
|
`);
|
|
});
|
|
});
|