From f11086e9f8fb4eae41431cb6b5ce6dd356aed0fb Mon Sep 17 00:00:00 2001
From: Maximilian Franzke <787658+mfranzke@users.noreply.github.com>
Date: Thu, 12 Sep 2024 09:59:27 +0200
Subject: [PATCH] fix(ally): button (#16588)

The close button would actually need to be a `button` instead of a `span` HTML element to be both screenreader and keyboard user accessible, as well as having an accessible label.

Co-authored-by: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com>
---
 packages/embeds/embed-core/src/ModalBox/ModalBoxHtml.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/embeds/embed-core/src/ModalBox/ModalBoxHtml.ts b/packages/embeds/embed-core/src/ModalBox/ModalBoxHtml.ts
index c45781f3e4..5617d2c9d1 100644
--- a/packages/embeds/embed-core/src/ModalBox/ModalBoxHtml.ts
+++ b/packages/embeds/embed-core/src/ModalBox/ModalBoxHtml.ts
@@ -41,7 +41,7 @@ const html = `<style>
 </style>
 <div class="my-backdrop">
 <div class="header">
-  <span class="close">&times;</span>
+  <button type="button" class="close" aria-label="Close">&times;</button>
 </div>
 <div class="modal-box">
   <div class="body">