From f09153b3bb93f615a61487576e0db8fb05955cb4 Mon Sep 17 00:00:00 2001
From: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>
Date: Tue, 6 Feb 2024 09:40:22 +0530
Subject: [PATCH] fix: don't display setup page icon for these apps (#13537)

* fix: don't display setup page icon for these apps

* chore: make it optional

* chore: feedback

---------

Co-authored-by: Keith Williams <keithwillcode@gmail.com>
---
 packages/app-store/_components/AppCard.tsx             | 10 +++++++---
 .../fathom/components/EventTypeAppCardInterface.tsx    |  1 +
 .../ga4/components/EventTypeAppCardInterface.tsx       |  1 +
 .../gtm/components/EventTypeAppCardInterface.tsx       |  1 +
 .../matomo/components/EventTypeAppCardInterface.tsx    |  1 +
 .../metapixel/components/EventTypeAppCardInterface.tsx |  1 +
 .../plausible/components/EventTypeAppCardInterface.tsx |  1 +
 7 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/packages/app-store/_components/AppCard.tsx b/packages/app-store/_components/AppCard.tsx
index 4445b2fb5d..a4d744532e 100644
--- a/packages/app-store/_components/AppCard.tsx
+++ b/packages/app-store/_components/AppCard.tsx
@@ -21,6 +21,7 @@ export default function AppCard({
   teamId,
   disableSwitch,
   switchTooltip,
+  hideSettingsIcon = false,
 }: {
   app: RouterOutputs["viewer"]["integrations"]["items"][number] & { credentialOwner?: CredentialOwner };
   description?: React.ReactNode;
@@ -32,6 +33,7 @@ export default function AppCard({
   LockedIcon?: React.ReactNode;
   disableSwitch?: boolean;
   switchTooltip?: string;
+  hideSettingsIcon?: boolean;
 }) {
   const { t } = useTranslation();
   const [animationRef] = useAutoAnimate<HTMLDivElement>();
@@ -124,9 +126,11 @@ export default function AppCard({
         {app?.isInstalled && switchChecked ? (
           app.isSetupAlready === undefined || app.isSetupAlready ? (
             <div className="relative p-4 pt-5 text-sm [&_input]:mb-0 [&_input]:leading-4">
-              <Link href={`/apps/${app.slug}/setup`} className="absolute right-4 top-4">
-                <Settings className="text-default h-4 w-4" aria-hidden="true" />
-              </Link>
+              {!hideSettingsIcon && (
+                <Link href={`/apps/${app.slug}/setup`} className="absolute right-4 top-4">
+                  <Settings className="text-default h-4 w-4" aria-hidden="true" />
+                </Link>
+              )}
               {children}
             </div>
           ) : (
diff --git a/packages/app-store/fathom/components/EventTypeAppCardInterface.tsx b/packages/app-store/fathom/components/EventTypeAppCardInterface.tsx
index 5320587871..1d30ac8904 100644
--- a/packages/app-store/fathom/components/EventTypeAppCardInterface.tsx
+++ b/packages/app-store/fathom/components/EventTypeAppCardInterface.tsx
@@ -13,6 +13,7 @@ const EventTypeAppCard: EventTypeAppCardComponent = function EventTypeAppCard({
 
   return (
     <AppCard
+      hideSettingsIcon
       app={app}
       switchOnClick={(e) => {
         updateEnabled(e);
diff --git a/packages/app-store/ga4/components/EventTypeAppCardInterface.tsx b/packages/app-store/ga4/components/EventTypeAppCardInterface.tsx
index 5320587871..1d30ac8904 100644
--- a/packages/app-store/ga4/components/EventTypeAppCardInterface.tsx
+++ b/packages/app-store/ga4/components/EventTypeAppCardInterface.tsx
@@ -13,6 +13,7 @@ const EventTypeAppCard: EventTypeAppCardComponent = function EventTypeAppCard({
 
   return (
     <AppCard
+      hideSettingsIcon
       app={app}
       switchOnClick={(e) => {
         updateEnabled(e);
diff --git a/packages/app-store/gtm/components/EventTypeAppCardInterface.tsx b/packages/app-store/gtm/components/EventTypeAppCardInterface.tsx
index 5320587871..1d30ac8904 100644
--- a/packages/app-store/gtm/components/EventTypeAppCardInterface.tsx
+++ b/packages/app-store/gtm/components/EventTypeAppCardInterface.tsx
@@ -13,6 +13,7 @@ const EventTypeAppCard: EventTypeAppCardComponent = function EventTypeAppCard({
 
   return (
     <AppCard
+      hideSettingsIcon
       app={app}
       switchOnClick={(e) => {
         updateEnabled(e);
diff --git a/packages/app-store/matomo/components/EventTypeAppCardInterface.tsx b/packages/app-store/matomo/components/EventTypeAppCardInterface.tsx
index f71200486f..a17122f346 100644
--- a/packages/app-store/matomo/components/EventTypeAppCardInterface.tsx
+++ b/packages/app-store/matomo/components/EventTypeAppCardInterface.tsx
@@ -14,6 +14,7 @@ const EventTypeAppCard: EventTypeAppCardComponent = function EventTypeAppCard({
 
   return (
     <AppCard
+      hideSettingsIcon
       app={app}
       switchOnClick={(e) => {
         updateEnabled(e);
diff --git a/packages/app-store/metapixel/components/EventTypeAppCardInterface.tsx b/packages/app-store/metapixel/components/EventTypeAppCardInterface.tsx
index 668523d3ad..b61b3b71fa 100644
--- a/packages/app-store/metapixel/components/EventTypeAppCardInterface.tsx
+++ b/packages/app-store/metapixel/components/EventTypeAppCardInterface.tsx
@@ -13,6 +13,7 @@ const EventTypeAppCard: EventTypeAppCardComponent = function EventTypeAppCard({
 
   return (
     <AppCard
+      hideSettingsIcon
       app={app}
       switchOnClick={updateEnabled}
       switchChecked={enabled}
diff --git a/packages/app-store/plausible/components/EventTypeAppCardInterface.tsx b/packages/app-store/plausible/components/EventTypeAppCardInterface.tsx
index fc176fc533..d22c061e69 100644
--- a/packages/app-store/plausible/components/EventTypeAppCardInterface.tsx
+++ b/packages/app-store/plausible/components/EventTypeAppCardInterface.tsx
@@ -14,6 +14,7 @@ const EventTypeAppCard: EventTypeAppCardComponent = function EventTypeAppCard({
 
   return (
     <AppCard
+      hideSettingsIcon
       app={app}
       switchOnClick={(e) => {
         updateEnabled(e);