From ee16d1d4746f41e694ac6eae6853b331c73f5ed9 Mon Sep 17 00:00:00 2001 From: Qiaochu Hu <110hqc@gmail.com> Date: Wed, 22 Apr 2026 13:38:15 +0800 Subject: [PATCH] fix: use strict equality in webhook delete handler role check (#28958) Replaced `==` with `===` for the ADMIN role comparison to follow TypeScript best practices and match the project's coding conventions. Co-authored-by: Test User Co-authored-by: Claude Opus 4.7 --- packages/trpc/server/routers/viewer/webhook/delete.handler.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/trpc/server/routers/viewer/webhook/delete.handler.ts b/packages/trpc/server/routers/viewer/webhook/delete.handler.ts index e2f09fe31f..24ec520406 100644 --- a/packages/trpc/server/routers/viewer/webhook/delete.handler.ts +++ b/packages/trpc/server/routers/viewer/webhook/delete.handler.ts @@ -20,7 +20,7 @@ export const deleteHandler = async ({ ctx, input }: DeleteOptions) => { if (Array.isArray(where.AND)) { if (input.eventTypeId) { where.AND.push({ eventTypeId: input.eventTypeId }); - } else if (ctx.user.role == "ADMIN") { + } else if (ctx.user.role === "ADMIN") { where.AND.push({ OR: [{ platform: true }, { userId: ctx.user.id }] }); } else { where.AND.push({ userId: ctx.user.id });