From e2a825a9a0a94fab55bcab6f1eee4906660cf4bd Mon Sep 17 00:00:00 2001 From: Keith Williams Date: Tue, 15 Oct 2024 08:23:52 -0300 Subject: [PATCH] Revert "feat: update github workflows to install playwright in a separate job (#17070)" (#17114) This reverts commit 0b3b268eed75945eb91c3e4b34637af7b57c6160. --- .github/workflows/pr.yml | 20 +++++--------------- .github/workflows/yarn-install.yml | 1 + 2 files changed, 6 insertions(+), 15 deletions(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 98c1a84d6f..41d7e78bb5 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -97,16 +97,6 @@ jobs: if: ${{ needs.changes.outputs.has-files-requiring-all-checks == 'true' }} uses: ./.github/workflows/yarn-install.yml - install-playwright: - name: Install playwright - runs-on: buildjet-2vcpu-ubuntu-2204 - needs: [changes, check-label, deps] - if: ${{ needs.check-label.outputs.run-e2e == 'true' && needs.changes.outputs.has-files-requiring-all-checks == 'true' }} - steps: - - uses: actions/checkout@v4 - - uses: ./.github/actions/dangerous-git-checkout - - uses: ./.github/actions/yarn-playwright-install - type-check: name: Type check needs: [changes, check-label, deps] @@ -172,35 +162,35 @@ jobs: e2e: name: Tests - needs: [changes, check-label, build, build-api-v1, build-api-v2, install-playwright] + needs: [changes, check-label, build, build-api-v1, build-api-v2] if: ${{ needs.check-label.outputs.run-e2e == 'true' && needs.changes.outputs.has-files-requiring-all-checks == 'true' }} uses: ./.github/workflows/e2e.yml secrets: inherit e2e-api-v2: name: Tests - needs: [changes, check-label, build, build-api-v1, build-api-v2, install-playwright] + needs: [changes, check-label, build, build-api-v1, build-api-v2] if: ${{ needs.check-label.outputs.run-e2e == 'true' && needs.changes.outputs.has-files-requiring-all-checks == 'true' }} uses: ./.github/workflows/e2e-api-v2.yml secrets: inherit e2e-app-store: name: Tests - needs: [changes, check-label, build, build-api-v1, build-api-v2, install-playwright] + needs: [changes, check-label, build, build-api-v1, build-api-v2] if: ${{ needs.check-label.outputs.run-e2e == 'true' && needs.changes.outputs.has-files-requiring-all-checks == 'true' }} uses: ./.github/workflows/e2e-app-store.yml secrets: inherit e2e-embed: name: Tests - needs: [changes, check-label, build, build-api-v1, build-api-v2, install-playwright] + needs: [changes, check-label, build, build-api-v1, build-api-v2] if: ${{ needs.check-label.outputs.run-e2e == 'true' && needs.changes.outputs.has-files-requiring-all-checks == 'true' }} uses: ./.github/workflows/e2e-embed.yml secrets: inherit e2e-embed-react: name: Tests - needs: [changes, check-label, build, build-api-v1, build-api-v2, install-playwright] + needs: [changes, check-label, build, build-api-v1, build-api-v2] if: ${{ needs.check-label.outputs.run-e2e == 'true' && needs.changes.outputs.has-files-requiring-all-checks == 'true' }} uses: ./.github/workflows/e2e-embed-react.yml secrets: inherit diff --git a/.github/workflows/yarn-install.yml b/.github/workflows/yarn-install.yml index 9e6821406b..6909eb95f2 100644 --- a/.github/workflows/yarn-install.yml +++ b/.github/workflows/yarn-install.yml @@ -15,3 +15,4 @@ jobs: - uses: actions/checkout@v4 - uses: ./.github/actions/dangerous-git-checkout - uses: ./.github/actions/yarn-install + - uses: ./.github/actions/yarn-playwright-install