From d5420eda009704c7f3f4d83ee173cd75ccecd675 Mon Sep 17 00:00:00 2001 From: Lauris Skraucis Date: Fri, 14 Feb 2025 11:59:10 +0100 Subject: [PATCH] chore: disable v2 booking seats safe parse error logs (#19292) --- .../2024-08-13/services/output.service.ts | 12 ++++++---- apps/api/v2/src/lib/safe-parse/safe-parse.ts | 23 ++++++++++++------- 2 files changed, 23 insertions(+), 12 deletions(-) diff --git a/apps/api/v2/src/ee/bookings/2024-08-13/services/output.service.ts b/apps/api/v2/src/ee/bookings/2024-08-13/services/output.service.ts index 99456ea4e3..cf298326c9 100644 --- a/apps/api/v2/src/ee/bookings/2024-08-13/services/output.service.ts +++ b/apps/api/v2/src/ee/bookings/2024-08-13/services/output.service.ts @@ -286,7 +286,8 @@ export class OutputBookingsService_2024_08_13 { const { responses } = safeParse( seatedBookingDataSchema, attendee.bookingSeat?.data, - defaultSeatedBookingData + defaultSeatedBookingData, + false ); const attendeeData = { @@ -303,7 +304,8 @@ export class OutputBookingsService_2024_08_13 { attendeeParsed.metadata = safeParse( seatedBookingMetadataSchema, attendee.bookingSeat?.metadata, - defaultSeatedBookingMetadata + defaultSeatedBookingMetadata, + false ); // note(Lauris): as of now email is not returned for privacy delete attendeeParsed.bookingFieldsResponses.email; @@ -395,7 +397,8 @@ export class OutputBookingsService_2024_08_13 { const { responses } = safeParse( seatedBookingDataSchema, attendee.bookingSeat?.data, - defaultSeatedBookingData + defaultSeatedBookingData, + false ); const attendeeData = { @@ -412,7 +415,8 @@ export class OutputBookingsService_2024_08_13 { attendeeParsed.metadata = safeParse( seatedBookingMetadataSchema, attendee.bookingSeat?.metadata, - defaultSeatedBookingMetadata + defaultSeatedBookingMetadata, + false ); // note(Lauris): as of now email is not returned for privacy delete attendeeParsed.bookingFieldsResponses.email; diff --git a/apps/api/v2/src/lib/safe-parse/safe-parse.ts b/apps/api/v2/src/lib/safe-parse/safe-parse.ts index 198cb22e08..fdaacd409f 100644 --- a/apps/api/v2/src/lib/safe-parse/safe-parse.ts +++ b/apps/api/v2/src/lib/safe-parse/safe-parse.ts @@ -3,20 +3,27 @@ import { ZodSchema } from "zod"; const logger = new Logger("safeParse"); -export function safeParse(schema: ZodSchema, value: unknown, defaultValue: T): T { +export function safeParse( + schema: ZodSchema, + value: unknown, + defaultValue: T, + logError = true +): T { const result = schema.safeParse(value); if (result.success) { return result.data; } else { const errorStack = new Error().stack; - logger.error( - `Zod parsing failed.\n` + - `1. Schema: ${schema.description || "UnnamedSchema"}\n` + - `2. Input: ${JSON.stringify(value, null, 2)}\n` + - `3. Zod Error: ${result.error}\n` + - `4. Call Stack: ${errorStack}` - ); + if (logError) { + logger.error( + `Zod parsing failed.\n` + + `1. Schema: ${schema.description || "UnnamedSchema"}\n` + + `2. Input: ${JSON.stringify(value, null, 2)}\n` + + `3. Zod Error: ${result.error}\n` + + `4. Call Stack: ${errorStack}` + ); + } return defaultValue; }