From d2f76edfd691793a0794d54869cf65c85947bcd1 Mon Sep 17 00:00:00 2001 From: Joe Au-Yeung <65426560+joeauyeung@users.noreply.github.com> Date: Mon, 3 Jun 2024 10:53:03 -0400 Subject: [PATCH] fix: Double encoding in `addAppMutation` (#15303) * Remove double encoding * Add test for OAuth page * Add tests * Remove test from integrations.e2e --- apps/web/playwright/app-store.e2e.ts | 13 +++++++++++++ packages/app-store/_utils/useAddAppMutation.ts | 2 +- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/apps/web/playwright/app-store.e2e.ts b/apps/web/playwright/app-store.e2e.ts index dc82b7274e..adaefc32b3 100644 --- a/apps/web/playwright/app-store.e2e.ts +++ b/apps/web/playwright/app-store.e2e.ts @@ -33,6 +33,19 @@ testBothFutureAndLegacyRoutes.describe("App Store - Authed", (routeVariant) => { await expect(page.locator(`text=Connect to Apple Server`)).toBeVisible(); }); + test("Can add Google calendar from the app store", async ({ page, users }) => { + const user = await users.create(); + await user.apiLogin(); + + await page.goto("/apps/google-calendar"); + + await page.getByTestId("install-app-button").click(); + + await page.waitForNavigation(); + + await expect(page.url()).toContain("accounts.google.com"); + }); + test("Installed Apps - Navigation", async ({ page, users }) => { const user = await users.create(); await user.apiLogin(); diff --git a/packages/app-store/_utils/useAddAppMutation.ts b/packages/app-store/_utils/useAddAppMutation.ts index 43f6396af2..537b0b739d 100644 --- a/packages/app-store/_utils/useAddAppMutation.ts +++ b/packages/app-store/_utils/useAddAppMutation.ts @@ -88,7 +88,7 @@ function useAddAppMutation(_type: App["type"] | null, allOptions?: UseAddAppMuta ...(defaultInstall && { defaultInstall }), }; - const stateStr = encodeURIComponent(JSON.stringify(state)); + const stateStr = JSON.stringify(state); const searchParams = generateSearchParamString({ stateStr, teamId, returnTo }); const res = await fetch(`/api/integrations/${type}/add${searchParams}`);