From bc34e671919998f2e5fcaccdd454f2af5855804e Mon Sep 17 00:00:00 2001 From: Somay Chauhan Date: Mon, 23 Sep 2024 12:21:23 +0530 Subject: [PATCH] refactor: event limits web wrapper (#16679) * chore: EventTypeWebWrapper base pr * fixup! chore: EventTypeWebWrapper base pr * fixup! Merge branch 'main' into morgan/cal-4183-eventtypeatom-web-wrapper-base * wip * fix: error * Event type atom wrapper handles app dir * fixup! Merge branch 'main' into morgan/cal-4183-eventtypeatom-web-wrapper-base * fixup! fixup! Merge branch 'main' into morgan/cal-4183-eventtypeatom-web-wrapper-base * remove console log * review comments * refactor: event limits tab for atoms * fixup! review comments --------- Co-authored-by: Morgan Vernay Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com> --- .../eventtypes/components/tabs/limits/EventLimitsTab.tsx | 4 +++- .../event-types/wrappers/EventLimitsTabWebWrapper.tsx | 8 ++++++++ .../atoms/event-types/wrappers/EventTypeWebWrapper.tsx | 4 +--- 3 files changed, 12 insertions(+), 4 deletions(-) create mode 100644 packages/platform/atoms/event-types/wrappers/EventLimitsTabWebWrapper.tsx diff --git a/packages/features/eventtypes/components/tabs/limits/EventLimitsTab.tsx b/packages/features/eventtypes/components/tabs/limits/EventLimitsTab.tsx index 83b7e58551..b320369bdb 100644 --- a/packages/features/eventtypes/components/tabs/limits/EventLimitsTab.tsx +++ b/packages/features/eventtypes/components/tabs/limits/EventLimitsTab.tsx @@ -23,6 +23,8 @@ import { Button, DateRangePicker, InputField, Label, Select, SettingsToggle, Tex type IPeriodType = (typeof PeriodType)[keyof typeof PeriodType]; +export type EventLimitsTabProps = Pick; + /** * We technically have a ROLLING_WINDOW future limit option that isn't shown as a Radio Option. Because UX is better by providing it as a toggle with ROLLING Limit radio option. * Also, ROLLING_WINDOW reuses the same `periodDays` field and `periodCountCalendarDays` fields @@ -286,7 +288,7 @@ const MinimumBookingNoticeInput = React.forwardRef< ); }); -export const EventLimitsTab = ({ eventType }: Pick) => { +export const EventLimitsTab = ({ eventType }: EventLimitsTabProps) => { const { t, i18n } = useLocale(); const formMethods = useFormContext(); diff --git a/packages/platform/atoms/event-types/wrappers/EventLimitsTabWebWrapper.tsx b/packages/platform/atoms/event-types/wrappers/EventLimitsTabWebWrapper.tsx new file mode 100644 index 0000000000..70607aeb38 --- /dev/null +++ b/packages/platform/atoms/event-types/wrappers/EventLimitsTabWebWrapper.tsx @@ -0,0 +1,8 @@ +import { EventLimitsTab } from "@calcom/features/eventtypes/components/tabs/limits/EventLimitsTab"; +import type { EventLimitsTabProps } from "@calcom/features/eventtypes/components/tabs/limits/EventLimitsTab"; + +const EventLimitsTabWebWrapper = (props: EventLimitsTabProps) => { + return ; +}; + +export default EventLimitsTabWebWrapper; diff --git a/packages/platform/atoms/event-types/wrappers/EventTypeWebWrapper.tsx b/packages/platform/atoms/event-types/wrappers/EventTypeWebWrapper.tsx index 690f6037dd..f103dd0b60 100644 --- a/packages/platform/atoms/event-types/wrappers/EventTypeWebWrapper.tsx +++ b/packages/platform/atoms/event-types/wrappers/EventTypeWebWrapper.tsx @@ -50,9 +50,7 @@ const EventTeamAssignmentTab = dynamic(() => const EventLimitsTab = dynamic(() => // import web wrapper when it's ready - import("@calcom/features/eventtypes/components/tabs/limits/EventLimitsTab").then( - (mod) => mod.EventLimitsTab - ) + import("./EventLimitsTabWebWrapper").then((mod) => mod) ); const EventAdvancedTab = dynamic(() =>