From 8d0f0d48993d4a26133bc18ce68d1124648fa690 Mon Sep 17 00:00:00 2001 From: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com> Date: Thu, 12 Dec 2024 17:57:43 -0500 Subject: [PATCH] fix: default to 100 when attribute weight undefined (#18145) Co-authored-by: CarinaWolli --- packages/lib/server/getLuckyUser.ts | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/packages/lib/server/getLuckyUser.ts b/packages/lib/server/getLuckyUser.ts index 75dc7989d3..5c5f365e1b 100644 --- a/packages/lib/server/getLuckyUser.ts +++ b/packages/lib/server/getLuckyUser.ts @@ -868,15 +868,15 @@ function getAverageAttributeWeights< ); allRRHosts.forEach((rrHost) => { - const weight = attributeOptionWithUsers?.assignedUsers.find( + const assignedUser = attributeOptionWithUsers?.assignedUsers.find( (assignedUser) => rrHost.user.id === assignedUser.member.userId - )?.weight; + ); - if (weight) { + if (assignedUser) { if (allRRHostsWeights.has(rrHost.user.id)) { - allRRHostsWeights.get(rrHost.user.id)?.push(weight); + allRRHostsWeights.get(rrHost.user.id)?.push(assignedUser.weight ?? 100); } else { - allRRHostsWeights.set(rrHost.user.id, [weight]); + allRRHostsWeights.set(rrHost.user.id, [assignedUser.weight ?? 100]); } } }); @@ -897,6 +897,7 @@ function getAverageAttributeWeights< "getAverageAttributeWeights", safeStringify({ allRRHosts, attributesQueryValueChild, attributeWithWeights, averageWeightsHosts }) ); + return averageWeightsHosts; }