From 7b970022307d5aaa5f64abcbdeefdc2e473383f7 Mon Sep 17 00:00:00 2001 From: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com> Date: Fri, 14 Mar 2025 08:58:13 +0530 Subject: [PATCH] fix: flaky test in ooo e2e (#20073) * fix: flaky test in ooo e2e * tweak --- apps/web/playwright/out-of-office.e2e.ts | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/apps/web/playwright/out-of-office.e2e.ts b/apps/web/playwright/out-of-office.e2e.ts index daf7718797..69901431ec 100644 --- a/apps/web/playwright/out-of-office.e2e.ts +++ b/apps/web/playwright/out-of-office.e2e.ts @@ -766,12 +766,10 @@ test.describe("Out of office", () => { await test.step("Default filter - 'Last 7 Days'", async () => { await page.locator('[data-testid="add-filter-button"]').click(); await page.locator('[data-testid="add-filter-item-dateRange"]').click(); - await page.locator('[data-testid="add-filter-button"]').click(); - const entriesListRespPromise = page.waitForResponse( + await page.waitForResponse( (response) => response.url().includes("outOfOfficeEntriesList") && response.status() === 200 ); await page.locator('[data-testid="add-filter-button"]').click(); - await entriesListRespPromise; //1 OOO record should be visible for member3, end=currentDate-4days expect(await page.locator('[data-testid^="table-redirect-"]').count()).toBe(1); @@ -783,12 +781,11 @@ test.describe("Out of office", () => { //Select 'Last 30 Days' await test.step("select 'Last 30 Days'", async () => { await page.locator('[data-testid="filter-popover-trigger-dateRange"]').click(); - const entriesListRespPromise = page.waitForResponse( + await page.locator(`[data-testid="date-range-options-t"]`).click(); + await page.waitForResponse( (response) => response.url().includes("outOfOfficeEntriesList") && response.status() === 200 ); - await page.locator(`[data-testid="date-range-options-t"]`).click(); await page.locator('[data-testid="filter-popover-trigger-dateRange"]').click(); - await entriesListRespPromise; //2 OOO records should be visible end=currentDate-4days, end=currentDate-12days expect(await page.locator('[data-testid^="table-redirect-"]').count()).toBe(2);