From 68c036cd0afd4da7661d5436bcf39d1f2b4e35c3 Mon Sep 17 00:00:00 2001
From: Keith Williams <keithwillcode@gmail.com>
Date: Tue, 15 Apr 2025 16:43:54 -0300
Subject: [PATCH] fix: Tasker import and error handling for routing form
 responses (#20713)

---
 .../app-store/routing-forms/trpc/utils.ts     | 81 +++++++++----------
 1 file changed, 39 insertions(+), 42 deletions(-)

diff --git a/packages/app-store/routing-forms/trpc/utils.ts b/packages/app-store/routing-forms/trpc/utils.ts
index 1f4f4697ce..e42bce2c6d 100644
--- a/packages/app-store/routing-forms/trpc/utils.ts
+++ b/packages/app-store/routing-forms/trpc/utils.ts
@@ -159,54 +159,51 @@ export async function onFormSubmission(
     });
   });
 
-  let tasker: Tasker;
-
   if (typeof window === "undefined") {
-    import("@calcom/features/tasker")
-      .then((module) => {
-        tasker = module.default;
-      })
-      .catch((error) => {
-        console.error("Failed to load tasker:", error);
+    try {
+      const tasker: Tasker = await (await import("@calcom/features/tasker")).default;
+      const promisesFormSubmittedNoEvent = webhooksFormSubmittedNoEvent.map((webhook) => {
+        const scheduledAt = dayjs().add(15, "minute").toDate();
+
+        return tasker.create(
+          "triggerFormSubmittedNoEventWebhook",
+          {
+            responseId,
+            form,
+            responses: fieldResponsesByIdentifier,
+            redirect: chosenAction,
+            webhook,
+          },
+          { scheduledAt }
+        );
       });
-  }
 
-  const promisesFormSubmittedNoEvent = webhooksFormSubmittedNoEvent.map((webhook) => {
-    const scheduledAt = dayjs().add(15, "minute").toDate();
+      const promises = [...promisesFormSubmitted, ...promisesFormSubmittedNoEvent];
 
-    return tasker.create(
-      "triggerFormSubmittedNoEventWebhook",
-      {
-        responseId,
-        form,
-        responses: fieldResponsesByIdentifier,
-        redirect: chosenAction,
-        webhook,
-      },
-      { scheduledAt }
-    );
-  });
+      await Promise.all(promises);
+      const orderedResponses = form.fields.reduce((acc, field) => {
+        acc.push(response[field.id]);
+        return acc;
+      }, [] as OrderedResponses);
 
-  const promises = [...promisesFormSubmitted, ...promisesFormSubmittedNoEvent];
-
-  await Promise.all(promises);
-  const orderedResponses = form.fields.reduce((acc, field) => {
-    acc.push(response[field.id]);
-    return acc;
-  }, [] as OrderedResponses);
-
-  if (form.teamId) {
-    if (form.userWithEmails?.length) {
-      moduleLogger.debug(
-        `Preparing to send Form Response email for Form:${form.id} to users: ${form.userWithEmails.join(",")}`
-      );
-      await sendResponseEmail(form, orderedResponses, form.userWithEmails);
+      if (form.teamId) {
+        if (form.userWithEmails?.length) {
+          moduleLogger.debug(
+            `Preparing to send Form Response email for Form:${form.id} to users: ${form.userWithEmails.join(
+              ","
+            )}`
+          );
+          await sendResponseEmail(form, orderedResponses, form.userWithEmails);
+        }
+      } else if (form.settings?.emailOwnerOnSubmission) {
+        moduleLogger.debug(
+          `Preparing to send Form Response email for Form:${form.id} to form owner: ${form.user.email}`
+        );
+        await sendResponseEmail(form, orderedResponses, [form.user.email]);
+      }
+    } catch (e) {
+      moduleLogger.error("Error triggering routing form response side effects", e);
     }
-  } else if (form.settings?.emailOwnerOnSubmission) {
-    moduleLogger.debug(
-      `Preparing to send Form Response email for Form:${form.id} to form owner: ${form.user.email}`
-    );
-    await sendResponseEmail(form, orderedResponses, [form.user.email]);
   }
 }