From 2d9162a4dd5e209aa1f08e9c4dcbe0c954050499 Mon Sep 17 00:00:00 2001 From: Benny Joo Date: Wed, 27 Aug 2025 07:52:27 -0400 Subject: [PATCH] perf: use promise all when possible in RSCs (#23384) --- .../(settings-layout)/my-account/calendars/page.tsx | 12 +++++++----- .../organizations/(org-admin-only)/privacy/page.tsx | 4 ++-- .../organizations/(org-user-only)/members/page.tsx | 4 +--- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/apps/web/app/(use-page-wrapper)/settings/(settings-layout)/my-account/calendars/page.tsx b/apps/web/app/(use-page-wrapper)/settings/(settings-layout)/my-account/calendars/page.tsx index f39140fc8c..c1ec4259ee 100644 --- a/apps/web/app/(use-page-wrapper)/settings/(settings-layout)/my-account/calendars/page.tsx +++ b/apps/web/app/(use-page-wrapper)/settings/(settings-layout)/my-account/calendars/page.tsx @@ -21,11 +21,13 @@ const Page = async () => { createRouterCaller(appsRouter), ]); - const connectedCalendars = await calendarsCaller.connectedCalendars(); - const installedCalendars = await appsCaller.integrations({ - variant: "calendar", - onlyInstalled: true, - }); + const [connectedCalendars, installedCalendars] = await Promise.all([ + calendarsCaller.connectedCalendars(), + appsCaller.integrations({ + variant: "calendar", + onlyInstalled: true, + }), + ]); return ( ); diff --git a/apps/web/app/(use-page-wrapper)/settings/(settings-layout)/organizations/(org-admin-only)/privacy/page.tsx b/apps/web/app/(use-page-wrapper)/settings/(settings-layout)/organizations/(org-admin-only)/privacy/page.tsx index 7a4e75a2f4..5423446d54 100644 --- a/apps/web/app/(use-page-wrapper)/settings/(settings-layout)/organizations/(org-admin-only)/privacy/page.tsx +++ b/apps/web/app/(use-page-wrapper)/settings/(settings-layout)/organizations/(org-admin-only)/privacy/page.tsx @@ -21,9 +21,9 @@ export const generateMetadata = async () => ); const Page = async () => { - const t = await getTranslate(); + const [t, _headers, _cookies] = await Promise.all([getTranslate(), headers(), cookies()]); - const session = await getServerSession({ req: buildLegacyRequest(await headers(), await cookies()) }); + const session = await getServerSession({ req: buildLegacyRequest(_headers, _cookies) }); if (!session?.user.id || !session?.user.profile?.organizationId || !session?.user.org) { return redirect("/settings/profile"); diff --git a/apps/web/app/(use-page-wrapper)/settings/organizations/(org-user-only)/members/page.tsx b/apps/web/app/(use-page-wrapper)/settings/organizations/(org-user-only)/members/page.tsx index c54b412e95..910607ab8e 100644 --- a/apps/web/app/(use-page-wrapper)/settings/organizations/(org-user-only)/members/page.tsx +++ b/apps/web/app/(use-page-wrapper)/settings/organizations/(org-user-only)/members/page.tsx @@ -40,9 +40,7 @@ const getCachedRoles = unstable_cache( const Page = async () => { const orgCaller = await createRouterCaller(viewerOrganizationsRouter); const [org, teams] = await Promise.all([orgCaller.listCurrent(), orgCaller.getTeams()]); - const attributes = await getCachedAttributes(org.id); - - const roles = await getCachedRoles(org.id); + const [attributes, roles] = await Promise.all([getCachedAttributes(org.id), getCachedRoles(org.id)]); const facetedTeamValues = { roles,