From 17f493a4889f5bdb70ff33fecd8557a772cc11e1 Mon Sep 17 00:00:00 2001
From: Hariom Balhara <hariombalhara@gmail.com>
Date: Fri, 28 Mar 2025 13:23:32 +0530
Subject: [PATCH] fix: 500 error on missing response id. Should be 400 (#20420)

* fix: 500 error on missing response id. Should be 400

* fix failing test
---
 packages/features/bookings/lib/handleNewBooking.ts            | 4 ++++
 .../bookings/lib/handleNewBooking/test/reschedule.test.ts     | 1 +
 2 files changed, 5 insertions(+)

diff --git a/packages/features/bookings/lib/handleNewBooking.ts b/packages/features/bookings/lib/handleNewBooking.ts
index 180ff3095d..1eb57953b9 100644
--- a/packages/features/bookings/lib/handleNewBooking.ts
+++ b/packages/features/bookings/lib/handleNewBooking.ts
@@ -456,6 +456,10 @@ async function handler(
   let routingFormResponse = null;
 
   if (routedTeamMemberIds) {
+    //routingFormResponseId could be 0 for dry run. So, we just avoid undefined value
+    if (routingFormResponseId === undefined) {
+      throw new HttpError({ statusCode: 400, message: "Missing routingFormResponseId" });
+    }
     routingFormResponse = await prisma.app_RoutingForms_FormResponse.findUnique({
       where: {
         id: routingFormResponseId,
diff --git a/packages/features/bookings/lib/handleNewBooking/test/reschedule.test.ts b/packages/features/bookings/lib/handleNewBooking/test/reschedule.test.ts
index 4bd5892e51..3df591bc87 100644
--- a/packages/features/bookings/lib/handleNewBooking/test/reschedule.test.ts
+++ b/packages/features/bookings/lib/handleNewBooking/test/reschedule.test.ts
@@ -2638,6 +2638,7 @@ describe("handleNewBooking", () => {
               start: `${plus1DateString}T04:00:00.000Z`,
               end: `${plus1DateString}T04:15:00.000Z`,
               routedTeamMemberIds: [101],
+              routingFormResponseId: 12323,
               responses: {
                 email: booker.email,
                 name: booker.name,