From 09f2aa113bc32eea024ca310fa7154f027c65582 Mon Sep 17 00:00:00 2001 From: Keith Williams Date: Sun, 21 Dec 2025 11:38:27 -0300 Subject: [PATCH] fix: resolve lint warnings in web app (#26017) * fix: resolve lint warnings in web app Co-Authored-By: keith@cal.com * fix: remove unused isReadPermission variable Co-Authored-By: keith@cal.com * fix: remove unused loading state entirely Co-Authored-By: keith@cal.com --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> --- apps/web/app/(use-page-wrapper)/layout.tsx | 1 - .../onboarding/organization/teams/page.tsx | 1 - .../app/(use-page-wrapper)/onboarding/teams/invite/page.tsx | 1 - apps/web/app/(use-page-wrapper)/refer/DubReferralsPage.tsx | 5 +---- .../roles/_components/AdvancedPermissionGroup.tsx | 1 - .../organizations/roles/_components/RoleSheet.tsx | 6 +++--- .../lib/service/booking-audit.integration-test.ts | 1 + 7 files changed, 5 insertions(+), 11 deletions(-) diff --git a/apps/web/app/(use-page-wrapper)/layout.tsx b/apps/web/app/(use-page-wrapper)/layout.tsx index 878635c237..26c3dc143e 100644 --- a/apps/web/app/(use-page-wrapper)/layout.tsx +++ b/apps/web/app/(use-page-wrapper)/layout.tsx @@ -29,7 +29,6 @@ export default async function PageWrapperLayout({ children }: { children: React. key={script.id} nonce={nonce} id={script.id} - // eslint-disable-next-line react/no-danger dangerouslySetInnerHTML={{ __html: script.script, }} diff --git a/apps/web/app/(use-page-wrapper)/onboarding/organization/teams/page.tsx b/apps/web/app/(use-page-wrapper)/onboarding/organization/teams/page.tsx index 703a06dda7..551cb713f7 100644 --- a/apps/web/app/(use-page-wrapper)/onboarding/organization/teams/page.tsx +++ b/apps/web/app/(use-page-wrapper)/onboarding/organization/teams/page.tsx @@ -1,4 +1,3 @@ -import { createRouterCaller } from "app/_trpc/context"; import { _generateMetadata } from "app/_utils"; import { cookies, headers } from "next/headers"; import { redirect } from "next/navigation"; diff --git a/apps/web/app/(use-page-wrapper)/onboarding/teams/invite/page.tsx b/apps/web/app/(use-page-wrapper)/onboarding/teams/invite/page.tsx index a6c1e4b452..408aefa918 100644 --- a/apps/web/app/(use-page-wrapper)/onboarding/teams/invite/page.tsx +++ b/apps/web/app/(use-page-wrapper)/onboarding/teams/invite/page.tsx @@ -8,7 +8,6 @@ import { APP_NAME } from "@calcom/lib/constants"; import { buildLegacyRequest } from "@lib/buildLegacyCtx"; import { TeamInviteEmailView } from "~/onboarding/teams/invite/email/team-invite-email-view"; -import { TeamInviteView } from "~/onboarding/teams/invite/team-invite-view"; export const generateMetadata = async () => { return await _generateMetadata( diff --git a/apps/web/app/(use-page-wrapper)/refer/DubReferralsPage.tsx b/apps/web/app/(use-page-wrapper)/refer/DubReferralsPage.tsx index 97cab29524..21e0e191a4 100644 --- a/apps/web/app/(use-page-wrapper)/refer/DubReferralsPage.tsx +++ b/apps/web/app/(use-page-wrapper)/refer/DubReferralsPage.tsx @@ -30,7 +30,6 @@ const fetchReferralsToken = async () => { // The enabled referrals page implementation export const DubReferralsPage = () => { const [token, setToken] = useState(null); - const [loading, setLoading] = useState(true); const { t } = useLocale(); const { resolvedTheme } = useTheme(); @@ -42,13 +41,11 @@ export const DubReferralsPage = () => { } catch (err) { console.error("Error fetching referrals token:", err); showToast(t("unexpected_error_try_again"), "error"); - } finally { - setLoading(false); } }; getToken(); - }, []); + }, [t]); if (!IS_DUB_REFERRALS_ENABLED || !token) { return null; diff --git a/apps/web/app/(use-page-wrapper)/settings/(settings-layout)/organizations/roles/_components/AdvancedPermissionGroup.tsx b/apps/web/app/(use-page-wrapper)/settings/(settings-layout)/organizations/roles/_components/AdvancedPermissionGroup.tsx index 2c7851d068..bb7d7ad133 100644 --- a/apps/web/app/(use-page-wrapper)/settings/(settings-layout)/organizations/roles/_components/AdvancedPermissionGroup.tsx +++ b/apps/web/app/(use-page-wrapper)/settings/(settings-layout)/organizations/roles/_components/AdvancedPermissionGroup.tsx @@ -139,7 +139,6 @@ export function AdvancedPermissionGroup({ } const isChecked = selectedPermissions.includes(permission); - const isReadPermission = action === CrudAction.Read; const isAutoEnabled = isReadAutoEnabled(action); return ( diff --git a/apps/web/app/(use-page-wrapper)/settings/(settings-layout)/organizations/roles/_components/RoleSheet.tsx b/apps/web/app/(use-page-wrapper)/settings/(settings-layout)/organizations/roles/_components/RoleSheet.tsx index 7d530280a8..777c50ec7c 100644 --- a/apps/web/app/(use-page-wrapper)/settings/(settings-layout)/organizations/roles/_components/RoleSheet.tsx +++ b/apps/web/app/(use-page-wrapper)/settings/(settings-layout)/organizations/roles/_components/RoleSheet.tsx @@ -6,7 +6,7 @@ import { useState, useMemo, useEffect } from "react"; import { useForm } from "react-hook-form"; import { z } from "zod"; -import type { Resource } from "@calcom/features/pbac/domain/types/permission-registry"; +import type { Resource, PermissionString } from "@calcom/features/pbac/domain/types/permission-registry"; import { CrudAction, Scope, @@ -160,7 +160,7 @@ export function RoleSheet({ teamId, roleId: role.id, name: values.name, - permissions: values.permissions as any, + permissions: values.permissions as PermissionString[], color: values.color, }); } else { @@ -169,7 +169,7 @@ export function RoleSheet({ name: values.name, description: values.description, color: values.color, - permissions: values.permissions as any, + permissions: values.permissions as PermissionString[], }); } }; diff --git a/packages/features/booking-audit/lib/service/booking-audit.integration-test.ts b/packages/features/booking-audit/lib/service/booking-audit.integration-test.ts index 2b09143b8a..c79e99b30a 100644 --- a/packages/features/booking-audit/lib/service/booking-audit.integration-test.ts +++ b/packages/features/booking-audit/lib/service/booking-audit.integration-test.ts @@ -489,3 +489,4 @@ describe("Booking Audit Integration", () => { }); }); }); +